Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply media bottom padding to CupertinoTabBar #13372

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Dec 6, 2017

This adjusts the CupertinoTabBar height in the presence of bottom
padding. On the iPhone X, this will increase the height to account for
the home indicator widget.

This adjusts the CupertinoTabBar height in the presence of bottom
padding. On the iPhone X, this will increase the height to account for
the home indicator widget.
@cbracken
Copy link
Member Author

cbracken commented Dec 6, 2017

Fixes #12099 for CupertinoTabBar, or will do once the corresponding material change lands and two lines of code are uncommented in the engine :)

@xster
Copy link
Member

xster commented Dec 6, 2017

LG

@cbracken cbracken merged commit 324ef1d into flutter:master Dec 6, 2017
@cbracken cbracken deleted the cupertino_bottom_tab_bar branch December 6, 2017 03:18
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
This adjusts the CupertinoTabBar height in the presence of bottom
padding. On the iPhone X, this will increase the height to account for
the home indicator widget.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants