Reland "Fix Chip.shape's side is not used when provided in Material 3"

[TahaTesser]

fixes Chip border side color not working in Material3
Relands #132941 with an updated fix and a regression test.

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Chips'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            const RawChip(
              shape: RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: BorderSide(color: Colors.red),
              label: Text('RawChip'),
            ),
            const Chip(
              shape: RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: BorderSide(color: Colors.red),
              label: Text('Chip'),
            ),
            ActionChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('ActionChip'),
              onPressed: () {},
            ),
            FilterChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('FilterChip'),
              onSelected: (value) {},
            ),
            ChoiceChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('ChoiceChip'),
              selected: false,
              onSelected: (value) {},
            ),
            InputChip(
              shape: const RoundedRectangleBorder(
                side: BorderSide(color: Colors.amber),
              ),
              side: const BorderSide(color: Colors.red),
              label: const Text('InputChip'),
              onSelected: (value) {},
            ),
          ],
        ),
      ),
    );
  }
}

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[HansMuller]

LGTM

[HansMuller]

So if I want to specify a shape with no border, then I need to specify both the shape and the side (as BorderSide.none) because specifying a shape with BorderSide.none will cause us to use the default side. I guess that's OK, since the OutlinedBorder classes use BorderSide.none by default. It's a little confusing. A separate PR that clarified this in the API doc might help.

[auto-submit]

auto label is removed for flutter/flutter/133856, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

[HansMuller]

@TahaTesser

This PR is failing the SuperEditor presubmit test. On the face of it, it doesn't seem related to the change here.

 | 00:34 +1234: C:/b/s/w/ir/x/t/flutter_customer_testing.super_editor.70898aa8/tests/super_editor/test/super_editor/supereditor_scrolling_test.dart: SuperEditor scrolling within an ancestor Scrollable respects horizontal scrolling inside a TabBar (on iOS)
 | 00:34 +1234: C:/b/s/w/ir/x/t/flutter_customer_testing.super_editor.70898aa8/tests/super_editor/test/super_editor/text_entry/links_test.dart: SuperEditor link editing > does not expand the link when inserting before the link (on iOS)
 | ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
 | The following TestFailure was thrown running a test:
 | Expected: given Document has equivalent content to the given markdown
 |   Actual: <Instance of 'MutableDocument'>
 |    Which: is different.
 |           Expected: Go to [www ...
 |             Actual: [www.googl ...
 |                     ^
 |            Differ at offset 0
 |
 | When the exception was thrown, this was the stack:
 | #4      main.<anonymous closure>.<anonymous closure> (file:///C:/b/s/w/ir/x/t/flutter_customer_testing.super_editor.70898aa8/tests/super_editor/test/super_editor/text_entry/links_test.dart:154:7)
 | <asynchronous suspension>
 | #5      testWidgetsOnIos.<anonymous closure> (file:///C:/b/s/w/ir/x/t/flutter_customer_testing.super_editor.70898aa8/tests/super_editor/test/test_tools.dart:424:7)
 | <asynchronous suspension>
 | #6      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:168:15)
 | <asynchronous suspension>
 | #7      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1012:5)
 | <asynchronous suspension>
 | <asynchronous suspension>
 | (elided one frame from package:stack_trace)
 |
 | This was caught by the test expectation on the following line:
 |   file:///C:/b/s/w/ir/x/t/flutter_customer_testing.super_editor.70898aa8/tests/super_editor/test/super_editor/text_entry/links_test.dart line 154
 | The test description was:
 |   does not expand the link when inserting before the link (on iOS)
 | ════════════════════════════════════════════════════════════════════════════════════════════════════
 | 00:34 +1234 -1: C:/b/s/w/ir/x/t/flutter_customer_testing.super_editor.70898aa8/tests/super_editor/test/super_editor/supereditor_scrolling_test.dart: SuperEditor scrolling within an ancestor Scrollable respects horizontal scrolling inside a TabBar (on iOS)
 | 00:34 +1234 -1: C:/b/s/w/ir/x/t/flutter_customer_testing.super_editor.70898aa8/tests/super_editor/test/super_editor/text_entry/links_test.dart: SuperEditor link editing > does not expand the link when inserting before the link (on iOS) [E]
 |   Test failed. See exception logs above.
 |   The test description was: does not expand the link when inserting before the link (on iOS)

[TahaTesser]

@TahaTesser

This PR is failing the SuperEditor presubmit test. On the face of it, it doesn't seem related to the change here.

Thanks! I will try running this with flutter/test repo locally to confirm.

[TahaTesser]

This indeed looks like an outside issue. I see this failure in other PRs.
For instance https://github.com/flutter/flutter/pull/133965/checks?check_run_id=16464555245

[TahaTesser]

blocked by #134043

[HansMuller]

Hopefully to be unblocked by flutter/tests#294

[HansMuller]

The current list of 5000 failures appear to be unrelated to this PR. Checking with the Flutter rollers ...