New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chip docs to clarify how to specify a shape with no border & explain default values for Material 3 #134298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xplain default values for Material 3
github-actions
bot
added
framework
flutter/packages/flutter repository. See also f: labels.
f: material design
flutter/packages/flutter/material repository.
labels
Sep 8, 2023
HansMuller
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HansMuller
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Sep 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2023
…border & explain default values for Material 3 (flutter/flutter#134298)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2023
…border & explain default values for Material 3 (flutter/flutter#134298)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2023
…border & explain default values for Material 3 (flutter/flutter#134298)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2023
…border & explain default values for Material 3 (flutter/flutter#134298)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 9, 2023
flutter/flutter@da676f7...7c28e8e 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e3231af6efc to d1913cb6a276 (1 revision) (flutter/flutter#134355) 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 348e3a376807 to 4e3231af6efc (1 revision) (flutter/flutter#134353) 2023-09-09 polinach@google.com Day picker should dispose created MaterialStatesController's. (flutter/flutter#133884) 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00ef109b845e to 348e3a376807 (1 revision) (flutter/flutter#134349) 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7af8a5d8d556 to 00ef109b845e (1 revision) (flutter/flutter#134336) 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f2da3d69da7 to 7af8a5d8d556 (2 revisions) (flutter/flutter#134332) 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a5f3ad1d054 to 1f2da3d69da7 (1 revision) (flutter/flutter#134328) 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6aa2d9061c1 to 3a5f3ad1d054 (3 revisions) (flutter/flutter#134327) 2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66bec85d5005 to d6aa2d9061c1 (1 revision) (flutter/flutter#134324) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d2892211366 to 66bec85d5005 (3 revisions) (flutter/flutter#134321) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2da727e23518 to 8d2892211366 (1 revision) (flutter/flutter#134316) 2023-09-08 sokolovskyi.konstantin@gmail.com Fix memory leak in _DraggableScrollableSheetState (flutter/flutter#134212) 2023-09-08 polinach@google.com RestorationManager should dispatch creation in constructor. (flutter/flutter#133911) 2023-09-08 31859944+LongCatIsLooong@users.noreply.github.com Remove TextPainter migration flag from the framework (flutter/flutter#134274) 2023-09-08 rmolivares@renzo-olivares.dev InputDecoration.error should activate error state (flutter/flutter#134001) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2cb1d271a88 to 2da727e23518 (1 revision) (flutter/flutter#134314) 2023-09-08 tessertaha@gmail.com Update chip docs to clarify how to specify a shape with no border & explain default values for Material 3 (flutter/flutter#134298) 2023-09-08 47866232+chunhtai@users.noreply.github.com Add ios analyzer command for universal links (flutter/flutter#134155) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 47a79306eed3 to b2cb1d271a88 (5 revisions) (flutter/flutter#134313) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d6b44886175 to 47a79306eed3 (2 revisions) (flutter/flutter#134310) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…border & explain default values for Material 3 (flutter/flutter#134298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Update chip docs for Material 3 defaults.
Addresses a comment from @HansMuller as well
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.