New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to read flavor from framework at run time #134179
Merged
auto-submit
merged 10 commits into
flutter:master
from
andrewkolos:add-api-for-flavor-detection
Sep 28, 2023
Merged
Add API to read flavor from framework at run time #134179
auto-submit
merged 10 commits into
flutter:master
from
andrewkolos:add-api-for-flavor-detection
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
added
tool
Affects the "flutter" command-line tool. See also t: labels.
framework
flutter/packages/flutter repository. See also f: labels.
labels
Sep 6, 2023
@@ -1234,10 +1234,13 @@ abstract class FlutterCommand extends Command<void> { | |||
} | |||
} | |||
|
|||
final String? flavor = argParser.options.containsKey('flavor') ? stringArg('flavor') : null; | |||
if (flavor != null) { | |||
dartDefines.add('FLUTTER_APP_FLAVOR=$flavor'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we already parsed user-provided dart defines at this point, and then can we check for it?
christopherfujino
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
Co-authored-by: Christopher Fujino <fujino@google.com>
andrewkolos
force-pushed
the
add-api-for-flavor-detection
branch
from
September 27, 2023 14:48
7e5b84a
to
b8c4d66
Compare
andrewkolos
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 29, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 29, 2023
Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) flutter/flutter@ff4a0f6...57b5c3c 2023-09-29 engine-flutter-autoroll@skia.org Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737) 2023-09-29 godofredoc@google.com Update localizations. (flutter/flutter#135691) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732) 2023-09-29 54558023+keyonghan@users.noreply.github.com Add arch property for windows_arm64 platform (flutter/flutter#135725) 2023-09-29 jonahwilliams@google.com [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462) 2023-09-29 polinach@google.com Pin leak_tracker before publishing breaking change. (flutter/flutter#135720) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717) 2023-09-28 katelovett@google.com Remove assertions on getOffsetToReveal (flutter/flutter#135634) 2023-09-28 fluttergithubbot@gmail.com Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701) 2023-09-28 yjbanov@google.com [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521) 2023-09-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#135455) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694) 2023-09-28 leroux_bruno@yahoo.fr Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688) 2023-09-28 matheus@btor.com.br Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361) 2023-09-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692) 2023-09-28 github@alexv525.com � Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679) 2023-09-28 andrewrkolos@gmail.com Add API to read flavor from framework at run time (flutter/flutter#134179) 2023-09-28 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567) 2023-09-28 tauu@h2overclock.de [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870) 2023-09-28 engine-flutter-autoroll@skia.org Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676) 2023-09-28 tessertaha@gmail.com Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669) 2023-09-28 zanderso@users.noreply.github.com Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672) 2023-09-28 smartercallum@gmail.com Upload generated frame-request-pending stats (flutter/flutter#135645) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652) 2023-09-28 tessertaha@gmail.com Update `TextField.style` documentation for Material 3 (flutter/flutter#135556) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637) 2023-09-28 rmolivares@renzo-olivares.dev Implement SelectionArea single click/tap gestures (flutter/flutter#132682) 2023-09-27 katelovett@google.com Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182) 2023-09-27 caseycrogers@berkeley.edu made top level if checks gaurd clauses (flutter/flutter#135070) 2023-09-27 tessertaha@gmail.com Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749) 2023-09-27 godofredoc@google.com Config changes for linux coverage. (flutter/flutter#135604) 2023-09-27 engine-flutter-autoroll@skia.org Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602) ...
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
Resolves flutter#128046. Adds a services API that allows flutter app developers to write app code that determines `--flavor` the app was built with. This is implemented by having the tool adding the value of `--flavor` to its list of dart environment declarations, which will be available to the app at run time. Specifically,`FLUTTER_APP_FLAVOR` is set. I chose this implementation for its simplicity. There is some precedent for this, but only for web ([example](https://github.com/flutter/flutter/blob/cd2f3f5e78409027d3c9014172708e4dec7f2185/packages/flutter_tools/lib/src/runner/flutter_command.dart#L1231)).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…r#5036) Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) flutter/flutter@ff4a0f6...57b5c3c 2023-09-29 engine-flutter-autoroll@skia.org Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737) 2023-09-29 godofredoc@google.com Update localizations. (flutter/flutter#135691) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732) 2023-09-29 54558023+keyonghan@users.noreply.github.com Add arch property for windows_arm64 platform (flutter/flutter#135725) 2023-09-29 jonahwilliams@google.com [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462) 2023-09-29 polinach@google.com Pin leak_tracker before publishing breaking change. (flutter/flutter#135720) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717) 2023-09-28 katelovett@google.com Remove assertions on getOffsetToReveal (flutter/flutter#135634) 2023-09-28 fluttergithubbot@gmail.com Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701) 2023-09-28 yjbanov@google.com [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521) 2023-09-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#135455) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694) 2023-09-28 leroux_bruno@yahoo.fr Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688) 2023-09-28 matheus@btor.com.br Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361) 2023-09-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692) 2023-09-28 github@alexv525.com ð��� Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679) 2023-09-28 andrewrkolos@gmail.com Add API to read flavor from framework at run time (flutter/flutter#134179) 2023-09-28 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567) 2023-09-28 tauu@h2overclock.de [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870) 2023-09-28 engine-flutter-autoroll@skia.org Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676) 2023-09-28 tessertaha@gmail.com Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669) 2023-09-28 zanderso@users.noreply.github.com Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672) 2023-09-28 smartercallum@gmail.com Upload generated frame-request-pending stats (flutter/flutter#135645) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652) 2023-09-28 tessertaha@gmail.com Update `TextField.style` documentation for Material 3 (flutter/flutter#135556) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637) 2023-09-28 rmolivares@renzo-olivares.dev Implement SelectionArea single click/tap gestures (flutter/flutter#132682) 2023-09-27 katelovett@google.com Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182) 2023-09-27 caseycrogers@berkeley.edu made top level if checks gaurd clauses (flutter/flutter#135070) 2023-09-27 tessertaha@gmail.com Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749) 2023-09-27 godofredoc@google.com Config changes for linux coverage. (flutter/flutter#135604) 2023-09-27 engine-flutter-autoroll@skia.org Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602) ...
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
framework
flutter/packages/flutter repository. See also f: labels.
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #128046.
Adds a services API that allows flutter app developers to write app code that determines
--flavor
the app was built with.This is implemented by having the tool adding the value of
--flavor
to its list of dart environment declarations, which will be available to the app at run time. Specifically,FLUTTER_APP_FLAVOR
is set. I chose this implementation for its simplicity. There is some precedent for this, but only for web (example).Pre-launch Checklist
///
).