Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TabBarView.viewportFraction change is ignored #135590

Merged
merged 1 commit into from Sep 28, 2023
Merged

Fix TabBarView.viewportFraction change is ignored #135590

merged 1 commit into from Sep 28, 2023

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Sep 27, 2023

Description

This PR updates _TabBarViewState.didUpdateWidget in order to react to TabBarView.viewportFractionchange.

Related Issue

Fixes #135557.

Tests

Adds 1 test.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 27, 2023
@bleroux bleroux force-pushed the tab_bar_view_viewport_fraction_updatable branch from d149da1 to 01303dd Compare September 27, 2023 12:54
chunhtai
chunhtai approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/tabs.dart Outdated
// While a warp is under way, we stop updating the tab page contents.
// This is tracked in https://github.com/flutter/flutter/issues/31269.
if (widget.children != oldWidget.children && _warpUnderwayCount == 0) {
_updateChildren();
}
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this?

@bleroux bleroux force-pushed the tab_bar_view_viewport_fraction_updatable branch 2 times, most recently from b2f9b99 to 9a4e08b Compare September 28, 2023 12:12
@bleroux bleroux force-pushed the tab_bar_view_viewport_fraction_updatable branch from 9a4e08b to 429db59 Compare September 28, 2023 12:22
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023
@auto-submit auto-submit bot merged commit e61f9e0 into flutter:master Sep 28, 2023
67 checks passed
@bleroux bleroux deleted the tab_bar_view_viewport_fraction_updatable branch September 28, 2023 19:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2023
@engine-flutter-autoroll
e61f9e0ce Fix TabBarView.viewportFraction change is ignored (flutter/…
a67a953 
…flutter#135590)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2023
@engine-flutter-autoroll
e61f9e0ce Fix TabBarView.viewportFraction change is ignored (flutter/…
73f3906 
…flutter#135590)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 29, 2023
@engine-flutter-autoroll
Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) (#5036)
5862201 
Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions)

flutter/flutter@ff4a0f6...57b5c3c

2023-09-29 engine-flutter-autoroll@skia.org Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737)
2023-09-29 godofredoc@google.com Update localizations. (flutter/flutter#135691)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732)
2023-09-29 54558023+keyonghan@users.noreply.github.com Add arch property for windows_arm64 platform (flutter/flutter#135725)
2023-09-29 jonahwilliams@google.com [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462)
2023-09-29 polinach@google.com Pin leak_tracker before publishing breaking change. (flutter/flutter#135720)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717)
2023-09-28 katelovett@google.com Remove assertions on getOffsetToReveal (flutter/flutter#135634)
2023-09-28 fluttergithubbot@gmail.com Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701)
2023-09-28 yjbanov@google.com [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521)
2023-09-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#135455)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694)
2023-09-28 leroux_bruno@yahoo.fr Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688)
2023-09-28 matheus@btor.com.br Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361)
2023-09-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692)
2023-09-28 github@alexv525.com � Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679)
2023-09-28 andrewrkolos@gmail.com Add API to read flavor from framework at run time (flutter/flutter#134179)
2023-09-28 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567)
2023-09-28 tauu@h2overclock.de [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870)
2023-09-28 engine-flutter-autoroll@skia.org Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676)
2023-09-28 tessertaha@gmail.com Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669)
2023-09-28 zanderso@users.noreply.github.com Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672)
2023-09-28 smartercallum@gmail.com Upload generated frame-request-pending stats (flutter/flutter#135645)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652)
2023-09-28 tessertaha@gmail.com Update `TextField.style` documentation for Material 3 (flutter/flutter#135556)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637)
2023-09-28 rmolivares@renzo-olivares.dev Implement SelectionArea single click/tap gestures (flutter/flutter#132682)
2023-09-27 katelovett@google.com Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182)
2023-09-27 caseycrogers@berkeley.edu made top level if checks gaurd clauses (flutter/flutter#135070)
2023-09-27 tessertaha@gmail.com Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749)
2023-09-27 godofredoc@google.com Config changes for linux coverage. (flutter/flutter#135604)
2023-09-27 engine-flutter-autoroll@skia.org Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602)
...
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@bleroux @Mairramer
Fix TabBarView.viewportFraction change is ignored (flutter#135590)
5847370 
## Description

This PR updates `_TabBarViewState.didUpdateWidget` in order to react to `TabBarView.viewportFraction`change.

## Related Issue

Fixes flutter#135557.

## Tests

Adds 1 test.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
e61f9e0ce Fix TabBarView.viewportFraction change is ignored (flutter/…
77862b7 
…flutter#135590)
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) (flutte…
656b019 
…r#5036)

Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions)

flutter/flutter@ff4a0f6...57b5c3c

2023-09-29 engine-flutter-autoroll@skia.org Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737)
2023-09-29 godofredoc@google.com Update localizations. (flutter/flutter#135691)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732)
2023-09-29 54558023+keyonghan@users.noreply.github.com Add arch property for windows_arm64 platform (flutter/flutter#135725)
2023-09-29 jonahwilliams@google.com [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462)
2023-09-29 polinach@google.com Pin leak_tracker before publishing breaking change. (flutter/flutter#135720)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717)
2023-09-28 katelovett@google.com Remove assertions on getOffsetToReveal (flutter/flutter#135634)
2023-09-28 fluttergithubbot@gmail.com Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701)
2023-09-28 yjbanov@google.com [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521)
2023-09-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#135455)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694)
2023-09-28 leroux_bruno@yahoo.fr Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688)
2023-09-28 matheus@btor.com.br Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361)
2023-09-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692)
2023-09-28 github@alexv525.com � Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679)
2023-09-28 andrewrkolos@gmail.com Add API to read flavor from framework at run time (flutter/flutter#134179)
2023-09-28 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567)
2023-09-28 tauu@h2overclock.de [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870)
2023-09-28 engine-flutter-autoroll@skia.org Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676)
2023-09-28 tessertaha@gmail.com Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669)
2023-09-28 zanderso@users.noreply.github.com Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672)
2023-09-28 smartercallum@gmail.com Upload generated frame-request-pending stats (flutter/flutter#135645)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652)
2023-09-28 tessertaha@gmail.com Update `TextField.style` documentation for Material 3 (flutter/flutter#135556)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637)
2023-09-28 rmolivares@renzo-olivares.dev Implement SelectionArea single click/tap gestures (flutter/flutter#132682)
2023-09-27 katelovett@google.com Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182)
2023-09-27 caseycrogers@berkeley.edu made top level if checks gaurd clauses (flutter/flutter#135070)
2023-09-27 tessertaha@gmail.com Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749)
2023-09-27 godofredoc@google.com Config changes for linux coverage. (flutter/flutter#135604)
2023-09-27 engine-flutter-autoroll@skia.org Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabBarView.viewportFraction change is ignored
2 participants
@bleroux @chunhtai