New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send analytics on 'build ios' and 'build ipa' for plist impeller value #135193
Conversation
84d575f
to
7817b1f
Compare
plistPath, PlistParser.kFLTEnableImpellerKey, | ||
); | ||
BuildEvent( | ||
impellerEnabled == false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so in the absence of this key impeller is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the flag is impeller enabled but the setting is impeller disabled :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter#135193) This analytics event only records the value of the plist entry on `build` commands. This will give an idea of the proportion of users who are disabling Impeller when shipping apps.
This analytics event only records the value of the plist entry on
build
commands. This will give an idea of the proportion of users who are disabling Impeller when shipping apps.