Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify assertion in AsyncSnapshot #135899

Merged
merged 1 commit into from Oct 7, 2023
Merged

Simplify assertion in AsyncSnapshot #135899

merged 1 commit into from Oct 7, 2023

Conversation

mateusfccp
Copy link
Contributor

Simplify assertion in AsyncSnapshot.

Fixes #135731.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 3, 2023
@mateusfccp mateusfccp force-pushed the simplify-async-snapshot-assertion branch from e20e04f to e2bab6d Compare October 5, 2023 13:11
@stuartmorgan
Copy link
Contributor

test-exempt: code refactor with no semantic change

@mateusfccp mateusfccp force-pushed the simplify-async-snapshot-assertion branch from e2bab6d to 1a58cbc Compare October 5, 2023 15:56
@mateusfccp mateusfccp force-pushed the simplify-async-snapshot-assertion branch from 1a58cbc to 0df42a1 Compare October 5, 2023 17:16
goderbauer
goderbauer approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonahwilliams
jonahwilliams approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2023
@auto-submit auto-submit bot merged commit dcd24ef into flutter:master Oct 7, 2023
67 checks passed
@mateusfccp mateusfccp deleted the simplify-async-snapshot-assertion branch October 7, 2023 01:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 7, 2023
@engine-flutter-autoroll
dcd24ef0f Simplify assertion in AsyncSnapshot (flutter/flutter#135899)
827f3e4
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 7, 2023
@engine-flutter-autoroll
Roll Flutter from ad200896cbe1 to 5207a309e8d8 (20 revisions) (#5086)
ccda715 
flutter/flutter@ad20089...5207a30

2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40024059b09e to 8711c1fd2191 (1 revision) (flutter/flutter#136110)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from eaac056b63a4 to 40024059b09e (1 revision) (flutter/flutter#136108)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f71778651333 to eaac056b63a4 (1 revision) (flutter/flutter#136107)
2023-10-07 cbobbe@zulip.com bottom_sheet: Clarify doc about behavior when useSafeArea is false (flutter/flutter#134793)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 356ab2a54862 to f71778651333 (1 revision) (flutter/flutter#136106)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f79667fb860 to 356ab2a54862 (1 revision) (flutter/flutter#136104)
2023-10-07 mateusfccp@gmail.com Simplify assertion in `AsyncSnapshot` (flutter/flutter#135899)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b28032c157ee to 1f79667fb860 (1 revision) (flutter/flutter#136103)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7bf93bb919d9 to b28032c157ee (1 revision) (flutter/flutter#136101)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb5d5c66a83e to 7bf93bb919d9 (2 revisions) (flutter/flutter#136098)
2023-10-06 737941+loic-sharma@users.noreply.github.com [Windows] Add first Arm64 plugin tests (flutter/flutter#135512)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bb228dfedfa to eb5d5c66a83e (2 revisions) (flutter/flutter#136094)
2023-10-06 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.22.0 (flutter/flutter#136095)
2023-10-06 31859944+LongCatIsLooong@users.noreply.github.com Call `markNeedsPaint` when adding overlayChild to `Overlay` (flutter/flutter#135941)
2023-10-06 zanderso@users.noreply.github.com Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (flutter/flutter#136097)
2023-10-06 fluttergithubbot@gmail.com Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (flutter/flutter#135566)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 59b6b94e1a51 to 1bb228dfedfa (1 revision) (flutter/flutter#136082)
2023-10-06 polinach@google.com RenderEditable should dispose created layers. (flutter/flutter#135942)
2023-10-06 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135961)
2023-10-06 engine-flutter-autoroll@skia.org Roll Packages from 6714d50 to e578a16 (2 revisions) (flutter/flutter#136074)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@mateusfccp @Mairramer
Simplify assertion in AsyncSnapshot (flutter#135899)
39a7b31 
Simplify assertion in `AsyncSnapshot`.

Fixes flutter#135731.
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from ad200896cbe1 to 5207a309e8d8 (20 revisions) (flutte…
f91b890 
…r#5086)

flutter/flutter@ad20089...5207a30

2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40024059b09e to 8711c1fd2191 (1 revision) (flutter/flutter#136110)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from eaac056b63a4 to 40024059b09e (1 revision) (flutter/flutter#136108)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f71778651333 to eaac056b63a4 (1 revision) (flutter/flutter#136107)
2023-10-07 cbobbe@zulip.com bottom_sheet: Clarify doc about behavior when useSafeArea is false (flutter/flutter#134793)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 356ab2a54862 to f71778651333 (1 revision) (flutter/flutter#136106)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f79667fb860 to 356ab2a54862 (1 revision) (flutter/flutter#136104)
2023-10-07 mateusfccp@gmail.com Simplify assertion in `AsyncSnapshot` (flutter/flutter#135899)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b28032c157ee to 1f79667fb860 (1 revision) (flutter/flutter#136103)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7bf93bb919d9 to b28032c157ee (1 revision) (flutter/flutter#136101)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb5d5c66a83e to 7bf93bb919d9 (2 revisions) (flutter/flutter#136098)
2023-10-06 737941+loic-sharma@users.noreply.github.com [Windows] Add first Arm64 plugin tests (flutter/flutter#135512)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bb228dfedfa to eb5d5c66a83e (2 revisions) (flutter/flutter#136094)
2023-10-06 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.22.0 (flutter/flutter#136095)
2023-10-06 31859944+LongCatIsLooong@users.noreply.github.com Call `markNeedsPaint` when adding overlayChild to `Overlay` (flutter/flutter#135941)
2023-10-06 zanderso@users.noreply.github.com Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (flutter/flutter#136097)
2023-10-06 fluttergithubbot@gmail.com Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (flutter/flutter#135566)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 59b6b94e1a51 to 1bb228dfedfa (1 revision) (flutter/flutter#136082)
2023-10-06 polinach@google.com RenderEditable should dispose created layers. (flutter/flutter#135942)
2023-10-06 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135961)
2023-10-06 engine-flutter-autoroll@skia.org Roll Packages from 6714d50 to e578a16 (2 revisions) (flutter/flutter#136074)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor unnecessarily complex assert in AsyncSnapshot constructor
4 participants
@mateusfccp @stuartmorgan @goderbauer @jonahwilliams