Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FlexibleSpaceBar does compositing with near zero opacity. #136255

Merged
merged 2 commits into from Oct 11, 2023
Merged

Fix FlexibleSpaceBar does compositing with near zero opacity. #136255

merged 2 commits into from Oct 11, 2023

Conversation

TahaTesser
Copy link
Member

fixes flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true. is thrown when scrolling down in the list and then up

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 10, 2023
jonahwilliams
jonahwilliams approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser force-pushed the fix_flexible_space_bar_push_opacity branch from e02b761 to 5dd840a Compare October 10, 2023 20:38
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2023
@auto-submit auto-submit bot merged commit 692d7ad into flutter:master Oct 11, 2023
67 checks passed
@TahaTesser TahaTesser deleted the fix_flexible_space_bar_push_opacity branch October 11, 2023 07:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
283948e 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
fcb00b1 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
166a048 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
5173b05 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
4cf4130 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
717728a 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
45f4a37 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
e54e2e9 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
e520f89 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
684a6e5 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
01be144 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
be85551 
…ity. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
a2f62c3 
…ity. (flutter/flutter#136255)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
692d7ade9 Fix FlexibleSpaceBar does compositing with near zero opac…
affe6ed 
…ity. (flutter/flutter#136255)
@vincent-hoodoo
Copy link

Our integration tests are currently failing because of the Exceptions thrown from this bug.
Do you have any idea when this fix will land in stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
3 participants
@TahaTesser @vincent-hoodoo @jonahwilliams