-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vscode-insiders path installed via snap #137117
Conversation
@DanTup does this look good to you from the VS Code side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I did wonder why the path is so different to the stable one, though I see that's being updated in #136997 so they'll match :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/flutter/137117, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/flutter@918e336...d861ce4 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410) 2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397) 2023-12-01 leroux_bruno@yahoo.fr [l10n] Update Material shareButtonLabel (flutter/flutter#138899) 2023-12-01 ian@hixie.ch Retry on transient Skia failure. (flutter/flutter#139182) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388) 2023-12-01 kristijan.zic@gmail.com Added vscode-insiders path installed via snap (flutter/flutter#137117) 2023-12-01 mdebbar@google.com Typo fix in dartdoc in tool test (flutter/flutter#139386) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264) 2023-11-30 rmolivares@renzo-olivares.dev Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674) 2023-11-30 godofredoc@google.com Migrate docs_test to shard. (flutter/flutter#139282) 2023-11-30 pateltirth454@gmail.com Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258) 2023-11-30 christopherfujino@gmail.com Refactor prepare_package.dart (flutter/flutter#139277) 2023-11-30 engine-flutter-autoroll@skia.org Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#5542) flutter/flutter@918e336...d861ce4 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410) 2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397) 2023-12-01 leroux_bruno@yahoo.fr [l10n] Update Material shareButtonLabel (flutter/flutter#138899) 2023-12-01 ian@hixie.ch Retry on transient Skia failure. (flutter/flutter#139182) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388) 2023-12-01 kristijan.zic@gmail.com Added vscode-insiders path installed via snap (flutter/flutter#137117) 2023-12-01 mdebbar@google.com Typo fix in dartdoc in tool test (flutter/flutter#139386) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264) 2023-11-30 rmolivares@renzo-olivares.dev Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674) 2023-11-30 godofredoc@google.com Migrate docs_test to shard. (flutter/flutter#139282) 2023-11-30 pateltirth454@gmail.com Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258) 2023-11-30 christopherfujino@gmail.com Refactor prepare_package.dart (flutter/flutter#139277) 2023-11-30 engine-flutter-autoroll@skia.org Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes flutter#137116 <b>Before</b> VS Code Insiders installed via Snap isn't detected. <b>After</b> ```sh [�] VS Code (version 1.84.0-insider) � VS Code at /snap/code-insiders/current/usr/share/code-insiders � Flutter extension version 3.75.20231002 ```
…r#5542) flutter/flutter@918e336...d861ce4 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410) 2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397) 2023-12-01 leroux_bruno@yahoo.fr [l10n] Update Material shareButtonLabel (flutter/flutter#138899) 2023-12-01 ian@hixie.ch Retry on transient Skia failure. (flutter/flutter#139182) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388) 2023-12-01 kristijan.zic@gmail.com Added vscode-insiders path installed via snap (flutter/flutter#137117) 2023-12-01 mdebbar@google.com Typo fix in dartdoc in tool test (flutter/flutter#139386) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264) 2023-11-30 rmolivares@renzo-olivares.dev Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674) 2023-11-30 godofredoc@google.com Migrate docs_test to shard. (flutter/flutter#139282) 2023-11-30 pateltirth454@gmail.com Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258) 2023-11-30 christopherfujino@gmail.com Refactor prepare_package.dart (flutter/flutter#139277) 2023-11-30 engine-flutter-autoroll@skia.org Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes #137116
Before
VS Code Insiders installed via Snap isn't detected.
After
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.