[l10n] Update Material shareButtonLabel #138899

bleroux · 2023-11-22T15:56:05Z

Description

This PR updates the Material label for the share option, currently it is "Share..." (the expected label on iOS), on Android it should be "Share".

Native Android TextField screenshot:

Related Issue

Step 2 for #138728

Tests

Adds 1 test.

chunhtai

This may need to go through google internal translation pipeline. @HansMuller Do you know who is taking care of that now? or is there a doc on the process?

chunhtai · 2023-11-28T17:50:36Z

packages/flutter_localizations/lib/src/l10n/material_en.arb

@@ -207,7 +207,7 @@
    "description": "The label for the Search Web button and menu items on iOS."
  },

-  "shareButtonLabel": "Share...",
+  "shareButtonLabel": "Share",
  "@shareButtonLabel": {
    "description": "The label for the Share button and menu items on iOS."


The description is inaccourate. same for other buttonlabel in this file

I upated the PR to remove the inaccurate 'on iOS' reference in those button label descriptions.

chunhtai · 2023-11-28T17:51:00Z

packages/flutter_localizations/test/material/translations_test.dart

@@ -535,9 +535,18 @@ void main() {
  // Regression test for https://github.com/flutter/flutter/issues/110451.
  testWidgets('Finnish translation for tab label', (WidgetTester tester) async {
    const Locale locale = Locale('fi');
-    expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
+    expect(GlobalMaterialLocalizations.delegate.isSupported(locale), isTrue);


why this change?

Because this was a test I wrote some months ago (https://github.com/flutter/flutter/pull/130333/files) and where I made a cut and paste mistake (in test/material/translations_test.dart, we should rely on GlobalMaterialLocalizations, in that PR I updated both the cupertino test and the material test, and I wrongly copy/pasted this line.

HansMuller · 2023-11-28T17:53:09Z

packages/flutter_localizations/lib/src/l10n/material_en.arb

@@ -207,7 +207,7 @@
    "description": "The label for the Search Web button and menu items on iOS."
  },

-  "shareButtonLabel": "Share...",
+  "shareButtonLabel": "Share",


I may be misunderstanding this but according to this PR's description, This PR updates the Material label for the share option, currently it is "Share..." (the expected label on iOS), on Android it should be "Share". So it seems like this value shouldn't change?

Sorry if this PR description is confusing, this change is the purpose of this PR: displaying 'Share' instead of 'Share...'.
'Share' is the native Android label, 'Share...' is the native iOS label.

This is similar to the select all label which is 'Select all' in Material localizations (same as native Android) and 'Select All' in Cupertino localizations (same as native iOS) :

Select all label for Material:

flutter/packages/flutter/lib/src/material/material_localizations.dart

Line 1189 in 89edac4

String get selectAllButtonLabel => 'Select all';

Select all label for Cupertino:

flutter/packages/flutter/lib/src/cupertino/localizations.dart

Line 486 in 89edac4

String get selectAllButtonLabel => 'Select All';

Thanks for the explanation. It was the description of the shareButtonLabel message that threw me off; looks like you've already fixed that.

HansMuller · 2023-11-28T18:25:02Z

This may need to go through google internal translation pipeline. @HansMuller Do you know who is taking care of that now? or is there a doc on the process?

Docs are in the comments at the top of files listed below:

If we end up adding messages to material_en.arb then this tool needs to be run to ensure that to-be-translated placeholders exist for all locales:
dev/tools/localization/bin/gen_missing_localizations.dart

If translations are updated in between releases then this tool needs to be run. Ordinarily, it's run by someone on the release team:
dev/tools/localization/bin/gen_localizations.dart

bleroux · 2023-11-28T19:01:01Z

If translations are updated in between releases then this tool needs to be run. Ordinarily, it's run by someone on the release team: dev/tools/localization/bin/gen_localizations.dart

I followed the step described at https://github.com/flutter/flutter/blob/master/packages/flutter_localizations/README.md#updating-an-existing-string
(I updated material_en.arb and ran the gen_localizations script).

bleroux · 2023-12-01T19:27:23Z

@HansMuller Do you find out who can proceed with the approval of this change and push this through google internal translation pipeline?

chunhtai

LGTM

…8899)

flutter/flutter@918e336...d861ce4 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410) 2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397) 2023-12-01 leroux_bruno@yahoo.fr [l10n] Update Material shareButtonLabel (flutter/flutter#138899) 2023-12-01 ian@hixie.ch Retry on transient Skia failure. (flutter/flutter#139182) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388) 2023-12-01 kristijan.zic@gmail.com Added vscode-insiders path installed via snap (flutter/flutter#137117) 2023-12-01 mdebbar@google.com Typo fix in dartdoc in tool test (flutter/flutter#139386) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264) 2023-11-30 rmolivares@renzo-olivares.dev Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674) 2023-11-30 godofredoc@google.com Migrate docs_test to shard. (flutter/flutter#139282) 2023-11-30 pateltirth454@gmail.com Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258) 2023-11-30 christopherfujino@gmail.com Refactor prepare_package.dart (flutter/flutter#139277) 2023-11-30 engine-flutter-autoroll@skia.org Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#5542) flutter/flutter@918e336...d861ce4 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412) 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410) 2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397) 2023-12-01 leroux_bruno@yahoo.fr [l10n] Update Material shareButtonLabel (flutter/flutter#138899) 2023-12-01 ian@hixie.ch Retry on transient Skia failure. (flutter/flutter#139182) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388) 2023-12-01 kristijan.zic@gmail.com Added vscode-insiders path installed via snap (flutter/flutter#137117) 2023-12-01 mdebbar@google.com Typo fix in dartdoc in tool test (flutter/flutter#139386) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342) 2023-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264) 2023-11-30 rmolivares@renzo-olivares.dev Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674) 2023-11-30 godofredoc@google.com Migrate docs_test to shard. (flutter/flutter#139282) 2023-11-30 pateltirth454@gmail.com Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258) 2023-11-30 christopherfujino@gmail.com Refactor prepare_package.dart (flutter/flutter#139277) 2023-11-30 engine-flutter-autoroll@skia.org Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description This PR updates the Material label for the share option, currently it is "**Share...**" (the expected label on iOS), on Android it should be "**Share**". Native Android TextField screenshot: ![Capture dâ��Ã©cran du 2023-11-20 17-19-02](https://github.com/flutter/flutter/assets/840911/6004b900-0ba4-441e-a814-4afd0c0e2fe2) ## Related Issue Step 2 for flutter#138728 ## Tests Adds 1 test.

…8899)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) labels Nov 22, 2023

bleroux mentioned this pull request Nov 22, 2023

[Android] Add 'Share' button to selection controls #138728

Closed

2 tasks

chunhtai self-requested a review November 28, 2023 17:40

chunhtai reviewed Nov 28, 2023

View reviewed changes

HansMuller reviewed Nov 28, 2023

View reviewed changes

bleroux force-pushed the l10n_update_material_share_button_label branch from fedd593 to ad10bb6 Compare November 28, 2023 19:00

chunhtai approved these changes Dec 1, 2023

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2023

bleroux added 2 commits December 1, 2023 23:14

[l10n] Update Material shareButtonLabel

df2b13b

Remove wrong references to iOS in some label descriptions

240916c

bleroux force-pushed the l10n_update_material_share_button_label branch from ad10bb6 to 240916c Compare December 1, 2023 22:14

auto-submit bot merged commit b6fa041 into flutter:master Dec 1, 2023
70 checks passed

engine-flutter-autoroll mentioned this pull request Dec 2, 2023

Manual roll Flutter from 918e336014e1 to 1e19113852c6 (22 revisions) flutter/packages#5539

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2023

b6fa04180 [l10n] Update Material shareButtonLabel (flutter/flutter#13…

c6fea8f

…8899)

engine-flutter-autoroll mentioned this pull request Dec 2, 2023

Roll Flutter from 918e336014e1 to d861ce496c9e (29 revisions) flutter/packages#5541

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2023

b6fa04180 [l10n] Update Material shareButtonLabel (flutter/flutter#13…

fd82b77

…8899)

engine-flutter-autoroll mentioned this pull request Dec 2, 2023

Roll Flutter from 918e336014e1 to d861ce496c9e (29 revisions) flutter/packages#5542

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2023

b6fa04180 [l10n] Update Material shareButtonLabel (flutter/flutter#13…

66a74e7

…8899)

bleroux deleted the l10n_update_material_share_button_label branch December 4, 2023 06:53

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

b6fa04180 [l10n] Update Material shareButtonLabel (flutter/flutter#13…

eff1019

…8899)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[l10n] Update Material shareButtonLabel #138899

[l10n] Update Material shareButtonLabel #138899

bleroux commented Nov 22, 2023

chunhtai left a comment

chunhtai Nov 28, 2023

bleroux Nov 28, 2023

chunhtai Nov 28, 2023

bleroux Nov 28, 2023

HansMuller Nov 28, 2023

bleroux Nov 28, 2023

HansMuller Nov 28, 2023

HansMuller commented Nov 28, 2023

bleroux commented Nov 28, 2023

bleroux commented Dec 1, 2023

chunhtai left a comment

[l10n] Update Material shareButtonLabel #138899

[l10n] Update Material shareButtonLabel #138899

Conversation

bleroux commented Nov 22, 2023

Description

Related Issue

Tests

chunhtai left a comment

Choose a reason for hiding this comment

chunhtai Nov 28, 2023

Choose a reason for hiding this comment

bleroux Nov 28, 2023

Choose a reason for hiding this comment

chunhtai Nov 28, 2023

Choose a reason for hiding this comment

bleroux Nov 28, 2023

Choose a reason for hiding this comment

HansMuller Nov 28, 2023

Choose a reason for hiding this comment

bleroux Nov 28, 2023

Choose a reason for hiding this comment

HansMuller Nov 28, 2023

Choose a reason for hiding this comment

HansMuller commented Nov 28, 2023

bleroux commented Nov 28, 2023

bleroux commented Dec 1, 2023

chunhtai left a comment

Choose a reason for hiding this comment