Fix chips onDeleted callback don't show the delete button when disabled

[TahaTesser]

fixes Chips with onDeleted callback should show the delete button in the disabled state

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onSelected: null,
              isEnabled: false,
              onDeleted: () {},
            ),
            InputChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: false,
              onPressed: null,
              onDeleted: () {},
            ),
            FilterChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              onSelected: null,
              onDeleted: () {},
            ),
          ],
        ),
      ),
    );
  }
}

Before	After

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[flutter-dashboard]

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha 820f38fe8bfbbf37a15653354eb91a709f43e1ef

[HansMuller]

LGTM - there are quite a few golden file changes; please check to see that they're all valid.

[flutter-dashboard]

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha af3b0d48b544abb1fca652f1d731433c18080514

[flutter-dashboard]

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha bd5dcd7

[TahaTesser]

Blocked by #138009

[Piinks]

I don't know that this is blocked by #138009, @TahaTesser can you share more context? I think that issue can be fixed before or after this one lands.

[TahaTesser]

I don't know that this is blocked by #138009, @TahaTesser can you share more context? I think that issue can be fixed before or after this one lands.

Chip with a delete button isn't rendered properly when disabled in the canvaskit renderer after #136918
Unfortunately, this PR is also testing Chip with a delete button in the disabled state.

We will need to be able to test the chip in canvaskit renderer

[TahaTesser]

Waiting for flutter/engine#48142 to roll into framework

[flutter-dashboard]

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha a717230

[flutter-dashboard]

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha a1c8c28

[flutter-dashboard]

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha 4329405

[TahaTesser]

Rebased to get engine fix flutter/engine#48142

Pushed an empty to get updated golden files and approved the golden files.

[Piinks]

It looks like there is a merge conflict here. I checked the Google testing failure, and it looks unrelated, but a rebase with the merge being resolved would help confirming that. :)

[TahaTesser]

It looks like there is a merge conflict here.

It's actually a conflict from my own PR #138287 😂

I checked the Google testing failure, and it looks unrelated

It was failing before the conflict. Let me resolve the conflict and try again.

[TahaTesser]

@Piinks
After multiple tries, this is finally green. Is it safe to merge?

[TahaTesser]

Pushed an empty to make sure all is good.

[Piinks]

I checked the goldens, and they should be good to go. I'll keep an eye on when this lands though just in case there is an issue. :)