Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated PlatformMenuBar.body #138509

Merged
merged 6 commits into from Nov 29, 2023
Merged

Remove deprecated PlatformMenuBar.body #138509

merged 6 commits into from Nov 29, 2023

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Nov 15, 2023 •
edited

Part of #139243

Description

This removes the PlatformMenuBar.body attribute and constructor parameter, since its deprecation period has elapsed.

Tests

  • No tests were using the deprecated attribute, so no tests were removed.

#FlutterDeprecations

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. c: tech-debt Technical debt, code quality, testing, etc. labels Nov 15, 2023
@stuartmorgan
Copy link
Contributor

test-exempt: removing code

Piinks
Piinks reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks for adding a dart fix! We have not announced the next round of deprecations, so let's wait to land until next week. 👍

packages/flutter/test_fixes/widgets/widgets.dart Show resolved Hide resolved
@github-actions github-actions bot added f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Nov 16, 2023
Piinks
Piinks approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023
@auto-submit auto-submit bot merged commit 6295289 into flutter:master Nov 29, 2023
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
629528916 Remove deprecated PlatformMenuBar.body (flutter/flutter#1…
d8bd406 
…38509)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
Roll Flutter from 5e5b5292f739 to 918e336014e1 (14 revisions) (#5526)
9cdc001 
flutter/flutter@5e5b529...918e336

2023-11-30 zanderso@users.noreply.github.com Move Impeller tests on Pixel 7 Pro from staging to prod (flutter/flutter#139280)
2023-11-30 xubaolin@oppo.com Introduce multi-touch drag strategies for `DragGestureRecognizer` (flutter/flutter#136708)
2023-11-30 godofredoc@google.com Use the correct recipe on fuchsia_precache. (flutter/flutter#139279)
2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migration for the `sendTiming` events for `package:unified_analytics`" (flutter/flutter#139278)
2023-11-30 godofredoc@google.com Migrate fuchsia_precache to shard tests. (flutter/flutter#139202)
2023-11-29 tessertaha@gmail.com Fix chips `onDeleted` callback don't show the delete button when disabled (flutter/flutter#137685)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (flutter/flutter#139259)
2023-11-29 58190796+MitchellGoodwin@users.noreply.github.com Refactor to use Apple system fonts (flutter/flutter#137275)
2023-11-29 goderbauer@google.com Dynamic view sizing (flutter/flutter#138648)
2023-11-29 ian@hixie.ch Roll dependencies (flutter/flutter#139203)
2023-11-29 92773903+yakagami@users.noreply.github.com add sourceTimeStamp to ScaleUpdateDetails (flutter/flutter#135936)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (flutter/flutter#139250)
2023-11-29 gspencergoog@users.noreply.github.com Remove deprecated `PlatformMenuBar.body` (flutter/flutter#138509)
2023-11-29 42216813+eliasyishak@users.noreply.github.com Migration for the `sendTiming` events for `package:unified_analytics` (flutter/flutter#138896)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from 5e5b5292f739 to 918e336014e1 (14 revisions) (flutte…
d06cba6 
…r#5526)

flutter/flutter@5e5b529...918e336

2023-11-30 zanderso@users.noreply.github.com Move Impeller tests on Pixel 7 Pro from staging to prod (flutter/flutter#139280)
2023-11-30 xubaolin@oppo.com Introduce multi-touch drag strategies for `DragGestureRecognizer` (flutter/flutter#136708)
2023-11-30 godofredoc@google.com Use the correct recipe on fuchsia_precache. (flutter/flutter#139279)
2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migration for the `sendTiming` events for `package:unified_analytics`" (flutter/flutter#139278)
2023-11-30 godofredoc@google.com Migrate fuchsia_precache to shard tests. (flutter/flutter#139202)
2023-11-29 tessertaha@gmail.com Fix chips `onDeleted` callback don't show the delete button when disabled (flutter/flutter#137685)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (flutter/flutter#139259)
2023-11-29 58190796+MitchellGoodwin@users.noreply.github.com Refactor to use Apple system fonts (flutter/flutter#137275)
2023-11-29 goderbauer@google.com Dynamic view sizing (flutter/flutter#138648)
2023-11-29 ian@hixie.ch Roll dependencies (flutter/flutter#139203)
2023-11-29 92773903+yakagami@users.noreply.github.com add sourceTimeStamp to ScaleUpdateDetails (flutter/flutter#135936)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (flutter/flutter#139250)
2023-11-29 gspencergoog@users.noreply.github.com Remove deprecated `PlatformMenuBar.body` (flutter/flutter#138509)
2023-11-29 42216813+eliasyishak@users.noreply.github.com Migration for the `sendTiming` events for `package:unified_analytics` (flutter/flutter#138896)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@gspencergoog @caseycrogers
Remove deprecated PlatformMenuBar.body (flutter#138509)
a07ad0b 
Part of flutter#139243

## Description

This removes the `PlatformMenuBar.body` attribute and constructor parameter, since its deprecation period has elapsed.

## Tests
 - No tests were using the deprecated attribute, so no tests were removed.

#FlutterDeprecations
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
629528916 Remove deprecated PlatformMenuBar.body (flutter/flutter#1…
367c3aa 
…38509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: tech-debt Technical debt, code quality, testing, etc. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gspencergoog @stuartmorgan @Piinks