Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix FlutterTestRunner.java deprecations #138093

Merged
merged 1 commit into from Nov 8, 2023
Merged

[Android] Fix FlutterTestRunner.java deprecations #138093

merged 1 commit into from Nov 8, 2023

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Nov 8, 2023 •
edited

Fixes deprecations causing unexpected standard error integration test failures: #138061, #138063, #138067, #138077.

Note that the issue this fixes was the same that was the cause for reverting #137191. I made this same fix in #137967 and changed Mac_android run_release_test to run in presubmit to see a successful run for proof that this fix works.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Nov 8, 2023
@camsim99 camsim99 requested a review from a team November 8, 2023 18:22
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2023
@auto-submit auto-submit bot merged commit 3215c49 into flutter:master Nov 8, 2023
67 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 9, 2023
@engine-flutter-autoroll
3215c492c [Android] Fix FlutterTestRunner.java deprecations (flutte…
6dd7742 
…r/flutter#138093)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 9, 2023
@engine-flutter-autoroll
3215c492c [Android] Fix FlutterTestRunner.java deprecations (flutte…
79491b2 
…r/flutter#138093)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 9, 2023
@engine-flutter-autoroll
Roll Flutter from 4b4a1feb46d1 to f66215027e14 (17 revisions) (#5361)
a682189 
flutter/flutter@4b4a1fe...f662150

2023-11-09 engine-flutter-autoroll@skia.org Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149)
2023-11-09 andrewrkolos@gmail.com prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118)
2023-11-09 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#138114)
2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116)
2023-11-08 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/flutter#138115)
2023-11-08 christopherfujino@gmail.com [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111)
2023-11-08 goderbauer@google.com Remove physicalGeometry (flutter/flutter#138103)
2023-11-08 43054281+camsim99@users.noreply.github.com [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093)
2023-11-08 chillers@google.com Remove fuchsia mac version (flutter/flutter#138101)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108)
2023-11-08 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073)
2023-11-08 dnfield@google.com Document additional cases  (flutter/flutter#137957)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100)
2023-11-08 prasadsunny1@gmail.com Add support for color and color blendmode in FadeInImage (flutter/flutter#137681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Nov 9, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
auto-submit bot pushed a commit that referenced this pull request Nov 9, 2023
@camsim99
[Android] Support Android 34 (take 2) (#137967)
c66bb0a 
Re-lands #137191.

The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in #138093.
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from 4b4a1feb46d1 to f66215027e14 (17 revisions) (flutte…
8aa7d3e 
…r#5361)

flutter/flutter@4b4a1fe...f662150

2023-11-09 engine-flutter-autoroll@skia.org Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149)
2023-11-09 andrewrkolos@gmail.com prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118)
2023-11-09 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#138114)
2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116)
2023-11-08 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/flutter#138115)
2023-11-08 christopherfujino@gmail.com [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111)
2023-11-08 goderbauer@google.com Remove physicalGeometry (flutter/flutter#138103)
2023-11-08 43054281+camsim99@users.noreply.github.com [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093)
2023-11-08 chillers@google.com Remove fuchsia mac version (flutter/flutter#138101)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108)
2023-11-08 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073)
2023-11-08 dnfield@google.com Document additional cases  (flutter/flutter#137957)
2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100)
2023-11-08 prasadsunny1@gmail.com Add support for color and color blendmode in FadeInImage (flutter/flutter#137681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
3215c492c [Android] Fix FlutterTestRunner.java deprecations (flutte…
7ef90aa 
…r/flutter#138093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@camsim99 @reidbaker