Remove physicalGeometry #138103
Merged
Remove physicalGeometry #138103
+4
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
loic-sharma
approved these changes
Nov 8, 2023
goderbauer
added
the
autosubmit
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 9, 2023
Looks like this was proactively added in #20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery. Related framework PR: flutter/flutter#138103 (Checks will fail until that PR is submitted).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2023
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Nov 9, 2023
Reverts #47825 Initiated by: zanderso This change reverts the following previous change: Original Description: Looks like this was proactively added in #20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery. Related framework PR: flutter/flutter#138103 (Checks will fail until that PR is submitted).
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 9, 2023
flutter/flutter@4b4a1fe...f662150 2023-11-09 engine-flutter-autoroll@skia.org Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149) 2023-11-09 andrewrkolos@gmail.com prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095) 2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118) 2023-11-09 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#138114) 2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116) 2023-11-08 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/flutter#138115) 2023-11-08 christopherfujino@gmail.com [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111) 2023-11-08 goderbauer@google.com Remove physicalGeometry (flutter/flutter#138103) 2023-11-08 43054281+camsim99@users.noreply.github.com [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093) 2023-11-08 chillers@google.com Remove fuchsia mac version (flutter/flutter#138101) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108) 2023-11-08 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073) 2023-11-08 dnfield@google.com Document additional cases (flutter/flutter#137957) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100) 2023-11-08 prasadsunny1@gmail.com Add support for color and color blendmode in FadeInImage (flutter/flutter#137681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…r#5361) flutter/flutter@4b4a1fe...f662150 2023-11-09 engine-flutter-autoroll@skia.org Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149) 2023-11-09 andrewrkolos@gmail.com prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095) 2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118) 2023-11-09 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#138114) 2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116) 2023-11-08 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/flutter#138115) 2023-11-08 christopherfujino@gmail.com [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111) 2023-11-08 goderbauer@google.com Remove physicalGeometry (flutter/flutter#138103) 2023-11-08 43054281+camsim99@users.noreply.github.com [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093) 2023-11-08 chillers@google.com Remove fuchsia mac version (flutter/flutter#138101) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108) 2023-11-08 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073) 2023-11-08 dnfield@google.com Document additional cases (flutter/flutter#137957) 2023-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100) 2023-11-08 prasadsunny1@gmail.com Add support for color and color blendmode in FadeInImage (flutter/flutter#137681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
passsy
added a commit
to wiredashio/wiredash-sdk
that referenced
this pull request
Dec 28, 2023
It was never wired up in the flutter engine, never provided any useful value other than windowSize flutter/flutter#138103
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was proactively added in flutter/engine#20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.
Related engine PR: flutter/engine#47825