Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off leak tracker in master to make found leaks not blocking. #138567

Merged
merged 4 commits into from Nov 16, 2023
Merged

Turn off leak tracker in master to make found leaks not blocking. #138567

merged 4 commits into from Nov 16, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Nov 16, 2023 •
edited

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 16, 2023
@matanlurey
Copy link
Contributor

I don't work on the framework so I'm the wrong person to review this PR, reviewed myself. Thanks!

@matanlurey matanlurey removed their request for review November 16, 2023 22:00
@polina-c polina-c changed the title Turn off leak tracker to make found leaks not blocking. Turn off leak tracker in master to make found leaks not blocking. Nov 16, 2023
jacob314
jacob314 reviewed Nov 16, 2023
View reviewed changes
packages/flutter/test/flutter_test_config.dart
@@ -27,9 +27,9 @@ Future<void> testExecutable(FutureOr<void> Function() testMain) {

// TODO(polina-c): clean up leaks and stop ignoring them.
// https://github.com/flutter/flutter/issues/137311
// Leak tracking is off by default. To temporary enable it add `.withTrackedAll()` after `settings`.
LeakTesting.settings = LeakTesting
.settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to unblock for now but you might want to consider using an environment variable to allow users to turn on leak tracking by setting the environment variable when calling flutter test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there difference in effort to add flag and to add this line of code?

Created PR that will show memory leaks: #138581
The plan is to refresh it manually and check if there are leaks.

Do you happen to have other automation in mind?

jacob314
jacob314 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c merged commit 2dc8111 into flutter:master Nov 16, 2023
69 checks passed
@polina-c polina-c deleted the turn-off branch November 16, 2023 22:45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
2dc811135 Turn off leak tracker in master to make found leaks not blo…
2885744 
…cking. (flutter/flutter#138567)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
2dc811135 Turn off leak tracker in master to make found leaks not blo…
1de8f88 
…cking. (flutter/flutter#138567)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
2dc811135 Turn off leak tracker in master to make found leaks not blo…
34c2acc 
…cking. (flutter/flutter#138567)
@HansMuller HansMuller mentioned this pull request Nov 17, 2023
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2023
@engine-flutter-autoroll
2dc811135 Turn off leak tracker in master to make found leaks not blo…
524f78d 
…cking. (flutter/flutter#138567)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2023
@engine-flutter-autoroll
Roll Flutter from 53a57adcf136 to 6cf9ab02baec (31 revisions) (#5426)
2e010d8 
flutter/flutter@53a57ad...6cf9ab0

2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (flutter/flutter#138668)
2023-11-18 ryjohn@google.com Update release.yml (flutter/flutter#138561)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (flutter/flutter#138660)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (flutter/flutter#138658)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (flutter/flutter#138655)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (flutter/flutter#138652)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (flutter/flutter#138650)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (flutter/flutter#138647)
2023-11-17 parlough@gmail.com Update links and surrounding text for new `main-api` docs (flutter/flutter#138602)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (flutter/flutter#138643)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (flutter/flutter#138637)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (flutter/flutter#138599)
2023-11-17 linxunfeng@yeah.net Fix NoSplash not being disposed (flutter/flutter#138542)
2023-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `AnimationStyle`" (flutter/flutter#138628)
2023-11-17 victoreronmosele@gmail.com Enable `flutter screenshot` outside Flutter project directory (flutter/flutter#138160)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (flutter/flutter#138585)
2023-11-16 47866232+chunhtai@users.noreply.github.com Improves output file path logic in Android analyze (flutter/flutter#136981)
2023-11-16 polinach@google.com Turn off leak tracker in master to make found leaks not blocking. (flutter/flutter#138567)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (flutter/flutter#138574)
2023-11-16 jason-simmons@users.noreply.github.com Enable the silent flag for invalid string exceptions when building a TextSpan (flutter/flutter#138564)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (flutter/flutter#138568)
2023-11-16 arpitgandhi9@users.noreply.github.com #60704: Pass cert for TLS localhost connection (flutter/flutter#106635)
2023-11-16 lsaudon@gmail.com Bump cupertino_icons to 1.0.6 (flutter/flutter#136962)
2023-11-16 72284940+feduke-nukem@users.noreply.github.com Fix sliver persistent header expand animation (flutter/flutter#137913)
2023-11-16 ian@hixie.ch Reduce animations further when --no-cli-animations is set. (flutter/flutter#133598)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (flutter/flutter#138560)
2023-11-16 tessertaha@gmail.com Introduce `AnimationStyle` (flutter/flutter#137945)
2023-11-16 dnfield@google.com Just use string interpolation for ws url for tests (flutter/flutter#138235)
2023-11-16 104349824+huycozy@users.noreply.github.com Adding new packages to the first-party package issue template (flutter/flutter#138540)
2023-11-16 engine-flutter-autoroll@skia.org Roll Packages from 0cd2378 to 07b4b29 (3 revisions) (flutter/flutter#138549)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (flutter/flutter#138546)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Nov 27, 2023
@polina-c @Markzipan
Turn off leak tracker in master to make found leaks not blocking. (fl…
c261dfb 
…utter#138567)
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from 53a57adcf136 to 6cf9ab02baec (31 revisions) (flutte…
7cc44f6 
…r#5426)

flutter/flutter@53a57ad...6cf9ab0

2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (flutter/flutter#138668)
2023-11-18 ryjohn@google.com Update release.yml (flutter/flutter#138561)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (flutter/flutter#138660)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (flutter/flutter#138658)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (flutter/flutter#138655)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (flutter/flutter#138652)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (flutter/flutter#138650)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (flutter/flutter#138647)
2023-11-17 parlough@gmail.com Update links and surrounding text for new `main-api` docs (flutter/flutter#138602)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (flutter/flutter#138643)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (flutter/flutter#138637)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (flutter/flutter#138599)
2023-11-17 linxunfeng@yeah.net Fix NoSplash not being disposed (flutter/flutter#138542)
2023-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `AnimationStyle`" (flutter/flutter#138628)
2023-11-17 victoreronmosele@gmail.com Enable `flutter screenshot` outside Flutter project directory (flutter/flutter#138160)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (flutter/flutter#138585)
2023-11-16 47866232+chunhtai@users.noreply.github.com Improves output file path logic in Android analyze (flutter/flutter#136981)
2023-11-16 polinach@google.com Turn off leak tracker in master to make found leaks not blocking. (flutter/flutter#138567)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (flutter/flutter#138574)
2023-11-16 jason-simmons@users.noreply.github.com Enable the silent flag for invalid string exceptions when building a TextSpan (flutter/flutter#138564)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (flutter/flutter#138568)
2023-11-16 arpitgandhi9@users.noreply.github.com #60704: Pass cert for TLS localhost connection (flutter/flutter#106635)
2023-11-16 lsaudon@gmail.com Bump cupertino_icons to 1.0.6 (flutter/flutter#136962)
2023-11-16 72284940+feduke-nukem@users.noreply.github.com Fix sliver persistent header expand animation (flutter/flutter#137913)
2023-11-16 ian@hixie.ch Reduce animations further when --no-cli-animations is set. (flutter/flutter#133598)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (flutter/flutter#138560)
2023-11-16 tessertaha@gmail.com Introduce `AnimationStyle` (flutter/flutter#137945)
2023-11-16 dnfield@google.com Just use string interpolation for ws url for tests (flutter/flutter#138235)
2023-11-16 104349824+huycozy@users.noreply.github.com Adding new packages to the first-party package issue template (flutter/flutter#138540)
2023-11-16 engine-flutter-autoroll@skia.org Roll Packages from 0cd2378 to 07b4b29 (3 revisions) (flutter/flutter#138549)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (flutter/flutter#138546)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2dc811135 Turn off leak tracker in master to make found leaks not blo…
f832422 
…cking. (flutter/flutter#138567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob314 jacob314 jacob314 approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polina-c @matanlurey @jacob314