Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cp-beta]some random title #140497

Closed
wants to merge 1 commit into from
Closed

[cp-beta]some random title #140497

wants to merge 1 commit into from

Conversation

XilaiZhang
Copy link
Contributor

This pull request is opened against a release branch.

To request a cherry pick of a commit, please fill in the form below. (Questions with an asterisk are required.)

To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.

A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.

  • Issue Link: What is the link to the issue this cherry-pick is addressing?
  My Answer:



  My Answer:
  • Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
  My Answer:
  • impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
  My Answer:
  • Workaround: Is there a workaround for this issue?
  My Answer:
  • Risk: What is the risk level of this cherry-pick?
  My Answer:
  - [ ] Low
  - [ ] Medium
  - [ ] High
  • Test Coverage: Are you confident that your fix is well-tested by automated tests?
  My Answer:
  - [ ] Yes
  - [ ] No
  • Validation Steps: What are the steps to validate that this fix works?
  My Answer:

[github] Remove commit hash from CP issue template (#139676)
f860787 
* This seems to be unnecessary as users will open a CP PR with the original commit linked in it.
* Add note on changelog description to be less than 80 chars
@XilaiZhang XilaiZhang added the cp: review Cherry-picks in the review queue label Dec 21, 2023
@XilaiZhang XilaiZhang closed this Dec 21, 2023
@XilaiZhang XilaiZhang mentioned this pull request Dec 21, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Jan 3, 2024
@XilaiZhang
[github actions] refactor and fix cherry pick actions (#140499)
f0e616e 
This PR makes the following changes:

1. Remove dependency on [peters/evans package](https://github.com/marketplace/actions/create-pull-request)<br>
The market place action introduces overheads that don't properly consume tokens. e.g. :[failed workflow that says token is not supplied](https://github.com/flutter/flutter/actions/runs/7282529195/job/19845096943)
This PR changes the market place action to git commands that we have full control over, provides better error msg for debug, and properly consumes token.

2. Align usage of tokens:<br>
All tokens in the workflow now uses flutter actions bot PAT token. From experiments, a mixed usage of different tokens in different steps sometimes cause the workflow to fail on authentication.

Tested: Tested with [a similar workflow on my personal repository](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml), and it produces the [expected cherry pick PR as end result](#140497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees
No one assigned
Labels
cp: review Cherry-picks in the review queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XilaiZhang @fluttergithubbot