Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER #140808

Merged
merged 1 commit into from Jan 3, 2024
Merged

Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER #140808

merged 1 commit into from Jan 3, 2024

Conversation

mossmana
Copy link
Contributor

@mossmana mossmana commented Jan 2, 2024

#1670

Note: This PR replaces the the original PR (#138240) that got into a state where a rebase was not possible and made it difficult to determine what was causing unrelated test failures.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 2, 2024
@mossmana mossmana linked an issue Jan 2, 2024 that may be closed by this pull request
Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER #1670
Closed
gspencergoog
gspencergoog approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@mossmana mossmana added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jan 2, 2024

auto label is removed for flutter/flutter/140808, Failed to merge flutter/flutter/140808 with Pull request flutter/flutter/140808 could not be merged: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024
@mossmana mossmana changed the base branch from main to master January 2, 2024 18:39
@mossmana mossmana added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@auto-submit auto-submit bot merged commit 743cdd6 into flutter:master Jan 3, 2024
69 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
743cdd68b Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutt…
01b321b 
…er#140808)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
743cdd68b Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutt…
80b5271 
…er#140808)
tarrinneal added a commit to flutter/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll @tarrinneal
Manual roll Flutter from 11def8eff455 to cc40425ddcef (118 revisions) (…
b9b6d38 
…#5806)

Manual roll Flutter from 11def8eff455 to cc40425ddcef (118 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@11def8e...cc40425

2024-01-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0bbb4d61ce82 to f60d9a9a3395 (1 revision) (flutter/flutter#140993)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (flutter/flutter#140990)
2024-01-04 yjbanov@google.com [web] Fix and unskip a few more CanvasKit
tests (flutter/flutter#140821)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bd175aa5e0b6 to b2a9ce88a19e (1 revision) (flutter/flutter#140986)
2024-01-04 danny@tuppeny.com Pin package:vm_service
(flutter/flutter#140972)
2024-01-04 36861262+QuncCccccc@users.noreply.github.com Add scrollbar
for menus (flutter/flutter#140941)
2024-01-04 christopherfujino@gmail.com manual pub roll to pick up dds
fixes (flutter/flutter#140979)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b81023eb71c9 to bd175aa5e0b6 (2 revisions) (flutter/flutter#140980)
2024-01-04 polinach@google.com Temporarily remove env variable for leak
tracking bots. (flutter/flutter#140978)
2024-01-04 chillers@google.com Add Flutter CI status to README
(flutter/flutter#140513)
2024-01-04 polinach@google.com Reland "integrate testWidgets with leak
tracking" (#140521) (flutter/flutter#140928)
2024-01-04 15619084+vashworth@users.noreply.github.com Run half of iOS
devicelab tests with Xcode 15 (flutter/flutter#140927)
2024-01-04 39755477+sharabiddin@users.noreply.github.com Fix
`SegmentedButton` states update logic (flutter/flutter#140772)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f539acfb8c5a to b81023eb71c9 (1 revision) (flutter/flutter#140973)
2024-01-04 pateltirth454@gmail.com [Fix] Consistency in
ButtonStyleButton related Tests (flutter/flutter#140610)
2024-01-04 engine-flutter-autoroll@skia.org Roll Packages from
bbb4134 to 31fc7b5 (6 revisions) (flutter/flutter#140967)
2024-01-04 stuartmorgan@google.com Fix local engine use in macOS plugins
(flutter/flutter#140222)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7d5a120a601b to f539acfb8c5a (2 revisions) (flutter/flutter#140959)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1ff3cb885842 to 7d5a120a601b (1 revision) (flutter/flutter#140946)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c8bf51f0d4cd to 1ff3cb885842 (1 revision) (flutter/flutter#140943)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bfd2d8a100ec to c8bf51f0d4cd (2 revisions) (flutter/flutter#140939)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
28ae9e35c331 to bfd2d8a100ec (1 revision) (flutter/flutter#140937)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
ab4098c742f8 to 28ae9e35c331 (1 revision) (flutter/flutter#140936)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e169f3677008 to ab4098c742f8 (2 revisions) (flutter/flutter#140933)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7c2adb811059 to e169f3677008 (1 revision) (flutter/flutter#140929)
2024-01-03 magder@google.com Remove deprecated bitcode stripping from
tooling (flutter/flutter#140903)
2024-01-03 54558023+keyonghan@users.noreply.github.com Add Windows leak
tracking targets (flutter/flutter#140423)
2024-01-03 xilaizhang@google.com [github actions] refactor and fix
cherry pick actions (flutter/flutter#140499)
2024-01-03 magder@google.com Migrate Xcode projects last version checks
to Xcode 15.1 (flutter/flutter#140256)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bf232c4da241 to 7c2adb811059 (3 revisions) (flutter/flutter#140920)
2024-01-03 goderbauer@google.com fix typo and reflow
(flutter/flutter#140925)
2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Re-land integrate testWidgets with leak tracking."
(flutter/flutter#140926)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bf979d220283 to bf232c4da241 (1 revision) (flutter/flutter#140915)
2024-01-03 ybz975218925@gmail.com Changes the regular cursor to a
floating cursor when a long press occurs. (flutter/flutter#138479)
2024-01-03 65075121+AcarFurkan@users.noreply.github.com Add
`SegmentedButton.styleFrom` (flutter/flutter#137542)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c62bcff5b809 to bf979d220283 (1 revision) (flutter/flutter#140910)
2024-01-03 polinach@google.com Re-land integrate testWidgets with leak
tracking. (flutter/flutter#140521)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
98b72c7ffe71 to c62bcff5b809 (2 revisions) (flutter/flutter#140905)
2024-01-03 jonahwilliams@google.com [flutter_tools] add support for
--enable-impeller to test device. (flutter/flutter#140899)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cf7536964a2f to 98b72c7ffe71 (1 revision) (flutter/flutter#140897)
2024-01-03 233583+mossmana@users.noreply.github.com Handle
KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutter#140808)
2024-01-03 lsaudon@gmail.com Add Lucas Saudon to AUTHORS
(flutter/flutter#139965)
2024-01-03 21270878+elliette@users.noreply.github.com Link to wiki page
about updating dependencies in each `pubspec.yaml` file
(flutter/flutter#140826)
2024-01-03 fluttergithubbot@gmail.com Marks Linux_pixel_7pro
native_assets_android to be unflaky (flutter/flutter#140866)
...

---------

Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this pull request Jan 6, 2024
@mossmana @victoreronmosele
Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter#140808)
f6a9cbe 
flutter#1670

Note: This PR replaces the the original PR (flutter#138240) that got into a state where a rebase was not possible and made it difficult to determine what was causing unrelated test failures.
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
@mossmana @Michal-MK
Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter#140808)
f8147d2 
flutter#1670

Note: This PR replaces the the original PR (flutter#138240) that got into a state where a rebase was not possible and made it difficult to determine what was causing unrelated test failures.
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
@mossmana @Markzipan
Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter#140808)
24f38d5 
flutter#1670

Note: This PR replaces the the original PR (flutter#138240) that got into a state where a rebase was not possible and made it difficult to determine what was causing unrelated test failures.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
743cdd68b Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutt…
03bc4de 
…er#140808)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER
2 participants
@mossmana @gspencergoog