Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "integrate testWidgets with leak tracking" (#140521) #140928

Merged
merged 128 commits into from Jan 4, 2024
Merged

Reland "integrate testWidgets with leak tracking" (#140521) #140928

merged 128 commits into from Jan 4, 2024

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Jan 3, 2024 •
edited

Reverted PR: #140521
Fix: actually use the created flag in _configureTearDownForTestFile().

Tested by setting presubmit: true for Linux_android flutter_test_performance.

@polina-c
Update pubspec.yaml
16e7edc
@polina-c
Update pubspec.yaml
8226a79
@polina-c
Merge branch 'master' of https://github.com/flutter/flutter into add-dep
cefe66b
@polina-c
Update allowlist.dart
068e7a1
@polina-c
Merge branch 'master' of https://github.com/flutter/flutter into add-dep
3d26793
@polina-c
-
78fea14
@polina-c
Merge branch 'master' of https://github.com/flutter/flutter into add-dep
2fbe48f
@polina-c
Revert "-"
97ddb3f 
This reverts commit 78fea14.
@polina-c
-
2725971
@polina-c
Merge branch 'master' of https://github.com/flutter/flutter into add-dep
22c8f50
@polina-c
-
4ead687
@polina-c
Update update_packages_test.dart
410387b
@polina-c
-
7d62581
@polina-c
-
49333c8
@polina-c
Update widget_tester.dart
b2a735f
@polina-c
-
d4ade8d
@polina-c
Update widget_tester.dart
e5f77f9
@polina-c
Merge branch 'master' of https://github.com/flutter/flutter into add-…
0e55d23 
…dep-1
@polina-c
Merge branch 'upgrade-lt-2' into add-dep-1
34cc5f1
@polina-c
Merge branch 'add-dep-1' into add-param-3
20448b3
@polina-c
Update widget_tester.dart
3329aa1
@polina-c
Update widget_tester.dart
1a373ed
@polina-c
Update widget_tester.dart
9968d20
@polina-c
-
f2432f5
@polina-c
-
98f71f7
@polina-c
Update widget_tester.dart
9a10f23
@polina-c
Update widget_tester.dart
f7b055d
@polina-c
-
d88df19
@polina-c
Update widget_tester_test.dart
4f1c3ec
@polina-c
Merge branch 'master' of https://github.com/flutter/flutter into add-…
98f2397 
…param-3
@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 3, 2024
@polina-c polina-c changed the title Reland Reland https://github.com/flutter/flutter/pull/140521 Jan 3, 2024
@polina-c
Copy link
Contributor Author

polina-c commented Jan 3, 2024

Linux_android flutter_test_performance and cla/google passed.

Disabling the test.

@polina-c polina-c marked this pull request as ready for review January 3, 2024 23:55
@polina-c polina-c requested a review from zanderso January 4, 2024 00:20
@zanderso zanderso requested review from goderbauer and kenzieschmoll and removed request for zanderso January 4, 2024 16:14
@zanderso
Copy link
Member

zanderso commented Jan 4, 2024

Re-routing to the original reviewers.

@goderbauer goderbauer changed the title Reland https://github.com/flutter/flutter/pull/140521 Reland "integrate testWidgets with leak tracking" (#140521) Jan 4, 2024
@goderbauer
Copy link
Member

Is there a specific commit that contains what's different to the previous PR?

@polina-c
Copy link
Contributor Author

polina-c commented Jan 4, 2024

Is there a specific commit that contains what's different to the previous PR?

@goderbauer, the key change is in the added !_shouldConfigureTearDownForTestFile() in this block:

void _maybeConfigureTearDownForTestFile() {
  if (_isTearDownForTestFileConfigured || !_shouldConfigureTearDownForTestFile()) {
    return;
  }

All other changes are renamings aimed to improve readability with this added condition.

Does it help?

@goderbauer
Copy link
Member

For next time: If you isolate the changes over the original PR in a specific set of commits relands are a lot faster and easier to review.

goderbauer
goderbauer approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit 3ed0399 into flutter:master Jan 4, 2024
66 checks passed
@polina-c polina-c deleted the implement-4 branch January 4, 2024 18:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
3ed039966 Reland "integrate testWidgets with leak tracking" (#140521) (…
fe2d3ac 
…flutter/flutter#140928)
tarrinneal added a commit to flutter/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll @tarrinneal
Manual roll Flutter from 11def8eff455 to cc40425ddcef (118 revisions) (…
b9b6d38 
…#5806)

Manual roll Flutter from 11def8eff455 to cc40425ddcef (118 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@11def8e...cc40425

2024-01-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0bbb4d61ce82 to f60d9a9a3395 (1 revision) (flutter/flutter#140993)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (flutter/flutter#140990)
2024-01-04 yjbanov@google.com [web] Fix and unskip a few more CanvasKit
tests (flutter/flutter#140821)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bd175aa5e0b6 to b2a9ce88a19e (1 revision) (flutter/flutter#140986)
2024-01-04 danny@tuppeny.com Pin package:vm_service
(flutter/flutter#140972)
2024-01-04 36861262+QuncCccccc@users.noreply.github.com Add scrollbar
for menus (flutter/flutter#140941)
2024-01-04 christopherfujino@gmail.com manual pub roll to pick up dds
fixes (flutter/flutter#140979)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b81023eb71c9 to bd175aa5e0b6 (2 revisions) (flutter/flutter#140980)
2024-01-04 polinach@google.com Temporarily remove env variable for leak
tracking bots. (flutter/flutter#140978)
2024-01-04 chillers@google.com Add Flutter CI status to README
(flutter/flutter#140513)
2024-01-04 polinach@google.com Reland "integrate testWidgets with leak
tracking" (#140521) (flutter/flutter#140928)
2024-01-04 15619084+vashworth@users.noreply.github.com Run half of iOS
devicelab tests with Xcode 15 (flutter/flutter#140927)
2024-01-04 39755477+sharabiddin@users.noreply.github.com Fix
`SegmentedButton` states update logic (flutter/flutter#140772)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f539acfb8c5a to b81023eb71c9 (1 revision) (flutter/flutter#140973)
2024-01-04 pateltirth454@gmail.com [Fix] Consistency in
ButtonStyleButton related Tests (flutter/flutter#140610)
2024-01-04 engine-flutter-autoroll@skia.org Roll Packages from
bbb4134 to 31fc7b5 (6 revisions) (flutter/flutter#140967)
2024-01-04 stuartmorgan@google.com Fix local engine use in macOS plugins
(flutter/flutter#140222)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7d5a120a601b to f539acfb8c5a (2 revisions) (flutter/flutter#140959)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1ff3cb885842 to 7d5a120a601b (1 revision) (flutter/flutter#140946)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c8bf51f0d4cd to 1ff3cb885842 (1 revision) (flutter/flutter#140943)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bfd2d8a100ec to c8bf51f0d4cd (2 revisions) (flutter/flutter#140939)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
28ae9e35c331 to bfd2d8a100ec (1 revision) (flutter/flutter#140937)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
ab4098c742f8 to 28ae9e35c331 (1 revision) (flutter/flutter#140936)
2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e169f3677008 to ab4098c742f8 (2 revisions) (flutter/flutter#140933)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7c2adb811059 to e169f3677008 (1 revision) (flutter/flutter#140929)
2024-01-03 magder@google.com Remove deprecated bitcode stripping from
tooling (flutter/flutter#140903)
2024-01-03 54558023+keyonghan@users.noreply.github.com Add Windows leak
tracking targets (flutter/flutter#140423)
2024-01-03 xilaizhang@google.com [github actions] refactor and fix
cherry pick actions (flutter/flutter#140499)
2024-01-03 magder@google.com Migrate Xcode projects last version checks
to Xcode 15.1 (flutter/flutter#140256)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bf232c4da241 to 7c2adb811059 (3 revisions) (flutter/flutter#140920)
2024-01-03 goderbauer@google.com fix typo and reflow
(flutter/flutter#140925)
2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Re-land integrate testWidgets with leak tracking."
(flutter/flutter#140926)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bf979d220283 to bf232c4da241 (1 revision) (flutter/flutter#140915)
2024-01-03 ybz975218925@gmail.com Changes the regular cursor to a
floating cursor when a long press occurs. (flutter/flutter#138479)
2024-01-03 65075121+AcarFurkan@users.noreply.github.com Add
`SegmentedButton.styleFrom` (flutter/flutter#137542)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c62bcff5b809 to bf979d220283 (1 revision) (flutter/flutter#140910)
2024-01-03 polinach@google.com Re-land integrate testWidgets with leak
tracking. (flutter/flutter#140521)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
98b72c7ffe71 to c62bcff5b809 (2 revisions) (flutter/flutter#140905)
2024-01-03 jonahwilliams@google.com [flutter_tools] add support for
--enable-impeller to test device. (flutter/flutter#140899)
2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cf7536964a2f to 98b72c7ffe71 (1 revision) (flutter/flutter#140897)
2024-01-03 233583+mossmana@users.noreply.github.com Handle
KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutter#140808)
2024-01-03 lsaudon@gmail.com Add Lucas Saudon to AUTHORS
(flutter/flutter#139965)
2024-01-03 21270878+elliette@users.noreply.github.com Link to wiki page
about updating dependencies in each `pubspec.yaml` file
(flutter/flutter#140826)
2024-01-03 fluttergithubbot@gmail.com Marks Linux_pixel_7pro
native_assets_android to be unflaky (flutter/flutter#140866)
...

---------

Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this pull request Jan 6, 2024
@polina-c @victoreronmosele
Reland "integrate testWidgets with leak tracking" (flutter#140521) (f…
a557940 
…lutter#140928)
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
@polina-c @Michal-MK
Reland "integrate testWidgets with leak tracking" (flutter#140521) (f…
216e325 
…lutter#140928)
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
@polina-c @Markzipan
Reland "integrate testWidgets with leak tracking" (flutter#140521) (f…
e8e894b 
…lutter#140928)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
3ed039966 Reland "integrate testWidgets with leak tracking" (#140521) (…
9dd7a53 
…flutter/flutter#140928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@polina-c @zanderso @goderbauer @kenzieschmoll