Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable to leak tracking bots. #141137

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Add environment variable to leak tracking bots. #141137

merged 9 commits into from
Jan 9, 2024

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Jan 8, 2024

For now the variable is noop. If we see the mechanism works and jobs are still green, we will replace the variable with "LEAK_TRACKING".

keyonghan
keyonghan reviewed Jan 8, 2024
View reviewed changes
.ci.yaml Outdated Show resolved Hide resolved
keyonghan
keyonghan approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jan 8, 2024

auto label is removed for flutter/flutter/141137, due to - The status or check suite Mac_arm64 flutter_packaging_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux flutter_packaging_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jan 8, 2024

auto label is removed for flutter/flutter/141137, due to - The status or check suite Mac_arm64 flutter_packaging_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac flutter_packaging_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c
Copy link
Contributor Author

polina-c commented Jan 8, 2024

Tests fail: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8759425628872424337/+/u/prepare_and_create_a_flutter_archive/stdout?format=raw

Replacing with NO_OP to verify it is not leak tracker related.

@polina-c
Copy link
Contributor Author

polina-c commented Jan 9, 2024 •
edited
Loading

After replacement tests are still failing. Failure details:

Running "git clone -b master https://flutter.googlesource.com/mirrors/flutter" in /b/s/w/ir/x/w/archive.
Cloning into 'flutter'...
Running "git reset --hard 7174b02f51f4caac267122b932897ed6c8d5a9b8" in /b/s/w/ir/x/w/archive/flutter.
fatal: Could not parse object '7174b02f51f4caac267122b932897ed6c8d5a9b8'.
Error: Running "git reset --hard 7174b02f51f4caac267122b932897ed6c8d5a9b8" in 
/b/s/w/ir/x/w/archive/flutter failed

@jmagman jmagman mentioned this pull request Jan 9, 2024
Closed
@polina-c
Copy link
Contributor Author

polina-c commented Jan 9, 2024

Blocked by #141188

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2024
@polina-c polina-c merged commit 988d1a0 into flutter:master Jan 9, 2024
136 checks passed
@polina-c polina-c deleted the env-var branch January 9, 2024 22:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2024
@engine-flutter-autoroll
988d1a067 Add environment variable to leak tracking bots. (flutter/fl…
64359fb 
…utter#141137)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 10, 2024
@engine-flutter-autoroll
Roll Flutter from 126302dfb44c to b840a60d7d3f (29 revisions) (#5855)
347929f 
flutter/flutter@126302d...b840a60

2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3269fd84460d to b361a60ae224 (1 revision) (flutter/flutter#141271)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a5d446da5495 to 3269fd84460d (1 revision) (flutter/flutter#141264)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3ccf66bed335 to a5d446da5495 (2 revisions) (flutter/flutter#141252)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57e418c02ae to 3ccf66bed335 (1 revision) (flutter/flutter#141241)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e6f3d847e01 to e57e418c02ae (1 revision) (flutter/flutter#141240)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1cf2e0a603c7 to 7e6f3d847e01 (1 revision) (flutter/flutter#141237)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 32bbf8be8d2c to 1cf2e0a603c7 (1 revision) (flutter/flutter#141232)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b9d2132b7cd to 32bbf8be8d2c (1 revision) (flutter/flutter#141229)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 941f268fc8bb to 5b9d2132b7cd (1 revision) (flutter/flutter#141228)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 542fea9edae4 to 941f268fc8bb (3 revisions) (flutter/flutter#141224)
2024-01-10 Michal-MK@users.noreply.github.com `NestedScrollView`'s outer scrollable jumping with `BouncingScrollPhysics` due to `double` precision errors (flutter/flutter#138319)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8c1501f3956d to 542fea9edae4 (1 revision) (flutter/flutter#141217)
2024-01-10 polinach@google.com Fix or except leaks. (flutter/flutter#141081)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 693af0c699c5 to 8c1501f3956d (1 revision) (flutter/flutter#141215)
2024-01-09 cbobbe@zulip.com TextStyle: In copyWith, stop ignoring debugLabel when receiver has none (flutter/flutter#141141)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from a35e3b026e1d to 693af0c699c5 (5 revisions) (flutter/flutter#141209)
2024-01-09 stuartmorgan@google.com Replace deprecated `exists` in podhelper.rb (flutter/flutter#141169)
2024-01-09 kevmoo@users.noreply.github.com Correctly handle null case in ProcessText.queryTextActions (flutter/flutter#141205)
2024-01-09 polinach@google.com Add environment variable to leak tracking bots. (flutter/flutter#141137)
2024-01-09 goderbauer@google.com Reapply "Dynamic view sizing" (#140165) (flutter/flutter#140918)
2024-01-09 89970141+SharbelOkzan@users.noreply.github.com Introduce new Form validation method  (flutter/flutter#135578)
2024-01-09 tessertaha@gmail.com Update `RouteObserver` example and fix an error thrown (flutter/flutter#141166)
2024-01-09 polinach@google.com Upgrade leak_tracker. (flutter/flutter#141153)
2024-01-09 chillers@google.com [ci.yaml] Do not run packaging test on presubmit (flutter/flutter#141192)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 036b39fa47fa to a35e3b026e1d (6 revisions) (flutter/flutter#141191)
2024-01-09 15619084+vashworth@users.noreply.github.com Run tests on iOS 16 or iOS 17 (flutter/flutter#141178)
2024-01-09 polinach@google.com Remove conditions that depend on order. (flutter/flutter#141183)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3c8597df0e2 to 036b39fa47fa (1 revision) (flutter/flutter#141179)
2024-01-09 148634283+nikkivirtuoso@users.noreply.github.com resolved the issue of indeterminate CircularProgressIndicator.adaptive on Darwin  (flutter/flutter#140947)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 126302dfb44c to b840a60d7d3f (29 revisions) (flutte…
9effc6f 
…r#5855)

flutter/flutter@126302d...b840a60

2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3269fd84460d to b361a60ae224 (1 revision) (flutter/flutter#141271)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a5d446da5495 to 3269fd84460d (1 revision) (flutter/flutter#141264)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3ccf66bed335 to a5d446da5495 (2 revisions) (flutter/flutter#141252)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57e418c02ae to 3ccf66bed335 (1 revision) (flutter/flutter#141241)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e6f3d847e01 to e57e418c02ae (1 revision) (flutter/flutter#141240)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1cf2e0a603c7 to 7e6f3d847e01 (1 revision) (flutter/flutter#141237)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 32bbf8be8d2c to 1cf2e0a603c7 (1 revision) (flutter/flutter#141232)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b9d2132b7cd to 32bbf8be8d2c (1 revision) (flutter/flutter#141229)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 941f268fc8bb to 5b9d2132b7cd (1 revision) (flutter/flutter#141228)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 542fea9edae4 to 941f268fc8bb (3 revisions) (flutter/flutter#141224)
2024-01-10 Michal-MK@users.noreply.github.com `NestedScrollView`'s outer scrollable jumping with `BouncingScrollPhysics` due to `double` precision errors (flutter/flutter#138319)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8c1501f3956d to 542fea9edae4 (1 revision) (flutter/flutter#141217)
2024-01-10 polinach@google.com Fix or except leaks. (flutter/flutter#141081)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 693af0c699c5 to 8c1501f3956d (1 revision) (flutter/flutter#141215)
2024-01-09 cbobbe@zulip.com TextStyle: In copyWith, stop ignoring debugLabel when receiver has none (flutter/flutter#141141)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from a35e3b026e1d to 693af0c699c5 (5 revisions) (flutter/flutter#141209)
2024-01-09 stuartmorgan@google.com Replace deprecated `exists` in podhelper.rb (flutter/flutter#141169)
2024-01-09 kevmoo@users.noreply.github.com Correctly handle null case in ProcessText.queryTextActions (flutter/flutter#141205)
2024-01-09 polinach@google.com Add environment variable to leak tracking bots. (flutter/flutter#141137)
2024-01-09 goderbauer@google.com Reapply "Dynamic view sizing" (#140165) (flutter/flutter#140918)
2024-01-09 89970141+SharbelOkzan@users.noreply.github.com Introduce new Form validation method  (flutter/flutter#135578)
2024-01-09 tessertaha@gmail.com Update `RouteObserver` example and fix an error thrown (flutter/flutter#141166)
2024-01-09 polinach@google.com Upgrade leak_tracker. (flutter/flutter#141153)
2024-01-09 chillers@google.com [ci.yaml] Do not run packaging test on presubmit (flutter/flutter#141192)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 036b39fa47fa to a35e3b026e1d (6 revisions) (flutter/flutter#141191)
2024-01-09 15619084+vashworth@users.noreply.github.com Run tests on iOS 16 or iOS 17 (flutter/flutter#141178)
2024-01-09 polinach@google.com Remove conditions that depend on order. (flutter/flutter#141183)
2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3c8597df0e2 to 036b39fa47fa (1 revision) (flutter/flutter#141179)
2024-01-09 148634283+nikkivirtuoso@users.noreply.github.com resolved the issue of indeterminate CircularProgressIndicator.adaptive on Darwin  (flutter/flutter#140947)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polina-c @keyonghan @godofredoc