-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private disposables should dispatch creation and disposal events. #141535
Private disposables should dispatch creation and disposal events. #141535
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Test exemption request: https://discord.com/channels/608014603317936148/608018585025118217/1196191547285323907 |
cc @polina-c |
Tests are added to memory allocations testing. |
@polina-c thanks for the review! |
@polina-c please do not land PRs that do not have test exemptions, see https://github.com/flutter/flutter/wiki/Tree-hygiene#tests |
@Hixie , I thought this PR does not need test exemption any more since the tests were updated in this PR after auto alert was generated: #141535 (comment) Am i wrong? |
Oh, so they were, my apologies. |
flutter/flutter@1a2c315...8e94423 2024-01-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "BoxPainter should dispatch creation and disposal events." (flutter/flutter#141545) 2024-01-14 sokolovskyi.konstantin@gmail.com Private disposables should dispatch creation and disposal events. (flutter/flutter#141535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#5897) flutter/flutter@1a2c315...8e94423 2024-01-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "BoxPainter should dispatch creation and disposal events." (flutter/flutter#141545) 2024-01-14 sokolovskyi.konstantin@gmail.com Private disposables should dispatch creation and disposal events. (flutter/flutter#141535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR contributes to #141198
Description
_HeroFlight
leak inHeroController
_AnimationTuple
creation and disposal events dispatching for memory leak tracking_IndicatorPainter
creation and disposal events dispatching for memory leak tracking_DialPainter
creation and disposal events dispatching for memory leak tracking_DecorationImagePainter
creation and disposal events dispatching for memory leak tracking_BlendedDecorationImagePainter
creation and disposal events dispatching for memory leak tracking_CachedImageBase
creation and disposal events dispatching for memory leak tracking_BindingPipelineManifold
creation and disposal events dispatching for memory leak tracking_DraggableSheetExtent
creation and disposal events dispatching for memory leak tracking_HighlightModeManager
creation and disposal events dispatching for memory leak tracking_HeroFlight
creation and disposal events dispatching for memory leak tracking_NestedScrollCoordinator
creation and disposal events dispatching for memory leak tracking_GlowController
creation and disposal events dispatching for memory leak tracking_StretchController
creation and disposal events dispatching for memory leak tracking_DragInfo
creation and disposal events dispatching for memory leak tracking_SemanticsClient
creation and disposal events dispatching for memory leak tracking_ScreenshotData
creation and disposal events dispatching for memory leak trackingPre-launch Checklist
///
).