Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tooltip show delay when mouse moves to one Tooltip from another #141656

Merged
merged 3 commits into from Jan 17, 2024

Conversation

LongCatIsLooong
Copy link
Contributor

Fixes #141644

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 17, 2024
@LongCatIsLooong LongCatIsLooong changed the title Fix Tooltip show delay when mouse moves from one Tooltip from another Fix Tooltip show delay when mouse moves to one Tooltip from another Jan 17, 2024
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks!

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2024
Copy link
Contributor

auto-submit bot commented Jan 17, 2024

auto label is removed for flutter/flutter/141656, due to - The status or check suite Mac_build_test flutter_gallery__transition_perf_e2e_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2024
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2024
@auto-submit auto-submit bot merged commit da20edf into flutter:master Jan 17, 2024
67 checks passed
@LongCatIsLooong LongCatIsLooong deleted the tooltip-hover-fix branch January 17, 2024 17:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 18, 2024
flutter/flutter@def6af0...f77f824

2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (flutter/flutter#141771)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (flutter/flutter#141762)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (flutter/flutter#141760)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (flutter/flutter#141759)
2024-01-18 andrewrkolos@gmail.com Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (flutter/flutter#141214)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (flutter/flutter#141752)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (flutter/flutter#141751)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (flutter/flutter#141749)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (flutter/flutter#141744)
2024-01-18 zanderso@users.noreply.github.com Move mac pixel 7 pro test to presubmit: false (flutter/flutter#141747)
2024-01-18 yjbanov@google.com [web] prepare layers_test.dart for flutter/engine#49786 (flutter/flutter#141731)
2024-01-17 polinach@google.com Remove non-needed bot and increase time out for leak_tracking. (flutter/flutter#141712)
2024-01-17 36861262+QuncCccccc@users.noreply.github.com Add `headerHeight` for `SearchAnchor` (flutter/flutter#141223)
2024-01-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/flutter#141715)
2024-01-17 andrewrkolos@gmail.com Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (flutter/flutter#141657)
2024-01-17 dacoharkes@google.com Native assets: roll deps (flutter/flutter#141684)
2024-01-17 godofredoc@google.com Run build tests on both x64 and arm64. (flutter/flutter#141206)
2024-01-17 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 (flutter/flutter#141706)
2024-01-17 yjbanov@google.com [web] prepare for flutter/engine#49786 (flutter/flutter#141700)
2024-01-17 fluttergithubbot@gmail.com Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#141676)
2024-01-17 goderbauer@google.com Label "flutter_localizations" PRs with "framework" (flutter/flutter#141654)
2024-01-17 31859944+LongCatIsLooong@users.noreply.github.com Fix Tooltip show delay when mouse moves to one Tooltip from another (flutter/flutter#141656)
2024-01-17 engine-flutter-autoroll@skia.org Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (flutter/flutter#141683)
2024-01-17 gspencergoog@users.noreply.github.com Fix the --empty flag to not try working with non-app templates (flutter/flutter#141632)
2024-01-17 jonahwilliams@google.com Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (flutter/flutter#141691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Material ToolTip non-zero hover delay
2 participants