[web] fix ==/hashCode/toString for several classes across renderers #49786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
changed the title
yjbanov
added a commit
to yjbanov/flutter
that referenced
this pull request
Jan 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2024
Skip incorrect expectations in preparation for flutter/engine#49786. Bonus: improved error message when text style test fails
yjbanov
force-pushed
the
cktextstyle-equals2
branch
from
456656c
to
89eb69a
Compare
yjbanov
added a commit
to yjbanov/flutter
that referenced
this pull request
Jan 17, 2024
yjbanov
added a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
This disables the expectation for `TileMode` stringification because flutter/engine#49786 is about to fix it (as in, the test would fail when the engine fix lands).
yjbanov
force-pushed
the
cktextstyle-equals2
branch
from
89eb69a
to
f862454
Compare
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
…141749) flutter/engine@98c16b4...924c172 2024-01-18 yjbanov@google.com [web] fix ==/hashCode/toString for several classes across renderers (flutter/engine#49786) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 18, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 18, 2024
flutter/flutter@def6af0...f77f824 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (flutter/flutter#141771) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (flutter/flutter#141762) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (flutter/flutter#141760) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (flutter/flutter#141759) 2024-01-18 andrewrkolos@gmail.com Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (flutter/flutter#141214) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (flutter/flutter#141752) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (flutter/flutter#141751) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (flutter/flutter#141749) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (flutter/flutter#141744) 2024-01-18 zanderso@users.noreply.github.com Move mac pixel 7 pro test to presubmit: false (flutter/flutter#141747) 2024-01-18 yjbanov@google.com [web] prepare layers_test.dart for flutter/engine#49786 (flutter/flutter#141731) 2024-01-17 polinach@google.com Remove non-needed bot and increase time out for leak_tracking. (flutter/flutter#141712) 2024-01-17 36861262+QuncCccccc@users.noreply.github.com Add `headerHeight` for `SearchAnchor` (flutter/flutter#141223) 2024-01-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/flutter#141715) 2024-01-17 andrewrkolos@gmail.com Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (flutter/flutter#141657) 2024-01-17 dacoharkes@google.com Native assets: roll deps (flutter/flutter#141684) 2024-01-17 godofredoc@google.com Run build tests on both x64 and arm64. (flutter/flutter#141206) 2024-01-17 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 (flutter/flutter#141706) 2024-01-17 yjbanov@google.com [web] prepare for flutter/engine#49786 (flutter/flutter#141700) 2024-01-17 fluttergithubbot@gmail.com Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#141676) 2024-01-17 goderbauer@google.com Label "flutter_localizations" PRs with "framework" (flutter/flutter#141654) 2024-01-17 31859944+LongCatIsLooong@users.noreply.github.com Fix Tooltip show delay when mouse moves to one Tooltip from another (flutter/flutter#141656) 2024-01-17 engine-flutter-autoroll@skia.org Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (flutter/flutter#141683) 2024-01-17 gspencergoog@users.noreply.github.com Fix the --empty flag to not try working with non-app templates (flutter/flutter#141632) 2024-01-17 jonahwilliams@google.com Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (flutter/flutter#141691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
- Unskip `text_style_test` for CanvasKit. - Remove no longer necessary `kIsWeb` checks in a few tests. This PR depends on flutter/engine#49786, which rolled into the framework. If the engine PR needs to be reverted, this PR will need to be reverted too.
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…r#5924) flutter/flutter@def6af0...f77f824 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (flutter/flutter#141771) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (flutter/flutter#141762) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (flutter/flutter#141760) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (flutter/flutter#141759) 2024-01-18 andrewrkolos@gmail.com Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (flutter/flutter#141214) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (flutter/flutter#141752) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (flutter/flutter#141751) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (flutter/flutter#141749) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (flutter/flutter#141744) 2024-01-18 zanderso@users.noreply.github.com Move mac pixel 7 pro test to presubmit: false (flutter/flutter#141747) 2024-01-18 yjbanov@google.com [web] prepare layers_test.dart for flutter/engine#49786 (flutter/flutter#141731) 2024-01-17 polinach@google.com Remove non-needed bot and increase time out for leak_tracking. (flutter/flutter#141712) 2024-01-17 36861262+QuncCccccc@users.noreply.github.com Add `headerHeight` for `SearchAnchor` (flutter/flutter#141223) 2024-01-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/flutter#141715) 2024-01-17 andrewrkolos@gmail.com Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (flutter/flutter#141657) 2024-01-17 dacoharkes@google.com Native assets: roll deps (flutter/flutter#141684) 2024-01-17 godofredoc@google.com Run build tests on both x64 and arm64. (flutter/flutter#141206) 2024-01-17 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 (flutter/flutter#141706) 2024-01-17 yjbanov@google.com [web] prepare for flutter/engine#49786 (flutter/flutter#141700) 2024-01-17 fluttergithubbot@gmail.com Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#141676) 2024-01-17 goderbauer@google.com Label "flutter_localizations" PRs with "framework" (flutter/flutter#141654) 2024-01-17 31859944+LongCatIsLooong@users.noreply.github.com Fix Tooltip show delay when mouse moves to one Tooltip from another (flutter/flutter#141656) 2024-01-17 engine-flutter-autoroll@skia.org Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (flutter/flutter#141683) 2024-01-17 gspencergoog@users.noreply.github.com Fix the --empty flag to not try working with non-app templates (flutter/flutter#141632) 2024-01-17 jonahwilliams@google.com Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (flutter/flutter#141691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix equality and hash code in
ParagraphStyleandStrutStyleacross renderers. Since those classes transitively rely onPaintand other classes, also fix those at least to a point that they pass thetest/painting/text_style_test.darttest on the framework side.