Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts "hello_world app: migrate to Gradle Kotlin DSL" #142018

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Reverts "hello_world app: migrate to Gradle Kotlin DSL" #142018

merged 1 commit into from
Jan 23, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Jan 23, 2024

Reverts #141541
Initiated by: yusuf-goog
This change reverts the following previous change:
Original Description:
This PR introduces the first app in this repo that fully uses Gradle Kotlin DSL.

It also fixes a bug I found in the process – fields of FlutterExtensions must be public.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 23, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. d: examples Sample code and demos labels Jan 23, 2024
@auto-submit auto-submit bot merged commit b258ca0 into master Jan 23, 2024
6 of 8 checks passed
@auto-submit auto-submit bot deleted the revert_e593cdfb80975fb6a41dff21e3f4f774f7e68723 branch January 23, 2024 00:01
@yusuf-goog yusuf-goog requested review from godofredoc and keyonghan and removed request for godofredoc and keyonghan January 23, 2024 00:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
b258ca011 Reverts "hello_world app: migrate to Gradle Kotlin DSL" (fl…
91ab9c0 
…utter/flutter#142018)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
b258ca011 Reverts "hello_world app: migrate to Gradle Kotlin DSL" (fl…
dc73977 
…utter/flutter#142018)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
b258ca011 Reverts "hello_world app: migrate to Gradle Kotlin DSL" (fl…
31855f3 
…utter/flutter#142018)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
b258ca011 Reverts "hello_world app: migrate to Gradle Kotlin DSL" (fl…
925fd95 
…utter/flutter#142018)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
Roll Flutter from 3ee8ff287a6e to 5b673c28e4ac (28 revisions) (#5965)
f858453 
flutter/flutter@3ee8ff2...5b673c2

2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from fd0335a910b8 to b229878c57f5 (1 revision) (flutter/flutter#142051)
2024-01-23 goderbauer@google.com Remove unused clipBehavior from OverflowBar (flutter/flutter#141976)
2024-01-23 engine-flutter-autoroll@skia.org Roll Packages from e4cbf23 to 841fe90 (7 revisions) (flutter/flutter#142047)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2855da628da to fd0335a910b8 (1 revision) (flutter/flutter#142046)
2024-01-23 leroux_bruno@yahoo.fr Add Share button to the SelectableRegion toolbar on Android (flutter/flutter#141447)
2024-01-23 davidmartos96@gmail.com Relax the warning of unavailable tokens in `gen_defaults` when a default value is provided (flutter/flutter#140872)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 37f68f6fc7fc to d2855da628da (1 revision) (flutter/flutter#142033)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e582c9032e5 to 37f68f6fc7fc (1 revision) (flutter/flutter#142027)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from df6b15d35703 to 9e582c9032e5 (1 revision) (flutter/flutter#142026)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from d3dbd4225e08 to df6b15d35703 (6 revisions) (flutter/flutter#142023)
2024-01-23 ian@hixie.ch Add a comment about how to test flutter_goldens (flutter/flutter#141902)
2024-01-23 ian@hixie.ch Enable contextMenuBuilder in the absence of selectionControls (flutter/flutter#141810)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b069d7f8f1fd to d3dbd4225e08 (3 revisions) (flutter/flutter#142005)
2024-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "hello_world app: migrate to Gradle Kotlin DSL" (flutter/flutter#142018)
2024-01-22 jmccandless@google.com Floating cursor docs (flutter/flutter#133002)
2024-01-22 git@reb0.org refactor: Rename filterPluginsByPlatform, cleanup Platform Strings (flutter/flutter#141780)
2024-01-22 barpac02@gmail.com hello_world app: migrate to Gradle Kotlin DSL (flutter/flutter#141541)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2762f410840 to b069d7f8f1fd (4 revisions) (flutter/flutter#141993)
2024-01-22 matanlurey@users.noreply.github.com Remove duplicate code as suggested by natebosch. (flutter/flutter#141988)
2024-01-22 jesus_sguerrero@hotmail.com Revert "Remove hack from PageView." (flutter/flutter#141977)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from d653559ae183 to b2762f410840 (3 revisions) (flutter/flutter#141978)
2024-01-22 matanlurey@users.noreply.github.com Do not hang on test failures of tests within `flutter_tools` (flutter/flutter#141821)
2024-01-22 gspencergoog@users.noreply.github.com Remove unneeded expectation in test (flutter/flutter#141822)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1efe8ba6bc04 to d653559ae183 (3 revisions) (flutter/flutter#141972)
2024-01-22 ueman@users.noreply.github.com Add documentation which explains that `debugPrint` also logs in release mode (flutter/flutter#141595)
2024-01-22 tessertaha@gmail.com Fix `RangeSlider` throws a null-check error after `clearSemantics` is called (flutter/flutter#141965)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c49989292fc1 to 1efe8ba6bc04 (1 revision) (flutter/flutter#141969)
2024-01-22 110993981+htoor3@users.noreply.github.com [web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator` (flutter/flutter#138446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 23, 2024
Merged
@bartekpacia bartekpacia mentioned this pull request Jan 26, 2024
Closed
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 3ee8ff287a6e to 5b673c28e4ac (28 revisions) (flutte…
308205e 
…r#5965)

flutter/flutter@3ee8ff2...5b673c2

2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from fd0335a910b8 to b229878c57f5 (1 revision) (flutter/flutter#142051)
2024-01-23 goderbauer@google.com Remove unused clipBehavior from OverflowBar (flutter/flutter#141976)
2024-01-23 engine-flutter-autoroll@skia.org Roll Packages from e4cbf23 to 841fe90 (7 revisions) (flutter/flutter#142047)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2855da628da to fd0335a910b8 (1 revision) (flutter/flutter#142046)
2024-01-23 leroux_bruno@yahoo.fr Add Share button to the SelectableRegion toolbar on Android (flutter/flutter#141447)
2024-01-23 davidmartos96@gmail.com Relax the warning of unavailable tokens in `gen_defaults` when a default value is provided (flutter/flutter#140872)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 37f68f6fc7fc to d2855da628da (1 revision) (flutter/flutter#142033)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e582c9032e5 to 37f68f6fc7fc (1 revision) (flutter/flutter#142027)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from df6b15d35703 to 9e582c9032e5 (1 revision) (flutter/flutter#142026)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from d3dbd4225e08 to df6b15d35703 (6 revisions) (flutter/flutter#142023)
2024-01-23 ian@hixie.ch Add a comment about how to test flutter_goldens (flutter/flutter#141902)
2024-01-23 ian@hixie.ch Enable contextMenuBuilder in the absence of selectionControls (flutter/flutter#141810)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b069d7f8f1fd to d3dbd4225e08 (3 revisions) (flutter/flutter#142005)
2024-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "hello_world app: migrate to Gradle Kotlin DSL" (flutter/flutter#142018)
2024-01-22 jmccandless@google.com Floating cursor docs (flutter/flutter#133002)
2024-01-22 git@reb0.org refactor: Rename filterPluginsByPlatform, cleanup Platform Strings (flutter/flutter#141780)
2024-01-22 barpac02@gmail.com hello_world app: migrate to Gradle Kotlin DSL (flutter/flutter#141541)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2762f410840 to b069d7f8f1fd (4 revisions) (flutter/flutter#141993)
2024-01-22 matanlurey@users.noreply.github.com Remove duplicate code as suggested by natebosch. (flutter/flutter#141988)
2024-01-22 jesus_sguerrero@hotmail.com Revert "Remove hack from PageView." (flutter/flutter#141977)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from d653559ae183 to b2762f410840 (3 revisions) (flutter/flutter#141978)
2024-01-22 matanlurey@users.noreply.github.com Do not hang on test failures of tests within `flutter_tools` (flutter/flutter#141821)
2024-01-22 gspencergoog@users.noreply.github.com Remove unneeded expectation in test (flutter/flutter#141822)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1efe8ba6bc04 to d653559ae183 (3 revisions) (flutter/flutter#141972)
2024-01-22 ueman@users.noreply.github.com Add documentation which explains that `debugPrint` also logs in release mode (flutter/flutter#141595)
2024-01-22 tessertaha@gmail.com Fix `RangeSlider` throws a null-check error after `clearSemantics` is called (flutter/flutter#141965)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c49989292fc1 to 1efe8ba6bc04 (1 revision) (flutter/flutter#141969)
2024-01-22 110993981+htoor3@users.noreply.github.com [web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator` (flutter/flutter#138446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

@bartekpacia bartekpacia Awaiting requested review from bartekpacia

Assignees

@yusuf-goog yusuf-goog

Labels
d: examples Sample code and demos revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fluttergithubbot @yusuf-goog