-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect zh-cn translation for Look Up Label in selection controls #142158
Fix incorrect zh-cn translation for Look Up Label in selection controls #142158
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This change will eventually be overwritten by Google's translation service; hopefully there will be no effective change when that happens.
@@ -24,7 +24,7 @@ | |||
"searchTextFieldPlaceholderLabel": "搜索", | |||
"noSpellCheckReplacementsLabel": "找不到替换文字", | |||
"menuDismissLabel": "关闭菜单", | |||
"lookUpButtonLabel": "向上看", | |||
"lookUpButtonLabel": "查询", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a separate localization for traditional chinese?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have zh_TW
and zh_HK
. Actually I think these ones already got it right somehow:
Locale | lookupButtonLabel | ||
---|---|---|---|
en |
|
||
zh_TW |
|
||
zh_HK |
|
auto label is removed for flutter/flutter/142158, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
final MaterialLocalizations localizations = await GlobalMaterialLocalizations.delegate.load(locale); | ||
expect(localizations, isA<MaterialLocalizationZh>()); | ||
expect(localizations.lookUpButtonLabel, '查询'); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Is it actually useful to add tests like this? If we've done it before then no worries, just checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added it just cuz the translations havent been approved yet, so small chance this change might get overwritten by the translation tool. i definitely also just copied this test because there were other tests in this file that do the same thing 😅
@@ -24,7 +24,7 @@ | |||
"searchTextFieldPlaceholderLabel": "搜索", | |||
"noSpellCheckReplacementsLabel": "找不到替换文字", | |||
"menuDismissLabel": "关闭菜单", | |||
"lookUpButtonLabel": "向上看", | |||
"lookUpButtonLabel": "查询", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have zh_TW
and zh_HK
. Actually I think these ones already got it right somehow:
Locale | lookupButtonLabel | ||
---|---|---|---|
en |
|
||
zh_TW |
|
||
zh_HK |
|
…6008) Manual roll requested by stuartmorgan@google.com flutter/flutter@a8efa77...2f6fdf2 2024-01-26 matanlurey@users.noreply.github.com Start renaming by adding a new `bringup: true` as an Android emulator. (flutter/flutter#142257) 2024-01-26 polinach@google.com Instrument ImageInfo. (flutter/flutter#141411) 2024-01-26 36861262+QuncCccccc@users.noreply.github.com Fix `SegmentedButton` default size and default tappable size (flutter/flutter#142243) 2024-01-26 godofredoc@google.com Update name for android_defines_test. (flutter/flutter#142273) 2024-01-26 101587250+pbo-linaro@users.noreply.github.com Enable native compilation for windows-arm64 (flutter/flutter#141930) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions)" (flutter/flutter#142274) 2024-01-25 godofredoc@google.com Run a few mac tests only on arm. (flutter/flutter#142188) 2024-01-25 82763757+NobodyForNothing@users.noreply.github.com fix Ink not updating on TextField newline (flutter/flutter#140700) 2024-01-25 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.4 to 3.1.5 (flutter/flutter#142259) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions) (flutter/flutter#142264) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Rename `integration_tests/external_ui` but do not touch anything else..."" (flutter/flutter#142268) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename `integration_tests/external_ui` but do not touch anything else..." (flutter/flutter#142265) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2167a93c1a0 to 4b145d041560 (3 revisions) (flutter/flutter#142256) 2024-01-25 nathan.wilson1232@gmail.com Implementing `switch` expressions in the `cupertino/` directory (flutter/flutter#141591) 2024-01-25 matanlurey@users.noreply.github.com Rename `integration_tests/external_ui` but do not touch anything else... (flutter/flutter#142238) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55eefd5bd255 to b2167a93c1a0 (2 revisions) (flutter/flutter#142252) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b4779324b44 to 55eefd5bd255 (6 revisions) (flutter/flutter#142245) 2024-01-25 louisehsu@google.com Fix incorrect zh-cn translation for Look Up Label in selection controls (flutter/flutter#142158) 2024-01-25 jmccandless@google.com PopScope example improvements (flutter/flutter#142163) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d3f16b0d62e to 3b4779324b44 (1 revision) (flutter/flutter#142225) 2024-01-25 engine-flutter-autoroll@skia.org Roll Packages from 8fbdf65 to 21b5abb (6 revisions) (flutter/flutter#142224) 2024-01-25 sigurdm@google.com Don't show legacy welcome message when analytics are disabled (flutter/flutter#140956) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c4ed15cb271 to 1d3f16b0d62e (1 revision) (flutter/flutter#142223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#6008) Manual roll requested by stuartmorgan@google.com flutter/flutter@a8efa77...2f6fdf2 2024-01-26 matanlurey@users.noreply.github.com Start renaming by adding a new `bringup: true` as an Android emulator. (flutter/flutter#142257) 2024-01-26 polinach@google.com Instrument ImageInfo. (flutter/flutter#141411) 2024-01-26 36861262+QuncCccccc@users.noreply.github.com Fix `SegmentedButton` default size and default tappable size (flutter/flutter#142243) 2024-01-26 godofredoc@google.com Update name for android_defines_test. (flutter/flutter#142273) 2024-01-26 101587250+pbo-linaro@users.noreply.github.com Enable native compilation for windows-arm64 (flutter/flutter#141930) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions)" (flutter/flutter#142274) 2024-01-25 godofredoc@google.com Run a few mac tests only on arm. (flutter/flutter#142188) 2024-01-25 82763757+NobodyForNothing@users.noreply.github.com fix Ink not updating on TextField newline (flutter/flutter#140700) 2024-01-25 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.4 to 3.1.5 (flutter/flutter#142259) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions) (flutter/flutter#142264) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Rename `integration_tests/external_ui` but do not touch anything else..."" (flutter/flutter#142268) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename `integration_tests/external_ui` but do not touch anything else..." (flutter/flutter#142265) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2167a93c1a0 to 4b145d041560 (3 revisions) (flutter/flutter#142256) 2024-01-25 nathan.wilson1232@gmail.com Implementing `switch` expressions in the `cupertino/` directory (flutter/flutter#141591) 2024-01-25 matanlurey@users.noreply.github.com Rename `integration_tests/external_ui` but do not touch anything else... (flutter/flutter#142238) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55eefd5bd255 to b2167a93c1a0 (2 revisions) (flutter/flutter#142252) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b4779324b44 to 55eefd5bd255 (6 revisions) (flutter/flutter#142245) 2024-01-25 louisehsu@google.com Fix incorrect zh-cn translation for Look Up Label in selection controls (flutter/flutter#142158) 2024-01-25 jmccandless@google.com PopScope example improvements (flutter/flutter#142163) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d3f16b0d62e to 3b4779324b44 (1 revision) (flutter/flutter#142225) 2024-01-25 engine-flutter-autoroll@skia.org Roll Packages from 8fbdf65 to 21b5abb (6 revisions) (flutter/flutter#142224) 2024-01-25 sigurdm@google.com Don't show legacy welcome message when analytics are disabled (flutter/flutter#140956) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c4ed15cb271 to 1d3f16b0d62e (1 revision) (flutter/flutter#142223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes #141764
Translation suggestion here:
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8222331119728136330&language=zh-CN
Pre-launch Checklist
///
).