Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isAvailableForEnvironment to isForEnvironment #143176

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Rename isAvailableForEnvironment to isForEnvironment #143176

merged 2 commits into from
Mar 8, 2024

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Feb 8, 2024 •
edited
Loading

This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like mainly_refactors or chess_master_experiment or whatever, but I'm pretty sure the old behaviour was not intended.)

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 8, 2024
Piinks
Piinks reviewed Feb 15, 2024
View reviewed changes
packages/flutter_goldens/lib/flutter_goldens.dart Outdated
@@ -349,12 +354,12 @@ class FlutterPreSubmitFileComparator extends FlutterGoldenFileComparator {

/// Decides based on the current environment if goldens tests should be
/// executed as pre-submit tests with Skia Gold.
static bool isAvailableForEnvironment(Platform platform) {
static bool isRecommendedForEnvironment(Platform platform) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about the name, why change it? Recommended seems a bit unclear to me. We must use the right comparator for the given environment, it being recommended makes it seem optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to go with another name. "isIntendedForEnvironment"? Maybe just "isForEnvironment"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed it to isForEnvironment which seems to avoid the confusion of Available and Recommended, let me know what you think.

packages/flutter_goldens/lib/flutter_goldens.dart
@@ -23,7 +23,12 @@ export 'skia_client.dart';
// /packages/flutter/test/widgets/basic_test.dart

const String _kFlutterRootKey = 'FLUTTER_ROOT';
final RegExp _kMainBranch = RegExp(r'master|main');

bool _isMainBranch(String? branch) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hixie
Rename isAvailableForEnvironment to isRecommendedForEnvironment
001316c 
This is part 4 of a broken down version of the flutter#140101 refactor.

This PR renames isAvailableForEnvironment to isRecommendedForEnvironment and replaces a regular expression with a simple function.
@Hixie Hixie force-pushed the golden_refactor_journey_4 branch from e8b801d to 001316c Compare March 1, 2024 19:45
Piinks
Piinks approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - apologies for the delay. I was out for a few days.

@Hixie Hixie changed the title Rename isAvailableForEnvironment to isRecommendedForEnvironment Rename isAvailableForEnvironment to isForEnvironment Mar 8, 2024
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2024
@auto-submit auto-submit bot merged commit 5bd34ef into flutter:master Mar 8, 2024
65 checks passed
@QuncCccccc QuncCccccc added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 8, 2024
@QuncCccccc
Copy link
Contributor

Revert reason: made tree red.

@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 8, 2024

A reason for requesting a revert of flutter/flutter/143176 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 8, 2024
@QuncCccccc
Copy link
Contributor

Reason for revert: made tree red.

@QuncCccccc QuncCccccc added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 8, 2024
@Hixie
Copy link
Contributor Author

Hixie commented Mar 8, 2024

looking at the dashboard (but not the logs), it seems much more likely that fd4ab4f is the cause of the recent failures

auto-submit bot pushed a commit that referenced this pull request Mar 8, 2024
Revert "Rename isAvailableForEnvironment to isForEnvironment (#143176)"
3b52fcf 
This reverts commit 5bd34ef.
@auto-submit auto-submit bot mentioned this pull request Mar 8, 2024
Merged
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 8, 2024
auto-submit bot added a commit that referenced this pull request Mar 8, 2024
@auto-submit
Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)…
0432a69 
…" (#144855)

Reverts: #143176
Initiated by: QuncCccccc
Reason for reverting: made tree red.
Original PR Author: Hixie

Reviewed By: {Piinks}

This change reverts the following previous change:
This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
Hixie added a commit to Hixie/flutter that referenced this pull request Mar 8, 2024
@Hixie
Rename isAvailableForEnvironment to isForEnvironment (flutter#143176)
66f1609 
This is part 4 of a broken down version of the flutter#140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
@Hixie Hixie mentioned this pull request Mar 8, 2024
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2024
@engine-flutter-autoroll
5bd34ef54 Rename isAvailableForEnvironment to isForEnvironment (flutt…
61a5400 
…er/flutter#143176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2024
@engine-flutter-autoroll
5bd34ef54 Rename isAvailableForEnvironment to isForEnvironment (flutt…
a33da14 
…er/flutter#143176)
auto-submit bot pushed a commit that referenced this pull request Mar 10, 2024
@Hixie
Rename isAvailableForEnvironment to isForEnvironment (#143176) (#144858)
dbcce27 
This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)

----

This is a reland of #143176 which was speculatively reverted in #144855 but turned out not to be the cause of the tree redness.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2024
@engine-flutter-autoroll
5bd34ef54 Rename isAvailableForEnvironment to isForEnvironment (flutt…
6d7386b 
…er/flutter#143176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2024
@engine-flutter-autoroll
5bd34ef54 Rename isAvailableForEnvironment to isForEnvironment (flutt…
7ca0aaa 
…er/flutter#143176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
5bd34ef54 Rename isAvailableForEnvironment to isForEnvironment (flutt…
de123ba 
…er/flutter#143176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
5bd34ef54 Rename isAvailableForEnvironment to isForEnvironment (flutt…
d54f40a 
…er/flutter#143176)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
Manual roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions) (#…
3eb794b 
…6299)

Manual roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@7c89ec8...3bb2e59

2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907)
2024-03-10 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875)
2024-03-09 ybz975218925@gmail.com Fix multiple calls to Slider's onChanged. (flutter/flutter#143680)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862)
2024-03-09 polinach@google.com Upgrade vm_service. (flutter/flutter#144845)
2024-03-09 450961837@qq.com Replace dead links (flutter/flutter#144827)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849)
2024-03-09 zanderso@users.noreply.github.com Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861)
2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844)
2024-03-08 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839)
2024-03-08 58190796+MitchellGoodwin@users.noreply.github.com Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790)
2024-03-08 jacksongardner@google.com Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832)
2024-03-08 fluttergithubbot@gmail.com Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817)
2024-03-08 engine-flutter-autoroll@skia.org Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
Roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions) (#6300)
1e46a6a 
flutter/flutter@7c89ec8...3bb2e59

2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907)
2024-03-10 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875)
2024-03-09 ybz975218925@gmail.com Fix multiple calls to Slider's onChanged. (flutter/flutter#143680)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862)
2024-03-09 polinach@google.com Upgrade vm_service. (flutter/flutter#144845)
2024-03-09 450961837@qq.com Replace dead links (flutter/flutter#144827)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849)
2024-03-09 zanderso@users.noreply.github.com Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861)
2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844)
2024-03-08 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839)
2024-03-08 58190796+MitchellGoodwin@users.noreply.github.com Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790)
2024-03-08 jacksongardner@google.com Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832)
2024-03-08 fluttergithubbot@gmail.com Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817)
2024-03-08 engine-flutter-autoroll@skia.org Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
5bd34ef54 Rename isAvailableForEnvironment to isForEnvironment (flutt…
9e4b529 
…er/flutter#143176)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Manual roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions) (f…
559c0a4 
…lutter#6299)

Manual roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@7c89ec8...3bb2e59

2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907)
2024-03-10 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875)
2024-03-09 ybz975218925@gmail.com Fix multiple calls to Slider's onChanged. (flutter/flutter#143680)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862)
2024-03-09 polinach@google.com Upgrade vm_service. (flutter/flutter#144845)
2024-03-09 450961837@qq.com Replace dead links (flutter/flutter#144827)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849)
2024-03-09 zanderso@users.noreply.github.com Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861)
2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844)
2024-03-08 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839)
2024-03-08 58190796+MitchellGoodwin@users.noreply.github.com Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790)
2024-03-08 jacksongardner@google.com Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832)
2024-03-08 fluttergithubbot@gmail.com Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817)
2024-03-08 engine-flutter-autoroll@skia.org Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 7c89ec8bbc6d to 3bb2e5948e7a (31 revisions) (flutte…
a4531b6 
…r#6300)

flutter/flutter@7c89ec8...3bb2e59

2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907)
2024-03-10 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894)
2024-03-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875)
2024-03-09 ybz975218925@gmail.com Fix multiple calls to Slider's onChanged. (flutter/flutter#143680)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862)
2024-03-09 polinach@google.com Upgrade vm_service. (flutter/flutter#144845)
2024-03-09 450961837@qq.com Replace dead links (flutter/flutter#144827)
2024-03-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849)
2024-03-09 zanderso@users.noreply.github.com Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861)
2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844)
2024-03-08 ian@hixie.ch Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839)
2024-03-08 58190796+MitchellGoodwin@users.noreply.github.com Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790)
2024-03-08 jacksongardner@google.com Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832)
2024-03-08 fluttergithubbot@gmail.com Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817)
2024-03-08 engine-flutter-autoroll@skia.org Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hixie @QuncCccccc @Piinks