Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for TabBar crash #144627

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

goderbauer
Copy link
Member

This is a regression test for #144087 and #138588.

To be submitted after #144579.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 5, 2024
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2024
@auto-submit auto-submit bot merged commit 2aa1efc into flutter:master Mar 5, 2024
65 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 6, 2024
flutter/flutter@3b5a2ec...8f84f3f

2024-03-06 engine-flutter-autoroll@skia.org Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659)
2024-03-06 greg@zulip.com Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653)
2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174)
2024-03-05 15619084+vashworth@users.noreply.github.com Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248)
2024-03-05 andrewrkolos@gmail.com Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639)
2024-03-05 hans.muller@gmail.com Updated the smiley TextButton example again (flutter/flutter#144630)
2024-03-05 pateltirth454@gmail.com Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629)
2024-03-05 goderbauer@google.com Add regression test for TabBar crash (flutter/flutter#144627)
2024-03-05 engine-flutter-autoroll@skia.org Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628)
2024-03-05 andrewrkolos@gmail.com remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624)
2024-03-05 goderbauer@google.com Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@goderbauer goderbauer deleted the addCrashingTestToTab branch March 6, 2024 17:12
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
…r#6276)

flutter/flutter@3b5a2ec...8f84f3f

2024-03-06 engine-flutter-autoroll@skia.org Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659)
2024-03-06 greg@zulip.com Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653)
2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174)
2024-03-05 15619084+vashworth@users.noreply.github.com Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248)
2024-03-05 andrewrkolos@gmail.com Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639)
2024-03-05 hans.muller@gmail.com Updated the smiley TextButton example again (flutter/flutter#144630)
2024-03-05 pateltirth454@gmail.com Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629)
2024-03-05 goderbauer@google.com Add regression test for TabBar crash (flutter/flutter#144627)
2024-03-05 engine-flutter-autoroll@skia.org Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628)
2024-03-05 andrewrkolos@gmail.com remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624)
2024-03-05 goderbauer@google.com Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…r#6276)

flutter/flutter@3b5a2ec...8f84f3f

2024-03-06 engine-flutter-autoroll@skia.org Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659)
2024-03-06 greg@zulip.com Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653)
2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174)
2024-03-05 15619084+vashworth@users.noreply.github.com Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248)
2024-03-05 andrewrkolos@gmail.com Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639)
2024-03-05 hans.muller@gmail.com Updated the smiley TextButton example again (flutter/flutter#144630)
2024-03-05 pateltirth454@gmail.com Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629)
2024-03-05 goderbauer@google.com Add regression test for TabBar crash (flutter/flutter#144627)
2024-03-05 engine-flutter-autoroll@skia.org Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628)
2024-03-05 andrewrkolos@gmail.com remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624)
2024-03-05 goderbauer@google.com Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants