Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "Expose build mode in environment of asset transformer processes (#144752)" #144957

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Mar 11, 2024

Reverts: #144752

Initiated by: andrewkolos

Reason for reverting: compilation issue has turned the tree red

Original PR Author: andrewkolos

Reviewed By: {christopherfujino}

This change reverts the following previous change:
In service of #143348

When invoking a package to transform an asset, we set FLUTTER_BUILD_MODE to the CLI name of the build mode being used. Inspired by #101077 (comment):

Do transformers know whether they get executed in debug or release mode? I kinda imagine that being useful. Ex: There's a transformer that optimizes the file size of images. Depending on the amount and size of the images, that could take a significant amount of time. Therefore, I might want to only execute it in release builds.

Note for the reviewer: the interesting part of this change can be found in the commit set environment variable to build mode when running asset transformer…. The rest of the change is updating call sites with a new argument.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 11, 2024
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 11, 2024
@auto-submit auto-submit bot merged commit 187ec75 into master Mar 11, 2024
6 of 8 checks passed
@auto-submit auto-submit bot deleted the revert_83fad745358d923a9e9a22434a1fe719ba32699c branch March 11, 2024 21:00
@andrewkolos andrewkolos added the warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Mar 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 12, 2024
…6304)

Manual roll requested by tarrinneal@google.com

flutter/flutter@3bb2e59...1ca8873

2024-03-12 godofredoc@google.com Update integration tests regexes. (flutter/flutter#144847)
2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fail tests on exceptions raised after test completed (#144706)" (flutter/flutter#144970)
2024-03-11 polinach@google.com Make TabController communicating creation in constructor. (flutter/flutter#144912)
2024-03-11 goderbauer@google.com Fail tests on exceptions raised after test completed (flutter/flutter#144706)
2024-03-11 nate.w5687@gmail.com Refactoring `if` chains into `switch` statements (flutter/flutter#144905)
2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Expose build mode in environment of asset transformer processes (#144752)" (flutter/flutter#144957)
2024-03-11 andrewrkolos@gmail.com Expose build mode in environment of asset transformer processes (flutter/flutter#144752)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9196947bc687 to 6745955bb49e (2 revisions) (flutter/flutter#144946)
2024-03-11 vtrgalo@gmail.com Skip test temporarily until headingLevel is added in engine (issue 41� (flutter/flutter#135077)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b0b59bb224d to 9196947bc687 (1 revision) (flutter/flutter#144934)
2024-03-11 engine-flutter-autoroll@skia.org Roll Packages from 0badb43 to d489d84 (3 revisions) (flutter/flutter#144931)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…lutter#6304)

Manual roll requested by tarrinneal@google.com

flutter/flutter@3bb2e59...1ca8873

2024-03-12 godofredoc@google.com Update integration tests regexes. (flutter/flutter#144847)
2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fail tests on exceptions raised after test completed (#144706)" (flutter/flutter#144970)
2024-03-11 polinach@google.com Make TabController communicating creation in constructor. (flutter/flutter#144912)
2024-03-11 goderbauer@google.com Fail tests on exceptions raised after test completed (flutter/flutter#144706)
2024-03-11 nate.w5687@gmail.com Refactoring `if` chains into `switch` statements (flutter/flutter#144905)
2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Expose build mode in environment of asset transformer processes (#144752)" (flutter/flutter#144957)
2024-03-11 andrewrkolos@gmail.com Expose build mode in environment of asset transformer processes (flutter/flutter#144752)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9196947bc687 to 6745955bb49e (2 revisions) (flutter/flutter#144946)
2024-03-11 vtrgalo@gmail.com Skip test temporarily until headingLevel is added in engine (issue 41� (flutter/flutter#135077)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b0b59bb224d to 9196947bc687 (1 revision) (flutter/flutter#144934)
2024-03-11 engine-flutter-autoroll@skia.org Roll Packages from 0badb43 to d489d84 (3 revisions) (flutter/flutter#144931)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. tool Affects the "flutter" command-line tool. See also t: labels. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants