Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom shape example for AppBar.shape #146421

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

TahaTesser
Copy link
Member

fixes AppBar shape disappears on AppBar elevation change when scrolling

Description

This PR adds an example for complete custom app bar for the AppBar.shape property.

Preview

Screenshot 2024-04-08 at 14 21 04

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 8, 2024
@TahaTesser TahaTesser marked this pull request as ready for review April 8, 2024 17:39
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice looking example! I've suggested one tiny change. LGTM

examples/api/lib/material/app_bar/app_bar.4.dart Outdated Show resolved Hide resolved
}
}

class CustomAppBarShape extends OutlinedBorder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful shape!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2024
@auto-submit auto-submit bot merged commit cba689c into flutter:master Apr 8, 2024
67 checks passed
@TahaTesser TahaTesser deleted the app_bar_shape_example branch April 8, 2024 18:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 9, 2024
flutter/flutter@533d04d...4967a94

2024-04-09 tessertaha@gmail.com Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 jmccandless@google.com Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 leroux_bruno@yahoo.fr Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146444)
2024-04-08 tessertaha@gmail.com Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
fixes [AppBar shape disappears on AppBar elevation change when scrolling](flutter#145945)

### Description
This PR adds an example for complete custom app bar for the  `AppBar.shape` property.

### Preview

![Screenshot 2024-04-08 at 14 21 04](https://github.com/flutter/flutter/assets/48603081/ae3eda2b-b709-4652-9f2c-dd7b7dcfeb5c)
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…r#6492)

flutter/flutter@533d04d...4967a94

2024-04-09 tessertaha@gmail.com Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 jmccandless@google.com Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 leroux_bruno@yahoo.fr Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146444)
2024-04-08 tessertaha@gmail.com Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…r#6492)

flutter/flutter@533d04d...4967a94

2024-04-09 tessertaha@gmail.com Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 jmccandless@google.com Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 leroux_bruno@yahoo.fr Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146444)
2024-04-08 tessertaha@gmail.com Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppBar shape disappears on AppBar elevation change when scrolling
2 participants