Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flutter README.md image sources #146430

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix Flutter README.md image sources #146430

merged 1 commit into from
Apr 9, 2024

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 8, 2024 •
edited
Loading

fixes Some images show "404 - page not found" in Flutter README.md

These images had their sources updated in flutter/website#10336

Before

Screenshot 2024-04-08 at 18 19 30

After

Screenshot 2024-04-08 at 18 19 23

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser marked this pull request as ready for review April 8, 2024 15:19
@TahaTesser TahaTesser requested a review from parlough April 8, 2024 15:19
@TahaTesser TahaTesser changed the title Fix Flutter READM.md image sources Fix Flutter README.md image sources Apr 8, 2024
parlough
parlough approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and updating the links! Looks good to me :)

I'll work on a more flexible/resistant home for these images as follow up.

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Apr 8, 2024

auto label is removed for flutter/flutter/146430, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@parlough parlough added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Apr 8, 2024

auto label is removed for flutter/flutter/146430, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Apr 9, 2024
@TahaTesser TahaTesser removed a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. f: material design flutter/packages/flutter/material repository. labels Apr 9, 2024
@TahaTesser TahaTesser removed d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Apr 9, 2024
@TahaTesser TahaTesser removed the request for review from christopherfujino April 9, 2024 07:10
@TahaTesser
Copy link
Member Author

Incorrect rebase, fixed it!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2024
@auto-submit auto-submit bot merged commit 4967a94 into flutter:master Apr 9, 2024
31 checks passed
@TahaTesser TahaTesser deleted the fix_readme_images_source branch April 9, 2024 08:42
@delltrak delltrak mentioned this pull request Apr 9, 2024
Closed
9 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2024
@engine-flutter-autoroll
4967a94cd Fix Flutter README.md image sources (flutter/flutter#146430)
8ee4a3c
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 9, 2024
@engine-flutter-autoroll
Roll Flutter from 533d04d14df0 to 4967a94cd907 (12 revisions) (#6492)
b855307 
flutter/flutter@533d04d...4967a94

2024-04-09 tessertaha@gmail.com Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 jmccandless@google.com Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 leroux_bruno@yahoo.fr Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146444)
2024-04-08 tessertaha@gmail.com Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@TahaTesser @gilnobrega
Fix Flutter README.md image sources (flutter#146430)
fd170a4 
fixes [Some images show "404 - page not found" in Flutter `README.md` ](flutter#146419)

These images had their sources updated in flutter/website#10336

### Before
![Screenshot 2024-04-08 at 18 19 30](https://github.com/flutter/flutter/assets/48603081/56549762-b7c8-41a1-89db-cd45cd98b35a)

### After
![Screenshot 2024-04-08 at 18 19 23](https://github.com/flutter/flutter/assets/48603081/35d5772f-1144-4166-99cb-fded79550762)
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 533d04d14df0 to 4967a94cd907 (12 revisions) (flutte…
b4223bd 
…r#6492)

flutter/flutter@533d04d...4967a94

2024-04-09 tessertaha@gmail.com Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 jmccandless@google.com Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 leroux_bruno@yahoo.fr Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146444)
2024-04-08 tessertaha@gmail.com Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 533d04d14df0 to 4967a94cd907 (12 revisions) (flutte…
ab5455c 
…r#6492)

flutter/flutter@533d04d...4967a94

2024-04-09 tessertaha@gmail.com Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 jmccandless@google.com Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 leroux_bruno@yahoo.fr Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146444)
2024-04-08 tessertaha@gmail.com Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some images show "404 - page not found" in Flutter README.md
2 participants
@TahaTesser @parlough