Update link branches to `main` #146558

guidezpl · 2024-04-10T09:39:14Z

Update CS and googlesource.com link branches
Update GitHub /blob/ and /tree/ links

Tested links manually and fixes a few broken or deprecated links

Added a test that validates that master isn't used, except for specified repos.

Part of #121564

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Also fix a broken link to Fuschia source

Hixie · 2024-04-12T21:12:38Z

LGTM. I didn't test every link but I spot checked a random sample.

Hixie · 2024-04-12T21:13:37Z

Would be nice to have a test that checks that we don't have any files with /master/ links, otherwise we'll definitely regress this.

TahaTesser · 2024-04-17T10:40:03Z

@guidezpl
It seems this is breaking the tree.

▌01:31:33▐ Links to GitHub...
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ /b/s/w/ir/x/w/flutter/dev/bots/analyze.dart contains https://github.com/flutter/flutter/blob/master/dev/tools/gen_defaults, which uses the banned "master" branch.
║ /b/s/w/ir/x/w/flutter/dev/bots/test/analyze_test.dart contains https://github.com/flutter/flutter/blob/master/dev/tools/gen_defaults, which uses the banned "master" branch.
║ Change the URLs above to the expected pattern by using the "main" branch if it exists, otherwise adding the repository to the list of exceptions in analyze.dart.

This reverts commit 072b887.

guidezpl · 2024-04-17T11:21:41Z

Oh interesting, let's revert #146880

Reverts #146558 Causes failure

- Update CS and googlesource.com link branches - Update GitHub /blob/ and /tree/ links Tested links manually and fixes a few broken or deprecated links Added a test that validates that `master` isn't used, except for specified repos. Part of flutter#121564 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes

Reland #146558, reverted in #146880 due to an outdated test result ## Original description - Update CS and googlesource.com link branches - Update GitHub /blob/ and /tree/ links Tested links manually and fixes a few broken or deprecated links Added a test that validates that `master` isn't used, except for specified repos. Part of #121564

@main

Roll Flutter from 3882afbfa997 to fb110b98da15 (56 revisions) flutter/flutter@3882afb...fb110b9 2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `MaterialBanner` (flutter/flutter#146963) 2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in data table (flutter/flutter#146892) 2024-04-18 32538273+ValentinVignal@users.noreply.github.com Dispose the curved animation in transition test (flutter/flutter#146961) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969) 2024-04-18 737941+loic-sharma@users.noreply.github.com [macOS] Migrate @NSApplicationMain attribute to @main (flutter/flutter#146848) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.3 to 6.0.4 (flutter/flutter#146954) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946) 2024-04-17 goderbauer@google.com Bump meta to 1.14.0 (flutter/flutter#146925) 2024-04-17 ian@hixie.ch Make goldenFileComparator a field instead of a trivial property (flutter/flutter#146800) 2024-04-17 ian@hixie.ch Assert that the goldenFileComparator is a LocalFileComparator (flutter/flutter#146802) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic (#146931)" (flutter/flutter#146947) 2024-04-17 103135467+sealesj@users.noreply.github.com Create web tests suite & runner_utils (flutter/flutter#146592) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940) 2024-04-17 ian@hixie.ch Try to be more consistent about deleting test apps in devicelab logic (flutter/flutter#146931) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937) 2024-04-17 ian@hixie.ch Remove now-redundant tests for isForEnvironment (flutter/flutter#146804) 2024-04-17 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146929) 2024-04-17 polinach@google.com Get rid of _NullElement. (flutter/flutter#146741) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930) 2024-04-17 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in paginated tables (flutter/flutter#146755) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic. (#146856)" (flutter/flutter#146927) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898) 2024-04-17 ian@hixie.ch Try to be more consistent about deleting test apps in devicelab logic. (flutter/flutter#146856) 2024-04-17 derekx@google.com Unpin frontend_server_client and roll packages (flutter/flutter#146650) 2024-04-17 engine-flutter-autoroll@skia.org Roll Packages from 90c876d to d39830e (4 revisions) (flutter/flutter#146895) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889) 2024-04-17 6655696+guidezpl@users.noreply.github.com Reland: Update link branches to `main` (flutter/flutter#146882) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884) 2024-04-17 6655696+guidezpl@users.noreply.github.com Revert "Update link branches to `main`" (flutter/flutter#146880) 2024-04-17 tessertaha@gmail.com Fix `Tab` indicator image configuration doesn't inherit device pixel ratio (flutter/flutter#146812) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865) 2024-04-17 6655696+guidezpl@users.noreply.github.com Update link branches to `main` (flutter/flutter#146558) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863) 2024-04-17 ian@hixie.ch Rewrap some lines that are about to get much longer. (flutter/flutter#146803) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859) 2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857) 2024-04-16 nate.w5687@gmail.com Switch to relevant `Remote` constructors (flutter/flutter#146773) ...

- Update CS and googlesource.com link branches - Update GitHub /blob/ and /tree/ links Tested links manually and fixes a few broken or deprecated links Added a test that validates that `master` isn't used, except for specified repos. Part of flutter#121564 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes

Reverts flutter#146558 Causes failure

Reland flutter#146558, reverted in flutter#146880 due to an outdated test result ## Original description - Update CS and googlesource.com link branches - Update GitHub /blob/ and /tree/ links Tested links manually and fixes a few broken or deprecated links Added a test that validates that `master` isn't used, except for specified repos. Part of flutter#121564

Update CS and googlesource.com link branches

2982f0e

Also fix a broken link to Fuschia source

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. labels Apr 10, 2024

GitHub links

690ca67

tree/master

c0ae745

github-actions bot added the a: desktop Running on desktop label Apr 10, 2024

guidezpl changed the title ~~Update CS and googlesource.com link branches~~ First pass at updating link branches to main Apr 10, 2024

guidezpl requested a review from Hixie April 10, 2024 10:03

githubusercontent

bc5c227

guidezpl mentioned this pull request Apr 10, 2024

Migrate the flutter/flutter repository to use main as the primary development branch/channel #121564

Open

18 tasks

guidezpl changed the title ~~First pass at updating link branches to main~~ Update link branches to main (1st pass) Apr 10, 2024

+/refs/heads/master

5eeaac5

Hixie approved these changes Apr 12, 2024

View reviewed changes

guidezpl added 4 commits April 15, 2024 13:57

x

ba704a4

add test

97606b9

add TODOs

116370d

update TODO user

5d297f5

guidezpl changed the title ~~Update link branches to main (1st pass)~~ Update link branches to main Apr 16, 2024

guidezpl merged commit 072b887 into flutter:master Apr 17, 2024
139 checks passed

guidezpl deleted the main-rename branch April 17, 2024 07:44

guidezpl added a commit that referenced this pull request Apr 17, 2024

Revert "Update link branches to main (#146558)"

09dc427

This reverts commit 072b887.

guidezpl mentioned this pull request Apr 17, 2024

Revert "Update link branches to main" #146880

Merged

guidezpl restored the main-rename branch April 17, 2024 11:22

guidezpl added a commit that referenced this pull request Apr 17, 2024

Revert "Update link branches to main" (#146880)

33a9643

Reverts #146558 Causes failure

guidezpl mentioned this pull request Apr 17, 2024

Reland: Update link branches to main #146882

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to 180b77685b31 (24 revisions) flutter/packages#6554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

072b8874a Update link branches to main (flutter/flutter#146558)

de18a88

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to cd43d06c44aa (25 revisions) flutter/packages#6555

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

072b8874a Update link branches to main (flutter/flutter#146558)

45f54ee

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to cf26b1150f4b (26 revisions) flutter/packages#6558

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

072b8874a Update link branches to main (flutter/flutter#146558)

5ecd8ff

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to 0301c8dfa41e (27 revisions) flutter/packages#6559

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

072b8874a Update link branches to main (flutter/flutter#146558)

6407787

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to f8c3e52776ae (29 revisions) flutter/packages#6560

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

072b8874a Update link branches to main (flutter/flutter#146558)

030d195

engine-flutter-autoroll mentioned this pull request Apr 18, 2024

Roll Flutter from 3882afbfa997 to fb110b98da15 (56 revisions) flutter/packages#6565

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024

072b8874a Update link branches to main (flutter/flutter#146558)

cdb44b9

engine-flutter-autoroll mentioned this pull request Apr 18, 2024

Manual roll Flutter from 3882afbfa997 to c219bf73fce4 (61 revisions) flutter/packages#6566

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024

072b8874a Update link branches to main (flutter/flutter#146558)

e4a59f4

gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024

Revert "Update link branches to main" (flutter#146880)

95ccbe2

Reverts flutter#146558 Causes failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update link branches to `main` #146558

Update link branches to `main` #146558

guidezpl commented Apr 10, 2024 •

edited

Hixie commented Apr 12, 2024

Hixie commented Apr 12, 2024

TahaTesser commented Apr 17, 2024

guidezpl commented Apr 17, 2024

Update link branches to main #146558

Update link branches to main #146558

Conversation

guidezpl commented Apr 10, 2024 • edited

Pre-launch Checklist

Hixie commented Apr 12, 2024

Hixie commented Apr 12, 2024

TahaTesser commented Apr 17, 2024

guidezpl commented Apr 17, 2024

Update link branches to `main` #146558

Update link branches to `main` #146558

guidezpl commented Apr 10, 2024 •

edited