Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrap some lines that are about to get much longer. #146803

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Rewrap some lines that are about to get much longer. #146803

merged 1 commit into from
Apr 17, 2024

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 16, 2024

This is part 10 of a broken down version of the #140101 refactor.

This will make future PRs easier to review.

@Hixie
Rewrap some lines that are about to get much longer.
45eedb3 
This is part 10 of a broken down version of the flutter#140101 refactor.

This will make future PRs easier to review.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 16, 2024
@Hixie
Copy link
Contributor Author

Hixie commented Apr 16, 2024

test-exempt: reformatting code

goderbauer
goderbauer approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2024
@auto-submit auto-submit bot merged commit 5a81e91 into flutter:master Apr 17, 2024
73 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
5a81e9150 Rewrap some lines that are about to get much longer. (flutt…
a5db86e 
…er/flutter#146803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
5a81e9150 Rewrap some lines that are about to get much longer. (flutt…
bd52ab2 
…er/flutter#146803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
5a81e9150 Rewrap some lines that are about to get much longer. (flutt…
cd92e5f 
…er/flutter#146803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
5a81e9150 Rewrap some lines that are about to get much longer. (flutt…
d0095c9 
…er/flutter#146803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
5a81e9150 Rewrap some lines that are about to get much longer. (flutt…
bf81f32 
…er/flutter#146803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
5a81e9150 Rewrap some lines that are about to get much longer. (flutt…
89199d5 
…er/flutter#146803)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
5a81e9150 Rewrap some lines that are about to get much longer. (flutt…
e6986a9 
…er/flutter#146803)
tarrinneal pushed a commit to flutter/packages that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
Roll Flutter from 3882afbfa997 to fb110b98da15 (56 revisions) (#6565)
b0e6d7f 
Roll Flutter from 3882afbfa997 to fb110b98da15 (56 revisions)

flutter/flutter@3882afb...fb110b9

2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory
leaks in `MaterialBanner` (flutter/flutter#146963)
2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory
leak in data table (flutter/flutter#146892)
2024-04-18 32538273+ValentinVignal@users.noreply.github.com Dispose the
curved animation in transition test (flutter/flutter#146961)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969)
2024-04-18 737941+loic-sharma@users.noreply.github.com [macOS] Migrate
@NSApplicationMain attribute to @main (flutter/flutter#146848)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
peter-evans/create-pull-request from 6.0.3 to 6.0.4
(flutter/flutter#146954)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946)
2024-04-17 goderbauer@google.com Bump meta to 1.14.0
(flutter/flutter#146925)
2024-04-17 ian@hixie.ch Make goldenFileComparator a field instead of a
trivial property (flutter/flutter#146800)
2024-04-17 ian@hixie.ch Assert that the goldenFileComparator is a
LocalFileComparator (flutter/flutter#146802)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic
(#146931)" (flutter/flutter#146947)
2024-04-17 103135467+sealesj@users.noreply.github.com Create web tests
suite & runner_utils (flutter/flutter#146592)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940)
2024-04-17 ian@hixie.ch Try to be more consistent about deleting test
apps in devicelab logic (flutter/flutter#146931)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937)
2024-04-17 ian@hixie.ch Remove now-redundant tests for isForEnvironment
(flutter/flutter#146804)
2024-04-17 137456488+flutter-pub-roller-bot@users.noreply.github.com
Roll pub packages (flutter/flutter#146929)
2024-04-17 polinach@google.com Get rid of _NullElement.
(flutter/flutter#146741)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930)
2024-04-17 32538273+ValentinVignal@users.noreply.github.com Fix memory
leak in paginated tables (flutter/flutter#146755)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic.
(#146856)" (flutter/flutter#146927)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898)
2024-04-17 ian@hixie.ch Try to be more consistent about deleting test
apps in devicelab logic. (flutter/flutter#146856)
2024-04-17 derekx@google.com Unpin frontend_server_client and roll
packages (flutter/flutter#146650)
2024-04-17 engine-flutter-autoroll@skia.org Roll Packages from
90c876d to d39830e (4 revisions) (flutter/flutter#146895)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889)
2024-04-17 6655696+guidezpl@users.noreply.github.com Reland: Update link
branches to `main` (flutter/flutter#146882)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884)
2024-04-17 6655696+guidezpl@users.noreply.github.com Revert "Update link
branches to `main`" (flutter/flutter#146880)
2024-04-17 tessertaha@gmail.com Fix `Tab` indicator image configuration
doesn't inherit device pixel ratio (flutter/flutter#146812)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865)
2024-04-17 6655696+guidezpl@users.noreply.github.com Update link
branches to `main` (flutter/flutter#146558)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863)
2024-04-17 ian@hixie.ch Rewrap some lines that are about to get much
longer. (flutter/flutter#146803)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857)
2024-04-16 nate.w5687@gmail.com Switch to relevant `Remote` constructors
(flutter/flutter#146773)
...
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@Hixie @gilnobrega
Rewrap some lines that are about to get much longer. (flutter#146803)
e1e0a19 
This is part 10 of a broken down version of the flutter#140101 refactor.

This will make future PRs easier to review.
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 3882afbfa997 to fb110b98da15 (56 revisions) (flutte…
3cff2e1 
…r#6565)

Roll Flutter from 3882afbfa997 to fb110b98da15 (56 revisions)

flutter/flutter@3882afb...fb110b9

2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory
leaks in `MaterialBanner` (flutter/flutter#146963)
2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory
leak in data table (flutter/flutter#146892)
2024-04-18 32538273+ValentinVignal@users.noreply.github.com Dispose the
curved animation in transition test (flutter/flutter#146961)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969)
2024-04-18 737941+loic-sharma@users.noreply.github.com [macOS] Migrate
@NSApplicationMain attribute to @main (flutter/flutter#146848)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960)
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from
624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
peter-evans/create-pull-request from 6.0.3 to 6.0.4
(flutter/flutter#146954)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946)
2024-04-17 goderbauer@google.com Bump meta to 1.14.0
(flutter/flutter#146925)
2024-04-17 ian@hixie.ch Make goldenFileComparator a field instead of a
trivial property (flutter/flutter#146800)
2024-04-17 ian@hixie.ch Assert that the goldenFileComparator is a
LocalFileComparator (flutter/flutter#146802)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic
(#146931)" (flutter/flutter#146947)
2024-04-17 103135467+sealesj@users.noreply.github.com Create web tests
suite & runner_utils (flutter/flutter#146592)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940)
2024-04-17 ian@hixie.ch Try to be more consistent about deleting test
apps in devicelab logic (flutter/flutter#146931)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937)
2024-04-17 ian@hixie.ch Remove now-redundant tests for isForEnvironment
(flutter/flutter#146804)
2024-04-17 137456488+flutter-pub-roller-bot@users.noreply.github.com
Roll pub packages (flutter/flutter#146929)
2024-04-17 polinach@google.com Get rid of _NullElement.
(flutter/flutter#146741)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930)
2024-04-17 32538273+ValentinVignal@users.noreply.github.com Fix memory
leak in paginated tables (flutter/flutter#146755)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic.
(#146856)" (flutter/flutter#146927)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898)
2024-04-17 ian@hixie.ch Try to be more consistent about deleting test
apps in devicelab logic. (flutter/flutter#146856)
2024-04-17 derekx@google.com Unpin frontend_server_client and roll
packages (flutter/flutter#146650)
2024-04-17 engine-flutter-autoroll@skia.org Roll Packages from
90c876d to d39830e (4 revisions) (flutter/flutter#146895)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889)
2024-04-17 6655696+guidezpl@users.noreply.github.com Reland: Update link
branches to `main` (flutter/flutter#146882)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884)
2024-04-17 6655696+guidezpl@users.noreply.github.com Revert "Update link
branches to `main`" (flutter/flutter#146880)
2024-04-17 tessertaha@gmail.com Fix `Tab` indicator image configuration
doesn't inherit device pixel ratio (flutter/flutter#146812)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865)
2024-04-17 6655696+guidezpl@users.noreply.github.com Update link
branches to `main` (flutter/flutter#146558)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863)
2024-04-17 ian@hixie.ch Rewrap some lines that are about to get much
longer. (flutter/flutter#146803)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859)
2024-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857)
2024-04-16 nate.w5687@gmail.com Switch to relevant `Remote` constructors
(flutter/flutter#146773)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hixie @goderbauer