Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for animated_positioned.0.dart API example. #146720

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Add test for animated_positioned.0.dart API example. #146720

merged 4 commits into from
Apr 23, 2024

Conversation

ksokolovskyi
Copy link
Contributor

This PR contributes to #130459

Description

  • Adds examples/api/test/widgets/implicit_animations/animated_positioned.0_test.dart test

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 13, 2024
Renzo-Olivares
Renzo-Olivares approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksokolovskyi ksokolovskyi force-pushed the add-animated-positioned-example-tests branch from 5f3fcea to 2915867 Compare April 19, 2024 15:44
@ksokolovskyi ksokolovskyi force-pushed the add-animated-positioned-example-tests branch from 2915867 to 0537c6a Compare April 19, 2024 16:37
justinmc
justinmc approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits 👍

examples/api/test/widgets/implicit_animations/animated_positioned.0_test.dart Outdated Show resolved Hide resolved
@ksokolovskyi
Copy link
Contributor Author

@justinmc @Renzo-Olivares thanks for the review!
I applied suggestions in the latest commit.

Renzo-Olivares
Renzo-Olivares approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2024
@auto-submit auto-submit bot merged commit b0524b3 into flutter:master Apr 23, 2024
140 checks passed
@ksokolovskyi
Copy link
Contributor Author

@Renzo-Olivares @justinmc thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024
@engine-flutter-autoroll
b0524b354 Add test for animated_positioned.0.dart API example. (flutt…
4a19869 
…er/flutter#146720)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024
@engine-flutter-autoroll
b0524b354 Add test for animated_positioned.0.dart API example. (flutt…
2ac4691 
…er/flutter#146720)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024
@engine-flutter-autoroll
b0524b354 Add test for animated_positioned.0.dart API example. (flutt…
04609ca 
…er/flutter#146720)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 24, 2024
@engine-flutter-autoroll
Roll Flutter from 77043bae1a5e to dba4f7747441 (30 revisions) (#6607)
2925db2 
flutter/flutter@77043ba...dba4f77

2024-04-24 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `BottomNavigationBar`  (flutter/flutter#147213)
2024-04-24 32538273+ValentinVignal@users.noreply.github.com Disable leak tracking for selection text area (flutter/flutter#147273)
2024-04-24 tessertaha@gmail.com Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264)
2024-04-23 72562119+tgucio@users.noreply.github.com Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722)
2024-04-23 50643541+Mairramer@users.noreply.github.com Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for focus_node.0.dart API example. (flutter/flutter#146943)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255)
2024-04-23 103135467+sealesj@users.noreply.github.com Refactor framework + test harness tests (flutter/flutter#146213)
2024-04-23 tessertaha@gmail.com Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248)
2024-04-23 82336674+gilnobrega@users.noreply.github.com Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_align.0.dart API example. (flutter/flutter#146719)
2024-04-23 choi88andys@gmail.com Fix typos related to Navigator (flutter/flutter#147221)
2024-04-23 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in switch painter (flutter/flutter#147228)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_positioned.0.dart API example. (flutter/flutter#146720)
2024-04-23 katelovett@google.com Update icon tree shaker to allow system font fallback (flutter/flutter#147202)
2024-04-23 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241)
2024-04-23 engine-flutter-autoroll@skia.org Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Apr 26, 2024
Open
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 77043bae1a5e to dba4f7747441 (30 revisions) (flutte…
2f23d34 
…r#6607)

flutter/flutter@77043ba...dba4f77

2024-04-24 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `BottomNavigationBar`  (flutter/flutter#147213)
2024-04-24 32538273+ValentinVignal@users.noreply.github.com Disable leak tracking for selection text area (flutter/flutter#147273)
2024-04-24 tessertaha@gmail.com Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264)
2024-04-23 72562119+tgucio@users.noreply.github.com Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722)
2024-04-23 50643541+Mairramer@users.noreply.github.com Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for focus_node.0.dart API example. (flutter/flutter#146943)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255)
2024-04-23 103135467+sealesj@users.noreply.github.com Refactor framework + test harness tests (flutter/flutter#146213)
2024-04-23 tessertaha@gmail.com Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248)
2024-04-23 82336674+gilnobrega@users.noreply.github.com Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_align.0.dart API example. (flutter/flutter#146719)
2024-04-23 choi88andys@gmail.com Fix typos related to Navigator (flutter/flutter#147221)
2024-04-23 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in switch painter (flutter/flutter#147228)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_positioned.0.dart API example. (flutter/flutter#146720)
2024-04-23 katelovett@google.com Update icon tree shaker to allow system font fallback (flutter/flutter#147202)
2024-04-23 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241)
2024-04-23 engine-flutter-autoroll@skia.org Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 77043bae1a5e to dba4f7747441 (30 revisions) (flutte…
bd7a024 
…r#6607)

flutter/flutter@77043ba...dba4f77

2024-04-24 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `BottomNavigationBar`  (flutter/flutter#147213)
2024-04-24 32538273+ValentinVignal@users.noreply.github.com Disable leak tracking for selection text area (flutter/flutter#147273)
2024-04-24 tessertaha@gmail.com Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264)
2024-04-23 72562119+tgucio@users.noreply.github.com Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722)
2024-04-23 50643541+Mairramer@users.noreply.github.com Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for focus_node.0.dart API example. (flutter/flutter#146943)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255)
2024-04-23 103135467+sealesj@users.noreply.github.com Refactor framework + test harness tests (flutter/flutter#146213)
2024-04-23 tessertaha@gmail.com Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248)
2024-04-23 82336674+gilnobrega@users.noreply.github.com Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_align.0.dart API example. (flutter/flutter#146719)
2024-04-23 choi88andys@gmail.com Fix typos related to Navigator (flutter/flutter#147221)
2024-04-23 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in switch painter (flutter/flutter#147228)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_positioned.0.dart API example. (flutter/flutter#146720)
2024-04-23 katelovett@google.com Update icon tree shaker to allow system font fallback (flutter/flutter#147202)
2024-04-23 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241)
2024-04-23 engine-flutter-autoroll@skia.org Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksokolovskyi @justinmc @Renzo-Olivares