Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frozen StretchingOverscrollIndicator animation #147195

Conversation

gilnobrega
Copy link
Contributor

StretchingOverscrollIndicator's controller does not have a minimum value for its animation duration.
When the OverscrollNotification's velocity is small enough (< 25) the controller's absorbImpact method sets this animation duration to 0ms, making the animation appear frozen to the user.

This PR sets a minimum animation duration of 50ms.

Fixes #146277

Before After
Screen.Recording.2024-04-04.at.16.07.43.mov
Screen.Recording.2024-04-04.at.16.34.17.mov

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Apr 22, 2024
@gilnobrega gilnobrega changed the title reland fix and tests Fix frozen StretchingOverscrollIndicator animation Apr 22, 2024
Comment on lines 844 to 848
// Constants for absorbImpact.
static const double _minVelocity = 1;
static const double _maxVelocity = 10000;
static const Duration _minStretchDuration = Duration(milliseconds: 50);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piinks Google testing step failed again so I thought I'd update the branch in #146280 with the latest master.

I managed to ruin the commit tree so I've opened this PR instead.

Please have a look at the constants introduced here as per the feedback left by @chunhtai

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for const, you should start with _k

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from Piinks April 23, 2024 16:41
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry about the rebase issue, thanks for sticking with it! Much appreciated contribution, LGTM. :)

The Google testing shard will likely fail again, we'll just need to set it green when it does to land.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2024
@auto-submit auto-submit bot merged commit dd647b0 into flutter:master Apr 23, 2024
75 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 24, 2024
flutter/flutter@77043ba...dba4f77

2024-04-24 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `BottomNavigationBar`  (flutter/flutter#147213)
2024-04-24 32538273+ValentinVignal@users.noreply.github.com Disable leak tracking for selection text area (flutter/flutter#147273)
2024-04-24 tessertaha@gmail.com Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264)
2024-04-23 72562119+tgucio@users.noreply.github.com Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722)
2024-04-23 50643541+Mairramer@users.noreply.github.com Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for focus_node.0.dart API example. (flutter/flutter#146943)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255)
2024-04-23 103135467+sealesj@users.noreply.github.com Refactor framework + test harness tests (flutter/flutter#146213)
2024-04-23 tessertaha@gmail.com Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248)
2024-04-23 82336674+gilnobrega@users.noreply.github.com Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_align.0.dart API example. (flutter/flutter#146719)
2024-04-23 choi88andys@gmail.com Fix typos related to Navigator (flutter/flutter#147221)
2024-04-23 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in switch painter (flutter/flutter#147228)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_positioned.0.dart API example. (flutter/flutter#146720)
2024-04-23 katelovett@google.com Update icon tree shaker to allow system font fallback (flutter/flutter#147202)
2024-04-23 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241)
2024-04-23 engine-flutter-autoroll@skia.org Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…r#6607)

flutter/flutter@77043ba...dba4f77

2024-04-24 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `BottomNavigationBar`  (flutter/flutter#147213)
2024-04-24 32538273+ValentinVignal@users.noreply.github.com Disable leak tracking for selection text area (flutter/flutter#147273)
2024-04-24 tessertaha@gmail.com Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264)
2024-04-23 72562119+tgucio@users.noreply.github.com Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722)
2024-04-23 50643541+Mairramer@users.noreply.github.com Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for focus_node.0.dart API example. (flutter/flutter#146943)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255)
2024-04-23 103135467+sealesj@users.noreply.github.com Refactor framework + test harness tests (flutter/flutter#146213)
2024-04-23 tessertaha@gmail.com Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248)
2024-04-23 82336674+gilnobrega@users.noreply.github.com Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_align.0.dart API example. (flutter/flutter#146719)
2024-04-23 choi88andys@gmail.com Fix typos related to Navigator (flutter/flutter#147221)
2024-04-23 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in switch painter (flutter/flutter#147228)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_positioned.0.dart API example. (flutter/flutter#146720)
2024-04-23 katelovett@google.com Update icon tree shaker to allow system font fallback (flutter/flutter#147202)
2024-04-23 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241)
2024-04-23 engine-flutter-autoroll@skia.org Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…r#6607)

flutter/flutter@77043ba...dba4f77

2024-04-24 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `BottomNavigationBar`  (flutter/flutter#147213)
2024-04-24 32538273+ValentinVignal@users.noreply.github.com Disable leak tracking for selection text area (flutter/flutter#147273)
2024-04-24 tessertaha@gmail.com Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264)
2024-04-23 72562119+tgucio@users.noreply.github.com Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722)
2024-04-23 50643541+Mairramer@users.noreply.github.com Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for focus_node.0.dart API example. (flutter/flutter#146943)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255)
2024-04-23 103135467+sealesj@users.noreply.github.com Refactor framework + test harness tests (flutter/flutter#146213)
2024-04-23 tessertaha@gmail.com Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248)
2024-04-23 82336674+gilnobrega@users.noreply.github.com Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_align.0.dart API example. (flutter/flutter#146719)
2024-04-23 choi88andys@gmail.com Fix typos related to Navigator (flutter/flutter#147221)
2024-04-23 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in switch painter (flutter/flutter#147228)
2024-04-23 sokolovskyi.konstantin@gmail.com Add test for animated_positioned.0.dart API example. (flutter/flutter#146720)
2024-04-23 katelovett@google.com Update icon tree shaker to allow system font fallback (flutter/flutter#147202)
2024-04-23 nate.w5687@gmail.com `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241)
2024-04-23 engine-flutter-autoroll@skia.org Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StretchingOverscrollIndicator: frozen overscroll animation
3 participants