Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devicelab] explicitly enable vulkan validation in test. #147382

Merged

Conversation

jonahwilliams
Copy link
Member

Part of #142659

this test expects validation layers on, so we need to explicitly enable them before we can turn them off by default.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2024
@jonahwilliams jonahwilliams merged commit 4e16e67 into flutter:master Apr 25, 2024
139 of 140 checks passed
@jonahwilliams jonahwilliams deleted the expose_vulkan_validation_flag branch April 25, 2024 21:07
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 26, 2024
flutter/flutter@5d3bca4...2e80670

2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399)
2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372)
2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388)
2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391)
2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312)
2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016)
2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386)
2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378)
2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853)
2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303)
2024-04-25 engine-flutter-autoroll@skia.org Roll Packages from cf6d280 to fde908d (11 revisions) (flutter/flutter#147375)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…r#6616)

flutter/flutter@5d3bca4...2e80670

2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399)
2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372)
2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388)
2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391)
2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312)
2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016)
2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386)
2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378)
2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853)
2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303)
2024-04-25 engine-flutter-autoroll@skia.org Roll Packages from cf6d280 to fde908d (11 revisions) (flutter/flutter#147375)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
itsjustkevin pushed a commit to itsjustkevin/flutter that referenced this pull request May 22, 2024
)

Part of flutter#142659

this test expects validation layers on, so we need to explicitly enable
them before we can turn them off by default.
auto-submit bot pushed a commit that referenced this pull request May 22, 2024
… (#148863)

Fix for release build failure https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3962/overview

Part of #142659

this test expects validation layers on, so we need to explicitly enable them before we can turn them off by default.
jehovahQ8 pushed a commit to jehovahQ8/flutter that referenced this pull request May 24, 2024
…r#147382) (flutter#148863)

Fix for release build failure https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3962/overview

Part of flutter#142659

this test expects validation layers on, so we need to explicitly enable them before we can turn them off by default.
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…r#6616)

flutter/flutter@5d3bca4...2e80670

2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399)
2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372)
2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388)
2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370)
2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391)
2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312)
2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016)
2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386)
2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378)
2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853)
2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303)
2024-04-25 engine-flutter-autoroll@skia.org Roll Packages from cf6d280 to fde908d (11 revisions) (flutter/flutter#147375)
2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants