New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks in CupertinoSwitch
#147821
Merged
polina-c
merged 2 commits into
flutter:master
from
ValentinVignal:flutter/leak-tracking/Fix-cupertino-switch
May 5, 2024
Merged
Fix memory leaks in CupertinoSwitch
#147821
polina-c
merged 2 commits into
flutter:master
from
ValentinVignal:flutter/leak-tracking/Fix-cupertino-switch
May 5, 2024
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @polina-c |
github-actions
bot
added
framework
flutter/packages/flutter repository. See also f: labels.
f: cupertino
flutter/packages/flutter/cupertino repository
labels
May 4, 2024
ValentinVignal
force-pushed
the
flutter/leak-tracking/Fix-cupertino-switch
branch
from
May 4, 2024 05:40
d4a25a7
to
61c3fd6
Compare
polina-c
added
the
a: leak tracking
Issues and PRs related to memory leaks detected by leak_tracker
label
May 5, 2024
polina-c
approved these changes
May 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 6, 2024
flutter/flutter@f1037a0...04424e1 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865) 2024-05-06 karel.klic@managry.com Fix Tooltip.decoration comment (flutter/flutter#147858) 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854) 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853) 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852) 2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845) 2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842) 2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841) 2024-05-05 polinach@google.com Fix test. (flutter/flutter#147813) 2024-05-05 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821) 2024-05-05 32538273+ValentinVignal@users.noreply.github.com Reland fix memory leaks for tab selector (flutter/flutter#147689) 2024-05-05 sokolovskyi.konstantin@gmail.com Fix memory leak in ExpansionTile. (flutter/flutter#147596) 2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834) 2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818) 2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791) 2024-05-03 102401667+Dimilkalathiya@users.noreply.github.com fixes `SearchAnchor` leak (flutter/flutter#147652) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780) 2024-05-03 engine-flutter-autoroll@skia.org Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782) 2024-05-03 leroux_bruno@yahoo.fr Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…r#6674) flutter/flutter@f1037a0...04424e1 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865) 2024-05-06 karel.klic@managry.com Fix Tooltip.decoration comment (flutter/flutter#147858) 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854) 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853) 2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852) 2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845) 2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842) 2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841) 2024-05-05 polinach@google.com Fix test. (flutter/flutter#147813) 2024-05-05 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821) 2024-05-05 32538273+ValentinVignal@users.noreply.github.com Reland fix memory leaks for tab selector (flutter/flutter#147689) 2024-05-05 sokolovskyi.konstantin@gmail.com Fix memory leak in ExpansionTile. (flutter/flutter#147596) 2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834) 2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818) 2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791) 2024-05-03 102401667+Dimilkalathiya@users.noreply.github.com fixes `SearchAnchor` leak (flutter/flutter#147652) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780) 2024-05-03 engine-flutter-autoroll@skia.org Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782) 2024-05-03 leroux_bruno@yahoo.fr Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: leak tracking
Issues and PRs related to memory leaks detected by leak_tracker
f: cupertino
flutter/packages/flutter/cupertino repository
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #141198
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.