Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tooltip.decoration comment #147858

Merged
merged 1 commit into from May 6, 2024
Merged

Fix Tooltip.decoration comment #147858

merged 1 commit into from May 6, 2024
+2 −2

Conversation

karelklic
Copy link
Contributor

@karelklic karelklic commented May 6, 2024 •
edited

Tooltip decoration's comment had the backgrounds for Brightness.dark and Brightness.light swapped.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla Google CLA
Copy link

google-cla bot commented May 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 6, 2024
TahaTesser
TahaTesser approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser requested a review from bleroux May 6, 2024 12:13
bleroux
bleroux approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for spotting this typo.

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2024
@auto-submit auto-submit bot merged commit f94b1e1 into flutter:master May 6, 2024
72 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2024
@engine-flutter-autoroll
f94b1e1fc Fix Tooltip.decoration comment (flutter/flutter#147858)
2108946
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2024
@engine-flutter-autoroll
f94b1e1fc Fix Tooltip.decoration comment (flutter/flutter#147858)
fb7c2f5
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 6, 2024
@engine-flutter-autoroll
Roll Flutter from f1037a01b796 to 04424e10fe28 (25 revisions) (#6674)
c4843a7 
flutter/flutter@f1037a0...04424e1

2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865)
2024-05-06 karel.klic@managry.com Fix Tooltip.decoration comment (flutter/flutter#147858)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852)
2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845)
2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842)
2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841)
2024-05-05 polinach@google.com Fix test. (flutter/flutter#147813)
2024-05-05 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821)
2024-05-05 32538273+ValentinVignal@users.noreply.github.com Reland fix memory leaks for tab selector (flutter/flutter#147689)
2024-05-05 sokolovskyi.konstantin@gmail.com Fix memory leak in ExpansionTile. (flutter/flutter#147596)
2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834)
2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818)
2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791)
2024-05-03 102401667+Dimilkalathiya@users.noreply.github.com fixes `SearchAnchor` leak (flutter/flutter#147652)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780)
2024-05-03 engine-flutter-autoroll@skia.org Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782)
2024-05-03 leroux_bruno@yahoo.fr Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from f1037a01b796 to 04424e10fe28 (25 revisions) (flutte…
72dd009 
…r#6674)

flutter/flutter@f1037a0...04424e1

2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865)
2024-05-06 karel.klic@managry.com Fix Tooltip.decoration comment (flutter/flutter#147858)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852)
2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845)
2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842)
2024-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841)
2024-05-05 polinach@google.com Fix test. (flutter/flutter#147813)
2024-05-05 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821)
2024-05-05 32538273+ValentinVignal@users.noreply.github.com Reland fix memory leaks for tab selector (flutter/flutter#147689)
2024-05-05 sokolovskyi.konstantin@gmail.com Fix memory leak in ExpansionTile. (flutter/flutter#147596)
2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834)
2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818)
2024-05-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791)
2024-05-03 102401667+Dimilkalathiya@users.noreply.github.com fixes `SearchAnchor` leak (flutter/flutter#147652)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780)
2024-05-03 engine-flutter-autoroll@skia.org Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782)
2024-05-03 leroux_bruno@yahoo.fr Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karelklic @bleroux @TahaTesser