-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes CupertinoModalPopupRoute
#147823
Merged
polina-c
merged 20 commits into
flutter:master
from
Dimilkalathiya:cupertino_popup_leak
May 20, 2024
+37
−1
Merged
fixes CupertinoModalPopupRoute
#147823
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2ae9408
fixes `CupertinoModalPopupRoute` and `CupertinoDialogRoute` leaks
Dimilkalathiya 8cfa578
Merge branch 'master' into cupertino_popup_leak
polina-c fd1ae18
fix test case and make `buildTransitions` less invasive
Dimilkalathiya f9affe9
add function to old position for better review
Dimilkalathiya 61509e8
indentation fix
Dimilkalathiya da7a9a8
indentation fix
Dimilkalathiya 884d5e6
Merge branch 'master' into cupertino_popup_leak
polina-c 0a5828a
Merge remote-tracking branch 'origin/master' into cupertino_popup_leak
Dimilkalathiya 6ea72f2
init animation once
Dimilkalathiya 2beda7c
avoid behavior change if user passed custom transition
Dimilkalathiya 9e97987
making transitionBuilder final
Dimilkalathiya 7e133ad
Merge remote-tracking branch 'upstream/master' into cupertino_popup_leak
Dimilkalathiya 984cd41
revert conflicting changes
Dimilkalathiya 2bb9df7
fix space issue
Dimilkalathiya 6bf1f0d
fix test case
Dimilkalathiya 4fb47bf
remove test to check cause of failure
Dimilkalathiya 382917b
remove everything except test-case
Dimilkalathiya d8a8f4c
remove everything and minor change on text
Dimilkalathiya 6414b89
fix `CupertinoModalPopupRoute` leak
Dimilkalathiya ee9d6c8
revert spell change
Dimilkalathiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You moved this method to other place, that made it hard to see diff. Can you move it back to make code review easier?