Remove package:http from Flutter #15416

jonahwilliams · 2018-03-11T23:12:05Z

Flutter will no longer automatically include package:http, nor will it support setting createHttpClient to override the default client.

NetworkAssetBundle and ImageProvider now use dart:io HttpClient directly.
NetworkAssetBundle and ImageProvider use the content-length header if provided to allocate directly into a Uint8List.
Moved some tests which used package:http MockClient to a Mockito based test.
Tests that need mock http requests should use HttpOverrides.runZoned to provide a mock HttpClient instance. For an example, see dev/manual_tests/test/card_collection_test.dart

flutter_test now uses HttpOverrides.global to set a default mocked client which always returns empty 400 responses. This is completely private, clients should author their own overrides if they want specific behavior.

This is a breaking change.

Fixes #13456

This saves a solid 1.4 Kb from the Gallery app on Android.

Hixie · 2018-03-12T00:16:50Z

One thing we lose with this is that we used to use only a single HTTP client for all network requests done by the app. That seems unfortunate (e.g. you have to configure the UA string multiple times). Would it make sense to keep an equivalent to createHttpClient around?

xqwzts · 2018-03-12T14:31:52Z


No it isn't, sorry I misread that.

Ah it is in the flutter for react-native docs though: https://flutter.io/flutter-for-react-native/#making-http-networking-requests

gspencergoog · 2018-03-12T16:25:47Z

Also, there are some scripts that imported http that will probably fail now. You should make sure that they have http in their pubspecs. It looks like you fixed some of them, but not all:

./packages/flutter_tools/test/crash_reporting_test.dart:12:import 'package:http/http.dart';
./packages/flutter_tools/lib/src/crash_reporting.dart:7:import 'package:http/http.dart' as http;
./dev/bots/prepare_package.dart:11:import 'package:http/http.dart' as http;
./dev/tools/java_and_objc_doc.dart:9:import 'package:http/http.dart' as http;

jonahwilliams · 2018-03-12T17:22:58Z

@Hixie

One thing we lose with this is that we used to use only a single HTTP client for all network requests done by the app. That seems unfortunate (e.g. you have to configure the UA string multiple times). Would it make sense to keep an equivalent to createHttpClient around?

I don't think that is true (at least at master). createHttpClient always returns a new client and package:http's IoClient always created a new HttpClient. We can actually get this feature back using HttpOverrides. For example, the following snippet will make new HttpClient() into a singleton.

class FlutterHttpOverrides extends HttpOverrides {
  HttpClient _httpClient;

  HttpClient createHttpClient(SecurityContext context) {
    return _httpClient ??= new HttpClient();
  }
}

@xqwzts It looks like there are references to createHttpClient in those docs, as well as the udacity course. I will file follow up bugs to fix the documentation and note them in this PR.

@gspencergoog Thanks, I've added the missing dependency to the tools/ folder.

jonahwilliams · 2018-03-12T17:54:00Z

Filed #15447 for updating the website

jonahwilliams · 2018-03-12T19:00:59Z

Filed https://github.com/flutter/udacity-course/issues/72 for the udacity course. I can open PRs to update the code in each after this PR is resolved

Hixie · 2018-03-14T19:59:48Z

dev/bots/pubspec.yaml

  http_multi_server: 2.0.4 # TRANSITIVE DEPENDENCY
-  http_parser: 3.1.1 # TRANSITIVE DEPENDENCY


please make sure to run flutter update-packages --force-upgrade to update the pubspec.yaml files.

…m flutter_test

jonahwilliams · 2018-03-19T21:48:23Z

@Hixie I've updated the dependencies and the documentation that refers to createHttpClient, is there anything else I need to do for this?

Hixie · 2018-03-21T00:48:27Z

packages/flutter/lib/src/painting/image_provider.dart

+      final Uint8List bytes = new Uint8List(response.contentLength);
+      int offset = 0;
+      response.listen((List<int> chunk) {
+          for (int i = 0; i < chunk.length; i++, offset++) {


nit: += 1 rather than ++

but forget that. Instead of this loop, just use bytes.addAll(chunk).

or rather, bytes.setRange

Hixie · 2018-03-21T01:04:33Z

packages/flutter/lib/src/painting/image_provider.dart

+        cancelOnError: true,
+      );
+    }
+    final Uint8List bytes = await completer.future;


cc @rmacnak-google who may have a better idea of how to do this without copying bytes multiple times.

I think the case where the total length is known is optimal: copy from the OS socket into the chunk, copy from chunks into the linear buffer. The unknown length case has additional copies from growing the buffer and trimming the final result. I believe the chunks are not recycled, so it could be improved by holding onto the chunks and building the linear buffer after receiving the last chunk.

Well the "optimal" case wouldn't copy at all, right, we'd just re-use the OS buffer unmodified...

Hixie · 2018-03-21T01:05:12Z

packages/flutter/lib/src/services/asset_bundle.dart

+        completer.complete(bytes.buffer.asByteData());
+      },
+      cancelOnError: true);
+    }


we should definitely not duplicate this code. see if you can factor it out into something in the foundation library, so that we only have to optimize it once.

moved to response_converter.dart in foundation

Hixie · 2018-03-21T01:06:42Z

packages/flutter/lib/src/services/asset_bundle.dart

-      );
-    return response.body;
+    final ByteData bytes = await load(key);
+    return const Utf8Decoder().convert(bytes.buffer.asUint8List());


we really shouldn't do the UTF8 conversion on the main thread if the data size is big. Look for uses of compute which show how to move this kind of thing off the main thread.

Since this logic is shared by all of the Bundle classes I moved it into the base class.

Hixie · 2018-03-21T01:08:27Z

LGTM modulo comments above.

… base class

xqwzts · 2018-03-21T21:38:41Z

examples/hello_world/lib/main.dart

@@ -4,4 +4,6 @@

 import 'package:flutter/widgets.dart';

-void main() => runApp(const Center(child: const Text('Hello, world!', textDirection: TextDirection.ltr)));
+void main() {


Fat arrow syntax for main() => is preferred in examples, so new users don't write any statements other than runApp there - which wouldn't be picked up by the hot reload.

Woops, shouldn't have committed this

jonahwilliams · 2018-03-21T23:24:06Z

@Hixie , @rmacnak-google PTAL at the updated response conversion code in https://github.com/jonahwilliams/flutter/blob/f7ee16fc1167db31f7cbcbf721ffe69ca24d38bf/packages/flutter/lib/src/foundation/convert_response.dart

rmacnak-google · 2018-03-21T23:29:08Z

lgtm

Hixie · 2018-03-22T01:22:20Z

packages/flutter/lib/src/foundation/convert_response.dart

@@ -0,0 +1,45 @@
+import 'dart:async';


need license block (copy it from another file verbatim then change the year to 2018) with no other changes

Hixie · 2018-03-22T01:22:27Z

packages/flutter/lib/src/foundation/convert_response.dart

+import 'dart:io';
+import 'dart:typed_data';
+
+


remove a blank line here

Hixie · 2018-03-22T01:23:04Z

packages/flutter/lib/src/foundation/convert_response.dart

+/// Efficiently converts the response body of an [HttpClientResponse] into a [Uint8List].
+/// 
+/// The future returned by [convert] will forward all errors emitted by [response].
+Future<Uint8List> convertResponse(HttpClientResponse response) {


Does this have to be an HttpClientResponse, or will it work with any Stream<List<int>>?

i guess you need contentLength, oh well.

Hixie · 2018-03-22T01:27:54Z

packages/flutter/lib/src/foundation/convert_response.dart

+/// Efficiently converts the response body of an [HttpClientResponse] into a [Uint8List].
+/// 
+/// The future returned by [convert] will forward all errors emitted by [response].
+Future<Uint8List> convertResponse(HttpClientResponse response) {


Since this is a global method, let's call it something more specific, like "consolidateHttpClientResponseBytes" or something.

Hixie · 2018-03-22T01:29:31Z

LGTM!

…dd header

* use HttpOverrides and dart:io HttpClient in flutter * add missing package:http dependency * update flutter packages and remove comment about createHttpClient from flutter_test * move byte loading logic to common class, move string parsing logic to base class * addAll doesn't work for a Uint8List * use bytes.setRange * undo addition to hello_world * add newline to end of binding.dart * and a newline for hello world * refactor to function and add tests * address comments on unknown length case * alignment * sort alaphabetically * rename convertResponse to consolidateClientHttpClientResponseBytes. Add header * fix alignment in test

use HttpOverrides and dart:io HttpClient in flutter

77480ad

googlebot added the cla: yes label Mar 11, 2018

jonahwilliams mentioned this pull request Mar 11, 2018

Remove package:http from flutter #15364

Closed

add missing package:http dependency

6993a59

jonahwilliams mentioned this pull request Mar 14, 2018

Pin transitive deps for production dependencies, not just dev dependencies #15080

Closed

Hixie reviewed Mar 14, 2018

View reviewed changes

jonahwilliams and others added 4 commits March 14, 2018 15:31

Merge branch 'master' into remove_http_2

b5d6559

update flutter packages and remove comment about createHttpClient fro…

eeb14c3

…m flutter_test

fix merge

7a4d51f

Merge remote-tracking branch 'upstream/master' into remove_http_2

3524ffe

jonahwilliams mentioned this pull request Mar 17, 2018

Remove references to deprecated createHttpClient method flutter/website#893

Merged

Merge remote-tracking branch 'upstream/master' into remove_http_2

b011f70

Hixie reviewed Mar 21, 2018

View reviewed changes

jonahwilliams added 4 commits March 21, 2018 10:55

accept incoming merge

ec61b99

move byte loading logic to common class, move string parsing logic to…

257bf5a

… base class

addAll doesn't work for a Uint8List

bba219e

use bytes.setRange

df47334

xqwzts reviewed Mar 21, 2018

View reviewed changes

undo addition to hello_world

d11e7fc

jonahwilliams added 5 commits March 21, 2018 14:43

add newline to end of binding.dart

a7a6df2

and a newline for hello world

e276c37

refactor to function and add tests

13f5ae1

address comments on unknown length case

06e84d0

alignment

f7ee16f

sort alaphabetically

ff9e002

Hixie reviewed Mar 22, 2018

View reviewed changes

jonahwilliams added 2 commits March 21, 2018 21:33

rename convertResponse to consolidateClientHttpClientResponseBytes. A…

689081e

…dd header

fix alignment in test

d98b56f

jonahwilliams merged commit 88cc977 into flutter:master Mar 22, 2018

jonahwilliams deleted the remove_http_2 branch March 22, 2018 15:21

github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove package:http from Flutter #15416

Remove package:http from Flutter #15416

jonahwilliams commented Mar 11, 2018 •

edited

Hixie commented Mar 12, 2018

xqwzts commented Mar 12, 2018 •

edited

gspencergoog commented Mar 12, 2018 •

edited

jonahwilliams commented Mar 12, 2018

jonahwilliams commented Mar 12, 2018

jonahwilliams commented Mar 12, 2018

Hixie Mar 14, 2018

jonahwilliams commented Mar 19, 2018

Hixie Mar 21, 2018

Hixie Mar 21, 2018

Hixie Mar 21, 2018

jonahwilliams Mar 21, 2018

Hixie Mar 21, 2018

rmacnak-google Mar 21, 2018

Hixie Mar 22, 2018

Hixie Mar 21, 2018

jonahwilliams Mar 21, 2018

Hixie Mar 21, 2018

jonahwilliams Mar 21, 2018

Hixie commented Mar 21, 2018

xqwzts Mar 21, 2018

jonahwilliams Mar 21, 2018

jonahwilliams commented Mar 21, 2018

rmacnak-google commented Mar 21, 2018

Hixie Mar 22, 2018

Hixie Mar 22, 2018

Hixie Mar 22, 2018

Hixie Mar 22, 2018

Hixie Mar 22, 2018

Hixie commented Mar 22, 2018

		http_multi_server: 2.0.4 # TRANSITIVE DEPENDENCY
		http_parser: 3.1.1 # TRANSITIVE DEPENDENCY

Remove package:http from Flutter #15416

Remove package:http from Flutter #15416

Conversation

jonahwilliams commented Mar 11, 2018 • edited

Hixie commented Mar 12, 2018

xqwzts commented Mar 12, 2018 • edited

gspencergoog commented Mar 12, 2018 • edited

jonahwilliams commented Mar 12, 2018

jonahwilliams commented Mar 12, 2018

jonahwilliams commented Mar 12, 2018

Choose a reason for hiding this comment

jonahwilliams commented Mar 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hixie commented Mar 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonahwilliams commented Mar 21, 2018

rmacnak-google commented Mar 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hixie commented Mar 22, 2018

jonahwilliams commented Mar 11, 2018 •

edited

xqwzts commented Mar 12, 2018 •

edited

gspencergoog commented Mar 12, 2018 •

edited