Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Indonesian (id) and Norwegian (no) locales #15708

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

HansMuller
Copy link
Contributor

Fixes #15192

Support for Norwegian was originally a contribution from Marcin Urbański - #15452

@gspencergoog
Copy link
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@HansMuller HansMuller merged commit 076594b into flutter:master Mar 19, 2018
@HansMuller HansMuller deleted the add_id_and_no_locales branch March 19, 2018 22:07
@yjbanov
Copy link
Contributor

yjbanov commented Mar 19, 2018

Belated LGTM

@Fideas
Copy link

Fideas commented Mar 20, 2018

There is a typo in packages/flutter_localizations/test/translations_test.dart
it says:
'nl', // Norwegian

it should say:
'no', // Norwegian

@HansMuller
Copy link
Contributor Author

Thanks for the report! Will fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we add Indonesia language into Localization.dart in the Beta channel?
5 participants