Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 #20427

mkustermann · 2018-08-10T12:36:27Z

This includes:

Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (#5987)

aam · 2018-08-10T17:25:59Z

There seems to be issues with mockito package:

╰─➤  bin/flutter doctor                                                                                                               130 ↵
Building flutter tool...
The current Dart SDK version is 2.1.0-dev.0.0.flutter-be6309690f.

Because flutter_tools depends on mockito >=0.8.1 <3.0.0-beta+3 which requires SDK version >=1.0.0 <2.0.0-∞, version solving failed.
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...

mkustermann · 2018-08-13T09:15:31Z

Turns out Siva's roll in the engine wasn't further rolled into flutter/flutter yet.

Doing this will require upgrading all 3rd party packages in pubspec files to be compatible with Dart 2, since this roll includes a new version number, namely 2.1.0-dev.0.0.

I've tried to find all the necessary package upgrades and filed issues for:

So far.

Hixie · 2018-08-14T20:25:00Z

packages/flutter_tools/lib/src/commands/update_packages.dart

-  'matcher': '0.12.2+1', // TODO(ianh): https://github.com/flutter/flutter/issues/18608, https://github.com/dart-lang/matcher/pull/88
-  'flutter_gallery_assets': '0.1.4', // See //examples/flutter_gallery/pubspec.yaml
+  'mockito': '3.0.0',
+  'matcher': '0.12.3+1', // TODO(ianh): https://github.com/flutter/flutter/issues/18608


Please don't do this. It's a breaking change for our users.

Guess this issue has been resolved already by #20602

Hixie · 2018-08-14T20:25:57Z

packages/flutter_tools/lib/src/commands/update_packages.dart

@@ -1075,6 +1075,7 @@ String _generateFakePubspec(Iterable<PubspecDependency> dependencies) {
    if (!dependency.pointsToSdk)
      dependency.describeForFakePubspec(result, overrides);
  result.write(overrides.toString());
+  //print('XXXX: ${result.toString()}');


nit: commented out code

This includes: Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter#5987)

…t to avoid defaulting to <2.0.0

…ter_tester will crash very deeply inside Dart VM

mkustermann · 2018-08-15T09:15:01Z

The SEGV crash in the flutter_tester binary crashed very deeply inside the Dart VM when doing a constant evaluation inside package:test code.

After debugging this for a while it became clear that this is due to a missing platform file, which caused the VM to fall back to code paths which it should never fall back to in a Dart 2.0 world.

The root cause was flutter/engine@a84b210 which renamed the platform file the flutter_tester binary expects, but a corresponding change in flutter wasn't done yet.

…/pull/20427)

mkustermann · 2018-08-15T12:02:59Z

Since the engine->flutter roll also brings in new skia changes, I've made flutter/goldens#11 to update the goldens.

…/pull/20427) (#11)

mraleph · 2018-08-15T12:11:28Z

still LGTM

mkustermann · 2018-08-15T13:17:33Z

The existing redness on the flutter dashboard needs to be investigated, e.g. I can see e.g. stderr: > Java heap space in this log, but I think it makes sense to land this now, since there are already more engine commits waiting to be rolled in. Hope that this is ok.

This reverts commit c7c493e.

Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)

This is a re-land with downgraded `package:flutter_gallery_assets` version.

* Reland "Roll engine to version b148e62 (#20427)" This is a re-land with downgraded `package:flutter_gallery_assets` version. * Downgrade package:flutter_gallery_assets to 0.1.4 * Change engine.version to 81baff9 (which contains an additional fix) * Change engine.version to e3687f7 (since mac tarballs are corrupted on earlier commit)

mkustermann requested a review from mraleph August 10, 2018 12:36

googlebot added the cla: yes label Aug 10, 2018

mraleph approved these changes Aug 10, 2018

View reviewed changes

mkustermann force-pushed the roll branch from 85f74ec to a52273a Compare August 10, 2018 14:32

mkustermann force-pushed the roll branch from a52273a to f8ac00f Compare August 13, 2018 07:58

This was referenced Aug 13, 2018

Please publish a new version, which is compatible with Dart SDK ^2.1.0 google/process.dart#32

Closed

Declare compatibility with Dart 2 stable dart-lang/platform#17

Closed

Please publish a new version of package:file google/file.dart#105

Closed

mkustermann mentioned this pull request Aug 14, 2018

Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 flutter/engine#6012

Merged

mkustermann changed the title ~~Roll engine to version 2ab499d917c51768da8ec84b0547a463fe6cee52~~ Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 Aug 14, 2018

Hixie reviewed Aug 14, 2018

View reviewed changes

mkustermann mentioned this pull request Aug 15, 2018

Random crash on all my apps #20255

Closed

mkustermann added 6 commits August 15, 2018 10:19

Roll engine to version 2ab499d

39754d7

This includes: Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter#5987)

Upgrade to newer pubspec dependencies (not complete yet)

a5fddb8

Remaining 3rd party package upgrades, add explicit dart sdk constrain…

4ecd802

…t to avoid defaulting to <2.0.0

revert temporary change

778787b

Upgrade to dartdoc 0.20.3

c20f400

revert temporary change to update_packages.dart

c64985b

mkustermann force-pushed the roll branch from 95e3093 to c64985b Compare August 15, 2018 08:45

Fix SEGV in Dart VM: With non-existent platform_strong.dill file flut…

8d8ec2c

…ter_tester will crash very deeply inside Dart VM

Use platform_strong.dill in devfs bundling as well to avoid SEGV

087c76a

mkustermann added a commit to flutter/goldens that referenced this pull request Aug 15, 2018

Update goldens for unblocking engine -> flutter roll (flutter/flutter…

7b87a32

…/pull/20427)

Update pubspec.yaml.tmpl files to include new sdk constraint

4c6b967

mkustermann added a commit to flutter/goldens that referenced this pull request Aug 15, 2018

Update goldens for unblocking engine -> flutter roll (flutter/flutter…

6c45faf

…/pull/20427) (#11)

Roll goldens.version

bcce82e

mkustermann mentioned this pull request Aug 15, 2018

roll engine to version d90223fadfd219af23d4a4c260a78fb21be3fe99 #20403

Closed

mkustermann merged commit c7c493e into flutter:master Aug 15, 2018

mkustermann deleted the roll branch August 15, 2018 13:22

mkustermann added a commit that referenced this pull request Aug 15, 2018

Revert "Roll engine to version b148e62 (#20427)"

f7ed35e

This reverts commit c7c493e.

mkustermann mentioned this pull request Aug 15, 2018

It appears like the examples/flutter_gallery is not being built for github PR presubmit tests #20632

Closed

mkustermann added a commit to mkustermann/flutter that referenced this pull request Aug 15, 2018

Reland "Roll engine to version b148e62 (flutter#20427)"

3800378

This is a re-land with downgraded `package:flutter_gallery_assets` version.

github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 #20427

Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 #20427

mkustermann commented Aug 10, 2018

aam commented Aug 10, 2018

mkustermann commented Aug 13, 2018

Hixie Aug 14, 2018

mkustermann Aug 15, 2018

Hixie Aug 14, 2018

mkustermann Aug 15, 2018

mkustermann commented Aug 15, 2018

mkustermann commented Aug 15, 2018

mraleph commented Aug 15, 2018

mkustermann commented Aug 15, 2018 •

edited

Loading

Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 #20427

Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 #20427

Conversation

mkustermann commented Aug 10, 2018

aam commented Aug 10, 2018

mkustermann commented Aug 13, 2018

Hixie Aug 14, 2018

Choose a reason for hiding this comment

mkustermann Aug 15, 2018

Choose a reason for hiding this comment

Hixie Aug 14, 2018

Choose a reason for hiding this comment

mkustermann Aug 15, 2018

Choose a reason for hiding this comment

mkustermann commented Aug 15, 2018

mkustermann commented Aug 15, 2018

mraleph commented Aug 15, 2018

mkustermann commented Aug 15, 2018 • edited Loading

mkustermann commented Aug 15, 2018 •

edited

Loading