Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextFormField cursor params #24635

Merged
merged 5 commits into from Dec 11, 2018
Merged

TextFormField cursor params #24635

merged 5 commits into from Dec 11, 2018

Conversation

justinmc
Copy link
Contributor

@justinmc justinmc commented Nov 22, 2018 •
edited

Adds TextField's cursor params to TextFormField.

Closes #24615
Closes #21198

@justinmc justinmc self-assigned this Nov 22, 2018
@justinmc justinmc changed the title WIP TextFormField cursor params TextFormField cursor params Nov 26, 2018
HansMuller
HansMuller approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc
Copy link
Contributor Author

Ready to merge after code freeze.

@zoechi zoechi added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 28, 2018
@justinmc justinmc mentioned this pull request Dec 7, 2018
Closed
@justinmc justinmc merged commit 6901cd4 into flutter:master Dec 11, 2018
@justinmc justinmc deleted the form-text-field-cursor-color branch December 11, 2018 18:42
jonahwilliams added a commit that referenced this pull request Dec 11, 2018
@jonahwilliams
Revert "TextFormField cursor params (#24635)"
7a0ff48 
This reverts commit 6901cd4.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees

@justinmc justinmc

Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormTextField should also have a cursorColor property Allow Cursor customization in a TextFormField
4 participants
@justinmc @HansMuller @zoechi @googlebot