Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for floating cursor #25384

Merged
merged 30 commits into from Dec 14, 2018

Conversation

Projects
None yet
7 participants
@jslavitz
Copy link
Contributor

jslavitz commented Dec 14, 2018

Adds framework support for the floating cursor for text editing on iOS. It can be triggered by either a force press on the keyboard or (on iOS 12) by long pressing the spacebar. Fixes #17030 (#5445, #24761).

jslavitz added some commits Nov 21, 2018

nit
nit
nit
fix

@googlebot googlebot added the cla: yes label Dec 14, 2018

@xster

This comment has been minimized.

Copy link
Contributor

xster commented Dec 14, 2018

LGTM. Check devicelab tests before merging.

@jslavitz jslavitz merged commit ad2e3eb into flutter:master Dec 14, 2018

14 checks passed

analyze
Details
build_tests-linux
Details
build_tests-macos
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
codelabs-build-test
Details
docs
Details
flutter-build
tests-linux
Details
tests-macos
Details
tests-windows
Details
tool_tests-linux
Details
tool_tests-macos
Details
tool_tests-windows
Details

@jslavitz jslavitz deleted the jslavitz:force-cursor branch Dec 18, 2018

@jslavitz jslavitz restored the jslavitz:force-cursor branch Dec 18, 2018

@eseidelGoogle

This comment has been minimized.

Copy link
Contributor

eseidelGoogle commented Dec 21, 2018

I'm so happy to see this landing!

@AppleEducate

This comment has been minimized.

Copy link

AppleEducate commented Dec 28, 2018

Is this working on the master branch? I have still not got this to work in any of my flutter apps?

Rahiche pushed a commit to Rahiche/flutter_code_input that referenced this pull request Jan 6, 2019

add backgroundCursorColor
*backgroundCursorColor is required because of [#25384](flutter/flutter#25384)
*fixed some typos
*formatting
@anderscheow

This comment has been minimized.

Copy link

anderscheow commented Jan 10, 2019

I need this badly as it does not provide full iOS experience!

@xster

This comment has been minimized.

Copy link
Contributor

xster commented Jan 10, 2019

This is on the dev branch since 1.1.3. It should be out on beta in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.