Adds support for floating cursor #25384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Check devicelab tests before merging. |
zoechi
added
a: text input
|
I'm so happy to see this landing! |
|
Is this working on the master branch? I have still not got this to work in any of my flutter apps? |
Rahiche
pushed a commit
to Rahiche/flutter_code_input
that referenced
this pull request
Jan 6, 2019
*backgroundCursorColor is required because of [#25384](flutter/flutter#25384) *fixed some typos *formatting
|
I need this badly as it does not provide full iOS experience! |
|
This is on the dev branch since 1.1.3. It should be out on beta in the next few days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds framework support for the floating cursor for text editing on iOS. It can be triggered by either a force press on the keyboard or (on iOS 12) by long pressing the spacebar. Fixes #17030 (#5445, #24761).