Add --watch mode to flutter test
#26247
Conversation
Catch up to flutter/flutter master
Merge from flutter/flutter
gamebox
force-pushed
the
flutter-tester-watcher
branch
from
11d323b
to
471761e
Compare
|
Its pretty difficult to tell what changed here. I would start by undoing the formatting and general refactoring changes |
zoechi
added
a: tests
gamebox
force-pushed
the
flutter-tester-watcher
branch
from
2ada278
to
72d7601
Compare
|
@jonahwilliams Updated with a much more readable series of commits. |
gamebox
force-pushed
the
flutter-tester-watcher
branch
from
72d7601
to
cd58b67
Compare
|
I haven't forgotten about this! Taking a longer look at it today. |
|
The test failures are expected due to the facts laid out in the commit message of the commit just added |
|
Refactoring is fine but not necessary to this PR. I pulled your gamebox/flutter and pointed test at gamebox/test with dependency overrides. What is the intended workflow here? am I watching everything, a specific test file, or a library file?. I can see different cases where a watch command is useful depending on what I am working on:
Have you considered any other approaches? For example, I could wire up either command myself with some shell commands, but it would be too slow. Thus it seems like caching the kernel files to disk might also speed up incremental runs. Of course, you would have to be more careful with invalidation! |
|
I'll just mention #4719 here since it's relevant. |
|
@jonahwilliams Just an update, my change dart-lang/test was approved. Once it's merged, @grouma will cut a new release, and then I can update this branch to use it |
|
Alright @jonahwilliams , this includes the dart-lang/test updates, so this should reflect generally what I would like to release as a WIP feature in the tool. The semantics have been changed from rerun-on-save, to the same as hot reload('r' to rerun, 'q' to quit). |
|
Got everything working locally, this is pretty neato! |
|
Will address the rest of the comments in the morning. Thanks for the thorough review. Most of my issues remaining have to do with updating the dependencies. Will discuss offline. |
gamebox
changed the title
flutter testflutter test
* Revert "Replace netls and netaddr with dev_finder (flutter#26090)" This reverts commit eee154a.
…r change (flutter#26239) * Force DatePicker value to stay within firstDate and lastDate upon year change * updated per review feedback
flutter/engine@7112b72...e5ec3cf git log 7112b72..e5ec3cf --no-merges --oneline e5ec3cf Dart SDK roll for 2019-01-08 08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10 commits) (flutter/engine#7407) e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12 commits) (flutter/engine#7406) 0f8273b Dart SDK roll for 2019-01-07 4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401) 4820cbe Dart SDK roll for 2019-01-07 8eccb86 Add onStart hook to FlutterFragmentActivity (flutter/engine#6719) f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10 commits) (flutter/engine#7400) 5ca8aad Announce in/out of list (flutter/engine#6918) 4487d39 Replace Java code with equivalent, more concise code. (flutter/engine#7398) 395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11 commits) (flutter/engine#7394) 5965f90 Make `ParagraphConstraints` have const constructor (flutter/engine#7346) e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2 commits) (flutter/engine#7390) f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2 commits) (flutter/engine#7389)
* Remove *.lock from gitignore * Remove pubspec.lock from gitignore
* the onStart callback will report the location of the pointer where it wins the gesture arena by default instead of the pointer down location. Fixes all tests related to changing this default value.
The variable isn't interpolating because it's using "${}" when ruby uses "#{}".
…ter create -t module'command (flutter#23817)
…code 10 (flutter#23188) * Check for bad configuration in Xcode10
* update docs for editable_text (TextField) * typo, clarify behavior when lines > 1
When setting the Fuchsia logging function, it should happen before any initialization code, as init can still cause warning/error/info messages to get printed to logs. Since the default stderr/stdout fd's aren't correct, this can cause a program to crash for unclear reasons.
So that it can instead be used inside of `test/runner.dart`
So that it can be used in 'test/runner.dart'
To allow for test watching and incremental compilation
Allows for incremental compile and running of test suites
Use new runTests method, and handle cleanup manually when tests complete. This is blocked by dart-lang/test#973 being merged and the flutter/flutter repo updating its dependency on a version that includes that PR
Also, a little polish on the UX, following hot reload semantics.
Removed references to 'hot reload', and cleaned style nits. Also, updated packages to pass analyze.
|
That last "queued" test has actually completed and passed. Don't know if that's something wrong on Cirrus or GH's side. |
gamebox
force-pushed
the
flutter-tester-watcher
branch
from
deab2d8
to
4f9fb8b
Compare
|
Closing in favor of (#27192) |
When flag is provided watch application directory for file changes and re-run tests on change, only incrementally compiling changed files. This provides a significant speedup on incremental edit/test cycle.