[Material] TabBarTheme text style parameters #26533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoechi
added
framework
HansMuller
suggested changes
Jan 15, 2019
| @@ -20,9 +20,9 @@ const List<Tab> _tabs = <Tab>[ | |||
| Tab(text: _tab3Text, icon: Icon(Icons.looks_3)), | |||
| ]; | |||
|
|
|||
| Widget _buildTabBar({ List<Tab> tabs = _tabs }) { | |||
| final TabController _tabController = TabController(length: 3, vsync: const TestVSync()); | |||
| final TabController _tabController = TabController(length: 3, vsync: const TestVSync()); | |||
There was a problem hiding this comment.
This change is subtly different. Now all of the tab test share the same tab controller which reduces isolation. I don't think that's what we want...
There was a problem hiding this comment.
Good point, changed this to a getter, that way every caller gets a new instance of TabController
HansMuller
suggested changes
Jan 15, 2019
HansMuller
approved these changes
Jan 15, 2019
…ure-tabTextStyles
…ure-tabTextStyles
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
* Add labelStyle + unselectedLabelStyle to TabBarTheme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
labelStyleandunselectedLabelStyleparameters to theTabBarTheme. This will allow users to specify text themes for all the tab bars in their apps.Both of these fields already existed on the
TabBarclass itself.