[Material] Refactor _build<Widget> methods in BottomNavBar #26722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
approved these changes
Jan 17, 2019
|
|
…bottomNavBuildFunctions
…bottomNavBuildFunctions
zoechi
added
framework
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
buildmethod of_BottomNavigationTile, pull out the three_build...methods into stateless widgets._buildIcon()-->_TileIconwidget_buildFixedLabel()-->_FixedLabelwidget_buildShiftingLabel()-->_ShiftingLabelwidgetThis is based on the advice that is now recommended, which is to favor extracting Stateless Widgets out of
Buildmethods rather than functions.Context: #19269
Note: This change is no-op