Use double literals where a double type is expected #27929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code more consistent but also fixes our flutter-analyze bot. Issue dart-lang/sdk#35940
mkustermann
commented
Feb 14, 2019
| @@ -802,7 +802,7 @@ class Curves { | |||
| /// Derived from Robert Penner’s easing functions. | |||
| /// | |||
| /// {@animation 464 192 https://flutter.github.io/assets-for-api-docs/assets/animation/curve_ease_in_out_quart.mp4} | |||
| static const Cubic easeInOutQuart = Cubic(0.77, 0, 0.175, 1.0); | |||
| static const Cubic easeInOutQuart = Cubic(0.77, 0.0, 0.175, 1.0); | |||
There was a problem hiding this comment.
The code already uses 1.0 instead of 1. So this makes it more consistent.
sjindel-google
approved these changes
Feb 14, 2019
zoechi
added
team
tvolkert
added a commit
that referenced
this pull request
Feb 15, 2019
…1" (#28006) Re-applies #27409 by reverting #27919 The analyzer issue (dart-lang/sdk#35940) has been temporarily worked around by virtue of #27929
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code more consistent but also fixes our flutter-analyze bot.
Issue dart-lang/sdk#35940