Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the selection is still painted under the text #27970

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Make sure the selection is still painted under the text #27970

merged 1 commit into from
Feb 15, 2019

Conversation

xster
Copy link
Member

@xster xster commented Feb 14, 2019

Fixes #27961

@tvolkert tvolkert requested review from goderbauer and removed request for goderbauer February 14, 2019 23:55
goderbauer
goderbauer approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the quick fix!

@xster xster merged commit 22f8880 into flutter:master Feb 15, 2019
@zoechi zoechi added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected text disappears on iOS
4 participants
@xster @goderbauer @zoechi @googlebot