use deviceManager discovery in daemon protocol #28341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @devoncarew @DaveShuckerow - There is more context on the internal bug b/124835104 |
zoechi
added
the
tool
devoncarew
reviewed
Feb 22, 2019
|
@devoncarew PTAL when you have a few minutes |
devoncarew
approved these changes
Feb 25, 2019
| LinuxDevices(), | ||
| WindowsDevices(), | ||
| ]); | ||
| ] + _maybeAddDesktop); |
There was a problem hiding this comment.
I did not know that the additional operator worked for lists...
There was a problem hiding this comment.
I think it was added in 2.0 or shortly thereafter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the device discovery provided via the deviceManager. This allows client provided device types to be used via the flutter daemon protocol.
Related Issues
b/124835104
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?