Add warnings and an example to the TextEditingController docs #28604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Feb 27, 2019
| @@ -89,10 +133,17 @@ class TextEditingController extends ValueNotifier<TextEditingValue> { | |||
| /// that they need to update (it calls [notifyListeners]). For this reason, | |||
| /// this value should only be set between frames, e.g. in response to user | |||
| /// actions, not during the build, layout, or paint phases. | |||
| /// | |||
| /// This property can be set from a listener added to this | |||
| /// [TextEditingController] however one should not also set [selection]. | |||
There was a problem hiding this comment.
It feels like there is a full stop or maybe comma missing before "however"?
There was a problem hiding this comment.
Apparently the pedants (their word, not mine) would have us put a semicolon before the "however" and a comma afterwards: http://www.arrantpedantry.com/2012/02/07/however/. I will obey; however, I am confident that I will never understand all of the rules for commas.
| @@ -104,6 +155,11 @@ class TextEditingController extends ValueNotifier<TextEditingValue> { | |||
| /// that they need to update (it calls [notifyListeners]). For this reason, | |||
| /// this value should only be set between frames, e.g. in response to user | |||
| /// actions, not during the build, layout, or paint phases. | |||
| /// | |||
| /// This property can be set from a listener added to this | |||
| /// [TextEditingController] however one should not also set [text]. | |||
gspencergoog
approved these changes
Feb 27, 2019
HansMuller
force-pushed
the
editing_controller_value
branch
from
854f28f
to
7745ca9
Compare
zoechi
added
a: text input
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28307