Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding new diagrams for API Docs #29697

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 20, 2019

Description

This PR embeds 8 new diagrams from flutter/assets-for-api-docs:

  • Container (2)
  • ListView
  • ListView.builder
  • ListView.separated
  • Align.[constant]
  • Alignment
  • FractionalOffset
    All of these diagrams match the sample code in the API docs for their respective class and are placed above each matching snippet.

Related Issues

Fixes #13637
Related to #21136

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 20, 2019
@Piinks Piinks changed the title Embedding new diagrams for API Docs WIP Embedding new diagrams for API Docs Mar 21, 2019
@Piinks Piinks changed the title WIP Embedding new diagrams for API Docs Embedding new diagrams for API Docs Mar 22, 2019
@Piinks Piinks changed the title Embedding new diagrams for API Docs WIP Embedding new diagrams for API Docs Mar 25, 2019
@Piinks Piinks changed the title WIP Embedding new diagrams for API Docs Embedding new diagrams for API Docs Mar 25, 2019
@Piinks Piinks requested a review from goderbauer March 26, 2019 17:05
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

packages/flutter/lib/src/widgets/basic.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/basic.dart Outdated Show resolved Hide resolved
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit 76b9962 into flutter:master Mar 27, 2019
@Piinks Piinks deleted the diagramAdditions branch November 22, 2019 00:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add images and examples to Align
3 participants